e55d894f45
Consistently throw Exeception in OfflineMusicService
2021-05-26 21:32:52 +02:00
cebbb39caf
Merge pull request #502 from ultrasonic/dependabot/gradle/androidx.core-core-ktx-1.5.0
...
Bump core-ktx from 1.5.0-rc02 to 1.5.0
2021-05-24 10:37:25 +02:00
faee926c35
Bump core-ktx from 1.5.0-rc02 to 1.5.0
...
Bumps core-ktx from 1.5.0-rc02 to 1.5.0.
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-24 08:14:46 +00:00
04b4b154e4
Merge pull request #501 from tzugen/impl
...
Migrate MediaPlayerController to Kotlin
2021-05-24 09:23:53 +02:00
2db7d2daf1
Hide cluttering koin warning, which was added in 2.2.0 and will be removed again in 2.3.0
...
See https://github.com/InsertKoinIO/koin/issues/939 for more details
2021-05-22 11:01:12 +02:00
79fd1ac84f
Remove resolved issues from baselines
2021-05-21 23:34:57 +02:00
0500bd5e88
Handle also UnknownHostException in GenericListModel
2021-05-21 23:34:57 +02:00
005c1cb8f7
Fix an String resource int that wasn't converted to a String
2021-05-21 23:34:57 +02:00
3d99269c41
Remove context from ShufflePlayBuffer
2021-05-21 23:34:57 +02:00
ed6c6c9057
Remove two warnings in Downloader
2021-05-21 23:34:57 +02:00
b8fbbd8c49
Remove Context from Downloader & DownloadFile
2021-05-21 23:34:52 +02:00
9b2e54b94e
Remove context from JukeboxMediaPlayer and Scrobbler
2021-05-21 22:52:16 +02:00
00e64cdddc
Use lambdas in OfflineMusicService
2021-05-21 22:39:21 +02:00
1b5db9da1f
Make ExternalStorageMonitor context-free
2021-05-21 22:37:43 +02:00
df047dd463
Refactor MediaPlayerController to Kotlin
...
and also make MediaPlayerService context-free
2021-05-21 22:35:22 +02:00
a801e276ee
Rename .java to .kt
2021-05-21 22:35:21 +02:00
05cb82921d
Fix remaining warnings in MediaPlayerLifecycleSupport
2021-05-21 19:43:37 +02:00
f596dc77c1
Make MediaPlayerLifecycleSupport context-free
2021-05-21 19:43:32 +02:00
7922d6caad
Prevent leaks by making cleanup tasks static
2021-05-21 19:11:26 +02:00
b25a118148
Remove unused context from CacheCleaner
2021-05-21 18:50:57 +02:00
402fe961ba
Merge MediaPlayerController interface & implementation
2021-05-21 18:50:33 +02:00
6943dc5895
Merge pull request #500 from tzugen/detekt-3
...
Fix a lot of warnings, update baseline files, improve CI run times
2021-05-21 09:33:23 +02:00
f1713fdbd3
Use a recently maintained version of DSLV, which compiles correctly with newer Gradles.
2021-05-21 09:16:06 +02:00
b0b03c0fe0
Be more selective with the configuration of gradle.properties in CI
2021-05-20 18:16:55 +02:00
ab4c2c1bbe
Add staggered caching, to increase the times we have a warm cache
2021-05-20 18:16:55 +02:00
29a98c1263
The AGP build cache was removed in AGP 4.1. Previously introduced in AGP 2.3 to complement the Gradle build cache, the AGP build cache was superseded entirely by the Gradle build cache in AGP 4.1. This change does not impact build time.
2021-05-20 18:16:55 +02:00
78e4a00476
Our target sdk is 29
2021-05-20 18:16:55 +02:00
387119a90c
Make the CI fail if any new lint issues (warnings or errors) are added.
2021-05-20 18:16:55 +02:00
d26f8595ab
Manually disable IconMissingDensityFolder
2021-05-20 18:16:55 +02:00
dff054847a
Regenerate lint baseline
...
Removes 238 fixed issues
Adds 177 previously unlisted issues
2021-05-20 18:16:55 +02:00
10edce9f56
Disable daemon
2021-05-20 18:16:55 +02:00
3a05f30907
Fix more warnings
2021-05-20 18:16:55 +02:00
b559f6420e
Move certain ignores from the baseline to the specified files. This makes refactoring much less fragile.
2021-05-20 18:16:55 +02:00
689b704bc5
Enable parallel AST generation
2021-05-20 18:16:55 +02:00
a25a2ff337
Go back to default detekt checks.
...
Type resolution (which I had enabled some weeks ago) is really not stable enough for production and also takes much longer time to compile.
2021-05-20 18:16:55 +02:00
8b01118233
Remove local copy of com.mobeta.android.dslv in favour of importing it from maven
2021-05-20 18:16:42 +02:00
950cb6254f
Merge pull request #493 from tzugen/generic-views
...
Introduce new Generic Fragments, ViewModels, and Adapters for the display of API data.
2021-05-18 11:44:51 +02:00
5f08e7e7cd
Create a new SelectMusicFolderViewHolder instance when the Adapter is recreated,
...
instead of reusing an old one. This lead to a crash.
Also make the AlbumList use the correct placeholder,
remove an unused resource file, and update the placeholder to look less clumsy.
2021-05-18 08:50:04 +02:00
2cf80707f7
Correctly display the folder header also in album view
...
Also fix a number of smaller issues
2021-05-16 21:06:04 +02:00
72c03cc500
Introduce new Generic Fragments, ViewModels, and Adapters for the display of API data.
...
* Splits former SelectAlbumFragment into separate fragments for Albums and general collections of tracks
* Renames and refactors SelectArtist view to extend the new Generic classes
* Adds error handling (Fixes #484 )
* Adds EndlessScrolling capabilities to all Album Lists
* Uses RecyclerViews and LiveData for performance and in-memory caching
* Refreshes the UI to be aligned with the ArtistList UI
* Add a new GenericEntry to the domain data classes, and make other types extend it
2021-05-16 17:42:31 +02:00
c6a744cc14
Rename classes in preparation of split.
2021-05-16 17:42:31 +02:00
1fc7a954e9
Regenerate baseline files
2021-05-16 17:42:31 +02:00
13b00f75f0
Use default values for LongMethod, LongParameterList, LargeClass and ComplexMethod.
...
The algrorithms in detekt had changed when I updated detekt to v1.16, but our values not,
resulting in a very long baseline file with many non-sensical warnings.
By removing our config we follow the detekt config when they modify their algorithms again.
2021-05-16 17:42:31 +02:00
1599c96085
Merge pull request #476 from tzugen/j-center
...
Try to remove jcenter()
2021-05-16 17:08:48 +02:00
fb1d305545
Update detekt to 1.17.0
2021-05-15 14:50:04 +02:00
8fbefe7066
Koin has renamed their id
2021-05-15 14:50:04 +02:00
b136235ccf
Try to remove jcenter()
2021-05-15 14:50:04 +02:00
74ce93f37b
Merge pull request #490 from ultrasonic/dependabot/gradle/junit-junit-4.13.2
...
Bump junit from 4.12 to 4.13.2
2021-05-12 15:15:46 +02:00
8fd66b2a1c
Bump junit from 4.12 to 4.13.2
...
Bumps [junit](https://github.com/junit-team/junit4 ) from 4.12 to 4.13.2.
- [Release notes](https://github.com/junit-team/junit4/releases )
- [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md )
- [Commits](https://github.com/junit-team/junit4/compare/r4.12...r4.13.2 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-12 11:36:22 +00:00
642c90974c
Merge pull request #487 from ultrasonic/dependabot/gradle/com.android.support.test-runner-1.0.2
...
Bump runner from 1.0.1 to 1.0.2
2021-05-12 13:35:35 +02:00
tzugen
tzugen
dependabot[bot]
Nite