29a98c1263
The AGP build cache was removed in AGP 4.1. Previously introduced in AGP 2.3 to complement the Gradle build cache, the AGP build cache was superseded entirely by the Gradle build cache in AGP 4.1. This change does not impact build time.
2021-05-20 18:16:55 +02:00
78e4a00476
Our target sdk is 29
2021-05-20 18:16:55 +02:00
387119a90c
Make the CI fail if any new lint issues (warnings or errors) are added.
2021-05-20 18:16:55 +02:00
d26f8595ab
Manually disable IconMissingDensityFolder
2021-05-20 18:16:55 +02:00
dff054847a
Regenerate lint baseline
...
Removes 238 fixed issues
Adds 177 previously unlisted issues
2021-05-20 18:16:55 +02:00
10edce9f56
Disable daemon
2021-05-20 18:16:55 +02:00
3a05f30907
Fix more warnings
2021-05-20 18:16:55 +02:00
b559f6420e
Move certain ignores from the baseline to the specified files. This makes refactoring much less fragile.
2021-05-20 18:16:55 +02:00
689b704bc5
Enable parallel AST generation
2021-05-20 18:16:55 +02:00
a25a2ff337
Go back to default detekt checks.
...
Type resolution (which I had enabled some weeks ago) is really not stable enough for production and also takes much longer time to compile.
2021-05-20 18:16:55 +02:00
8b01118233
Remove local copy of com.mobeta.android.dslv in favour of importing it from maven
2021-05-20 18:16:42 +02:00
950cb6254f
Merge pull request #493 from tzugen/generic-views
...
Introduce new Generic Fragments, ViewModels, and Adapters for the display of API data.
2021-05-18 11:44:51 +02:00
5f08e7e7cd
Create a new SelectMusicFolderViewHolder instance when the Adapter is recreated,
...
instead of reusing an old one. This lead to a crash.
Also make the AlbumList use the correct placeholder,
remove an unused resource file, and update the placeholder to look less clumsy.
2021-05-18 08:50:04 +02:00
2cf80707f7
Correctly display the folder header also in album view
...
Also fix a number of smaller issues
2021-05-16 21:06:04 +02:00
72c03cc500
Introduce new Generic Fragments, ViewModels, and Adapters for the display of API data.
...
* Splits former SelectAlbumFragment into separate fragments for Albums and general collections of tracks
* Renames and refactors SelectArtist view to extend the new Generic classes
* Adds error handling (Fixes #484 )
* Adds EndlessScrolling capabilities to all Album Lists
* Uses RecyclerViews and LiveData for performance and in-memory caching
* Refreshes the UI to be aligned with the ArtistList UI
* Add a new GenericEntry to the domain data classes, and make other types extend it
2021-05-16 17:42:31 +02:00
c6a744cc14
Rename classes in preparation of split.
2021-05-16 17:42:31 +02:00
1fc7a954e9
Regenerate baseline files
2021-05-16 17:42:31 +02:00
13b00f75f0
Use default values for LongMethod, LongParameterList, LargeClass and ComplexMethod.
...
The algrorithms in detekt had changed when I updated detekt to v1.16, but our values not,
resulting in a very long baseline file with many non-sensical warnings.
By removing our config we follow the detekt config when they modify their algorithms again.
2021-05-16 17:42:31 +02:00
1599c96085
Merge pull request #476 from tzugen/j-center
...
Try to remove jcenter()
2021-05-16 17:08:48 +02:00
fb1d305545
Update detekt to 1.17.0
2021-05-15 14:50:04 +02:00
8fbefe7066
Koin has renamed their id
2021-05-15 14:50:04 +02:00
b136235ccf
Try to remove jcenter()
2021-05-15 14:50:04 +02:00
74ce93f37b
Merge pull request #490 from ultrasonic/dependabot/gradle/junit-junit-4.13.2
...
Bump junit from 4.12 to 4.13.2
2021-05-12 15:15:46 +02:00
8fd66b2a1c
Bump junit from 4.12 to 4.13.2
...
Bumps [junit](https://github.com/junit-team/junit4 ) from 4.12 to 4.13.2.
- [Release notes](https://github.com/junit-team/junit4/releases )
- [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md )
- [Commits](https://github.com/junit-team/junit4/compare/r4.12...r4.13.2 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-12 11:36:22 +00:00
642c90974c
Merge pull request #487 from ultrasonic/dependabot/gradle/com.android.support.test-runner-1.0.2
...
Bump runner from 1.0.1 to 1.0.2
2021-05-12 13:35:35 +02:00
a5ad39caba
Removing unused testing dependencies
2021-05-12 12:58:48 +02:00
403fead776
Merge pull request #492 from ultrasonic/dependabot/gradle/androidx.core-core-ktx-1.5.0-rc02
...
Bump core-ktx from 1.5.0-rc01 to 1.5.0-rc02
2021-05-12 11:35:16 +02:00
7a012d3bce
Bump core-ktx from 1.5.0-rc01 to 1.5.0-rc02
...
Bumps core-ktx from 1.5.0-rc01 to 1.5.0-rc02.
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-12 09:13:31 +00:00
426249f370
Merge pull request #491 from tzugen/weekly
...
Run dependabot only weekly!
2021-05-12 11:13:06 +02:00
1df6181cc3
Merge branch 'develop' into weekly
2021-05-12 10:38:32 +02:00
f897a1b459
Merge pull request #486 from ultrasonic/dependabot/gradle/commons-codec-commons-codec-1.15
...
Bump commons-codec from 1.10 to 1.15
2021-05-12 10:19:33 +02:00
b78dadc170
Run dependabot only weekly!
2021-05-12 10:07:43 +02:00
330dade288
Bump commons-codec from 1.10 to 1.15
...
Bumps [commons-codec](https://github.com/apache/commons-codec ) from 1.10 to 1.15.
- [Release notes](https://github.com/apache/commons-codec/releases )
- [Changelog](https://github.com/apache/commons-codec/blob/master/RELEASE-NOTES.txt )
- [Commits](https://github.com/apache/commons-codec/compare/1.10...rel/commons-codec-1.15 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-12 06:26:57 +00:00
14941486a5
Merge pull request #485 from tzugen/context-free-2
...
Removing remaining context from MusicService signatures.
2021-05-11 15:32:18 +02:00
a60be2157b
Removing remaining context from MusicService signatures.
2021-05-11 14:26:29 +02:00
aed5d9b629
Merge pull request #480 from ultrasonic/dependabot/gradle/com.google.android.material-material-1.3.0
...
Bump material from 1.2.1 to 1.3.0
2021-05-11 14:09:32 +02:00
c7904fad84
Merge branch 'develop' into dependabot/gradle/com.google.android.material-material-1.3.0
2021-05-11 13:41:34 +02:00
de44d28257
Merge pull request #482 from ultrasonic/dependabot/gradle/androidx.media-media-1.3.1
...
Bump media from 1.3.0 to 1.3.1
2021-05-11 13:13:06 +02:00
4617a210fa
Bump media from 1.3.0 to 1.3.1
...
Bumps media from 1.3.0 to 1.3.1.
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-11 11:00:16 +00:00
cb5cdbe878
Bump material from 1.2.1 to 1.3.0
...
Bumps [material](https://github.com/material-components/material-components-android ) from 1.2.1 to 1.3.0.
- [Release notes](https://github.com/material-components/material-components-android/releases )
- [Commits](https://github.com/material-components/material-components-android/compare/1.2.1...1.3.0 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-11 10:50:12 +00:00
09b5654f5a
Merge pull request #479 from ultrasonic/dependabot/gradle/androidx.constraintlayout-constraintlayout-2.0.4
...
Bump constraintlayout from 2.0.1 to 2.0.4
2021-05-11 12:48:42 +02:00
d399780d23
Bump constraintlayout from 2.0.1 to 2.0.4
...
Bumps constraintlayout from 2.0.1 to 2.0.4.
Signed-off-by: dependabot[bot] <support@github.com>
2021-05-11 10:38:46 +00:00
e9cc2880f2
Merge pull request #477 from tzugen/context-free
...
Make all preference operations context-free
2021-05-11 12:34:51 +02:00
c66118172c
Revert accidental changes in the method signature.
2021-05-11 12:04:29 +02:00
5b6fa20050
This was literally the result of removing one(!) dependency on context inside FileUtil
...
17 Classes with x function which don't need to pass around context anymore..
2021-05-11 12:04:29 +02:00
f2b1ba0e94
Remove unused context references in MusicServiceFactory
2021-05-11 12:04:29 +02:00
1fa9e604b5
Remove a large number of baselined detekt issues :)
2021-05-11 12:04:29 +02:00
76ba4c8ac9
Remove more context dependencies
2021-05-11 12:04:29 +02:00
2c5f8d9dd0
Now we can stop passing around the context for a lot of API calls
2021-05-11 12:04:29 +02:00
9ec92c6cf3
Make all preference operations context-free
...
(use the application context for them)
2021-05-11 12:04:26 +02:00
tzugen
Nite
tzugen
dependabot[bot]
Óscar García Amor