e273d64be3
Player: Always stop after 100 errors
...
Fixes #1199
2023-08-01 16:59:43 +02:00
2a90256d32
GstEnginePipeline: Disable volume sync on Windows
...
Fixes #1220
2023-08-01 16:39:57 +02:00
560712db21
ebur128analysis: Check for valid channel-mask
2023-07-30 03:18:48 +02:00
483b42d2b8
GstStartup: Use directsoundsink as primary sink
2023-07-29 22:54:49 +02:00
d1a6e53f5c
TagReaderTagLib: Read FMPS_Playcount
...
Fixes #1248
2023-07-29 18:33:50 +02:00
f5a55abf58
Mpris2: Add new property to read/write the rating
2023-07-27 11:24:19 +02:00
0bc94b90d7
SmartPlaylistSearchTerm: Handle unrated (-1) as zero
...
Fixes #1244
2023-07-26 01:45:28 +02:00
9ed4bd9366
Update translations
2023-07-24 09:46:20 +02:00
d3352e476f
Remove `< 0` check on unsigned
2023-07-21 07:17:58 +02:00
4b4c5fc0ab
Use const reference for `AlbumCoverLoaderOptions::Types`
2023-07-21 07:17:26 +02:00
38b9c7c38a
MusixmatchCoverProvider: Add const
2023-07-21 07:16:32 +02:00
c71ce41c83
LastFMImport: Move variable declaration
2023-07-21 07:16:23 +02:00
4cd030215d
Transcoder: Remove useless empty check
2023-07-21 07:16:08 +02:00
2ce5d6f727
Database: Add missing const
2023-07-21 07:15:55 +02:00
b55a0df8e1
CollectionView: Remove useless variable
2023-07-21 07:15:42 +02:00
ee5fa23a7a
LocalRedirectServer: Remove unused https variable
2023-07-21 07:15:08 +02:00
75ab6f25f4
Check return of QSqlQuery::prepare
2023-07-21 07:12:20 +02:00
eaed82c9b2
CollectionItemDelegate: Remove check for nullptr, already done
2023-07-21 07:11:21 +02:00
2a4be6fcd7
BoomAnalyzer: Move variable declaration
2023-07-21 07:10:31 +02:00
e6198500f7
BlockAnalyzer: Remove useless continue
2023-07-21 07:10:17 +02:00
7db36c83c1
MainWindow: Don't use our network manager for Qt Sparkle
2023-07-21 06:20:46 +02:00
0e1921698c
TidalUrlHandler: service is already a pointer
2023-07-21 06:11:16 +02:00
95eed1ecec
Fix QtConcurrent::run build with Qt 5
2023-07-21 06:10:44 +02:00
2e61235403
Application: Use shared pointers
...
Fixes #1239
2023-07-21 05:55:24 +02:00
d6b53f78ab
Cleanup includes
2023-07-21 05:25:57 +02:00
a2c7ff63df
Formatting
2023-07-21 05:11:27 +02:00
9fb15545bd
GstEnginePipeline: Perform EBU R 128 Loudness Normalization in floating-point
2023-07-19 03:07:22 +02:00
277e08b94a
README: Add libebur128 to optional dependencies
2023-07-19 02:40:31 +02:00
46224fe9b8
nsi: Add gst-play-1.0.exe
2023-07-18 21:28:39 +02:00
56180ca419
LocalRedirectServer: Remove https option and gnutls dependency
2023-07-18 19:44:45 +02:00
dc65753a0b
ebur128analysis: Remove extra semicolon
2023-07-16 23:26:17 +02:00
d8857d8e72
Add missing QMetaType include
2023-07-12 18:13:02 +02:00
fdc3e0a5f5
LyricsSearchResult: Add missing QList include
2023-07-12 18:12:48 +02:00
8f7180eb6c
Song: Pass double by value
2023-07-12 18:12:08 +02:00
8945602eae
Song: Add missing newlines between functions
2023-07-12 18:11:43 +02:00
7826f77425
Formatting
2023-07-12 16:27:59 +02:00
00372e85c5
FilterParser: Silence double / float warning
2023-07-12 16:27:28 +02:00
a1ffc5c33b
ebur128analysis: Rename dsc variable
2023-07-12 16:26:39 +02:00
8a44a41abb
ebur128analysis: Initialize variables to silence warnings
2023-07-12 16:26:17 +02:00
23f0c56eba
Song: Move ebur128 functions
2023-07-12 16:23:27 +02:00
3d25863ccb
CollectionWatcher: Make PerformEBUR128Analysis const
2023-07-12 16:22:17 +02:00
bb6daca735
GME: Add static_cast to silence warnings
2023-07-12 16:22:02 +02:00
4bd993b1e3
GstEngine/GstEnginePipeline: support gap-less playback w/ loudness-normalizing gain
...
Ok, it does appear that it is that simple.
In principle this (even the non-update case) results in volume jumps,
so maybe we'll want gradual gain change...
Notably, i thought we'd always seek if the pipeline
was already operating on the same URL as the new one,
but apparently only for adjacent songs?
2023-07-12 14:34:04 +02:00
f81816b0cd
EBUR128Analysis: handle channel map
...
Loudness measurement is channel-dependent.
This perhaps matters most for mono audio.
2023-07-12 14:34:04 +02:00
7ac605c038
EBU R 128: update ChangeLog/README
2023-07-12 14:34:04 +02:00
2a8b67d11e
Handle `libebur` to windows installers
2023-07-12 14:34:04 +02:00
16893cca24
CI: install libebur128 package
2023-07-12 14:34:04 +02:00
94ab788032
GstEnginePipeline: actually perform (EBU R 128) loudness normalization
...
The magic: if EBU R 128 loudness normalization is enabled,
just insert `volume` GST element into the pipeline
(where ReplayGain would be inserted) and configure it.
We currently don't support changing said gain after the pipeline
was created. We might need to, though, for a number of reasons.
2023-07-12 14:34:04 +02:00
e3a333564a
`GstEngine::Load()`: different loudness-normalizing gain means new pipeline
...
This is a bit of a gotcha, there should be a point (where we seek?)
where we'd be able to change said gain, but for now this is a simple[r]
stop-gap fix.
2023-07-12 14:34:04 +02:00
13d6cf201f
Engine: pipe-in the EBU R 128 loudness normalization gain stuff
...
The idea is that Integrated Loudness is an integral part
of the song, much like knowing it's beginning / ending
in the file, and we must handle it the exact same way,
and pipe it through all the way.
At the same time, `EngineBase` knows Target Level (from settings),
and these two combined tell us the Gain needed to normalize the
Loudness of the particular Song (`EngineBase::Load()` does that).
So the actual backend only needs to handle the Volume.
We don't currently support changing Target Level on the fly.
We don't currently support changing Loudness-normalizing Gain on the fly.
This does not handle the case when the song is loaded from URL
and thus the EBU R 128 measures, that exist, are not nessesairly correct.
2023-07-12 14:34:04 +02:00
Jonas Kvinge
Dakes
Strawbs Bot
Roman Lebedev