98682a2da9
Use C++17 fallthrough
2022-07-26 20:37:06 +02:00
3ffcc29249
Add back save all playlists action
2022-07-20 01:09:00 +02:00
21f1fe52c0
Remove save all playlists action
...
It's hard-coded to m3u, needs a new select directory dialog with option to select different playlist formats.
Fixes #987
2022-07-18 22:56:32 +02:00
5e819cf04b
Remove defining _WIN32_WINNT
2022-07-17 01:16:10 +02:00
fd9ab43681
Windows7ThumbBar: Create taskbar list once
2022-07-17 00:13:37 +02:00
658c116eac
Utilities: Remove unnecessary constData() in Sha1CoverHash
2022-07-10 19:14:05 +02:00
6afbc71b4a
Remove old schemas
2022-07-10 18:57:00 +02:00
71263863ad
Allow invalid ctime/mtime
...
Possible fix for #815 and #947
2022-07-10 03:24:02 +02:00
f41a3b9bb2
CommandlineOptions: Change quint64 to quint32 to match operator>>
...
Fixes #986
2022-06-24 17:18:54 +02:00
bfd9e76f40
Remove capture of ‘this’ via ‘[=]’
2022-06-20 23:52:18 +02:00
d82fd421ed
Replace use of C-style casts
2022-06-13 00:23:42 +02:00
f4e5b83039
Replace use of C-style casts
2022-06-10 02:30:39 +02:00
1ea70b085f
Context: Remove albums
2022-06-05 11:58:53 +02:00
6c0b395f4a
Add option for overwriting playcounts
...
Fixes #962
2022-06-05 04:59:50 +02:00
788747c071
MainWindow: Remove unnecessary hide()
2022-05-21 19:12:53 +02:00
36eb131289
MainWindow: Remove QEvent::spontaneous() check in close event
...
Fixes #964
2022-05-21 19:12:53 +02:00
4a3a379871
Increase icons to include 128x128 and set global application icon
...
Fixes #954
2022-05-19 22:02:35 +02:00
18a2692dc1
PlaylistParser: Refactor code and exclude CUE from save playlist filters
...
Fixes #953
2022-05-13 23:14:56 +02:00
a2dad982f8
Move sqlrow to core
2022-05-13 18:15:04 +02:00
907dfee6f7
Utilities: Use inconv with MSVC
2022-04-15 17:44:04 +02:00
e05e9ea1b2
timeconstants: Use constexpr
2022-04-08 17:35:44 +02:00
962b52bd5b
Add save all playlists action
2022-03-26 22:38:21 +01:00
8690be7fd2
Use separate sparkle feed for mingw and msvc
2022-03-25 21:38:37 +01:00
a6c05df362
Formatting
2022-03-22 21:19:59 +01:00
f6b70fda71
Formatting
2022-03-22 21:09:05 +01:00
5ccfc97dab
Database: Fix schema update with Windows line-endings
2022-03-17 00:04:12 +01:00
61e9b80f67
Song: Remove playlists from accepted file extensions
...
Fixes #909
2022-03-01 21:26:08 +01:00
c9caa7f034
Mpris2: Fix incorrect rounding when setting volume
...
Fixes #894
2022-02-11 20:26:41 +01:00
848e41919d
SongLoader: Use g_free
2022-02-06 18:46:59 +01:00
a1735278df
Add 3rdparty getopt for MSVC
2022-02-06 17:29:07 +01:00
53d5192477
Allow deleting CUE songs
2022-02-05 15:56:18 +01:00
288408795b
Disable open audio CD menu when compiled without audio CD support
2022-02-04 19:45:30 +01:00
3acbe431f7
Replace non-translated characters with underscore
2022-02-04 19:07:15 +01:00
e31c9d74fa
Add advanced settings for configuring collection watcher
2022-01-30 04:24:33 +01:00
63e5d6a94a
Require Qt 5.9
2022-01-29 21:33:33 +01:00
fd5970b647
Player: Don't set volume lower than 0 or higher than 100.
...
Fixes #884
2022-01-29 20:32:33 +01:00
4c479301ff
Register MtpConnection as metatype
...
Fixes:
```
00:13:02.210 WARN unknown QObject::connect: Cannot queue arguments of type 'MtpConnection*'
00:13:02.210 WARN unknown (Make sure 'MtpConnection*' is registered using qRegisterMetaType().)
```
2022-01-29 00:17:37 +01:00
fbd2993239
Remove use of sparkle
2022-01-15 02:24:48 +01:00
c7444a189e
Replace SUUpdater with SPUStandardUpdaterController
2022-01-15 00:04:21 +01:00
29235c5fa6
Update stylesheet to use property name for popupMode on QToolButton
2022-01-14 23:25:36 +01:00
1d4775a94b
Simplify stylesheet on QToolButton
2022-01-08 13:18:54 +01:00
4cde9a7e9e
Fix padding on toolbuttons with menu button popup
...
Fixes #795
2022-01-08 13:10:48 +01:00
15be227920
TagReader: Various fixes to embedded cover handling
...
- Add support for saving embedded for Opus
- Fix deleting cover for Ogg Vorbis, Opus and Speex
- Don't load empty covers
2022-01-06 00:06:20 +01:00
ce3af4961b
GeniusLyricsProvider: Fix parsing of different HTML pages
2021-12-19 20:59:38 +01:00
8f49d1591f
Support more CUE filenames
...
Fixes #835
2021-11-27 20:28:00 +01:00
d5dac9c6cc
Add musicbrainz icon
2021-11-09 20:07:48 +01:00
5715f4c2cb
Remove use of macros in Song and TagReader
2021-11-09 19:34:43 +01:00
350debb66c
Utilities: Add static_cast in Hmac()
2021-11-09 19:34:43 +01:00
bc1c0c3c6d
SqlQuery: Add more BindValue methods
2021-11-09 19:34:43 +01:00
2151d96303
Use PlaylistItemList
2021-11-09 19:34:43 +01:00
ca10920bb5
Add option for overwriting database rating
2021-10-31 23:24:32 +01:00
642a455a9c
Add icon mappings for download and scrobble
...
Adds mappings for download (Cover Manager) and scrobble (Import data from last.fm):
2021-10-31 02:23:15 +01:00
20c2225d8f
Add icon names for missing Tools menu entries
...
I noticed the abort_collection_scan and console menu entries were missing matching icons. This change adds appropriate icons for each action.
2021-10-31 00:37:57 +02:00
5e7759b697
Utilities: Change return type for `GetThreadId` and `SetThreadIOPriority` to `long`
2021-10-31 00:26:02 +02:00
1223469be9
Song: Add playcount and rating to `Song::IsMetadataEqual()`
2021-10-30 19:06:46 +02:00
5eae3ddd8a
Use `float` for rating
2021-10-30 18:53:14 +02:00
a461c97bcf
IconLoader: Log when icon fails to load
2021-10-30 03:34:52 +02:00
8b8e427a2b
DeleteFiles: Fix compile with older Qt versions
2021-10-30 03:13:55 +02:00
79ac53b2d9
Fix narrowing conversions
2021-10-30 02:21:29 +02:00
ebadb4db0a
Use `const_iterator`
2021-10-30 01:57:12 +02:00
9a480eb710
SqlQuery: Make `QSqlDatabase` parameter const reference
2021-10-30 01:33:16 +02:00
e75c955a68
mac_startup: Remove unused functions
2021-10-30 00:48:58 +02:00
7a57586f90
Map edit-clear-list system icons
...
Use system edit-clear-list icons when enabled instead of defaulting to edit-clear-locationbar-ltr.png
2021-10-29 17:52:43 +02:00
30269d9d95
Organize: Remove unused "mark as listened" option
2021-10-24 23:19:01 +02:00
3ab86543ad
Add support for saving playcounts and ratings to tags
2021-10-24 16:08:17 +02:00
ec17dc9830
TagReaderClient: Sort functions
2021-10-18 23:15:50 +02:00
bd4eec4527
Song: Only merge user set playcount and rating if set
...
Fixes #790
2021-10-18 00:39:26 +02:00
ee915254e7
Song: Sort code in Song::ToProtobuf()
2021-10-17 00:34:33 +02:00
d835d4aae6
Add rating to Song::InitFromProtobuf and Song::ToProtobuf
2021-10-17 00:27:31 +02:00
c946c1d1c4
Player: Don't preload next song while playing module music
...
Workaround bug in GStreamer
Fixes #787
Fixes #772
2021-10-12 22:59:23 +02:00
bb5fe5a6d1
Add Song::is_module_music()
2021-10-12 22:58:39 +02:00
814d2fa9fc
MainWindow: Use Song::PrettyTitle() in debug message
2021-10-12 22:57:59 +02:00
a6569d09ac
Read XM and IT module music
2021-10-12 21:43:46 +02:00
b38ad81928
Remove use of C-style casts
2021-10-12 18:50:17 +02:00
2b445fb563
StyleSheetLoader: Cleanup code and add workaround for macOS dark theme
...
Fixes #778
2021-09-28 17:25:22 +02:00
8d2615547d
Add keyboard shortcut for focusing search fields
...
Fixes #779
2021-09-27 21:42:30 +02:00
3292db8b77
Add missing override
2021-09-27 21:41:45 +02:00
8c6ad52437
Organize: Update collection directory ID and song path immediately
...
Fixes #781
2021-09-27 19:30:31 +02:00
62e53b53f0
Replace assert with Q_ASSERT
2021-09-27 19:30:31 +02:00
9b4a33a612
MPris2: Remove static
2021-09-26 20:14:11 +02:00
918b7c1e03
Move chrono include
2021-09-26 20:06:04 +02:00
acba68dab9
MergedProxyModel: Add FIXME
2021-09-26 18:34:44 +02:00
92f6a0c6c8
Add mod and s3m to filetypes
2021-09-26 16:23:02 +02:00
09a9330f3e
Show error when reading or saving album covers
2021-09-19 19:31:34 +02:00
d2d7f32c45
Add new method for updating songs based on song ID
...
Show status updating database.
Fixes #750
2021-09-19 15:43:36 +02:00
d5b0794b00
Remove unneeded `this`
2021-09-13 20:49:33 +02:00
0637b65846
Fix a few narrowing conversions ( #761 )
...
* Fix narrowing conversion in album cover loader
* Fix narrowing conversions in discogs cover provider
* Fix narrowing conversions in spotify cover provider
* Add explicit conversion in moodbarbuilder
* Fix narrowing conversions in osd dbus
* Make WordyTimeNanosec use unsigned quint64
* Fix narrowing conversions in song
* Fix narrowing conversions in qobuz stream url request
* Make ConnectionInfo.msgLen use unsigned quint64
* Make AnalizerBase.timeout to signed int
* Fix narrowing conversions in album cover fetcher
* Make fht type be unsigned int
* Correct for type in blockanalizer and use std::fill where possible
* Revert "Fix narrowing conversions in song"
This reverts commit 3de291394d
2021-09-12 21:24:22 +02:00
68c44daef2
Fix SingleApplication static functions called from instance
2021-09-10 18:44:36 +02:00
24a3ac9811
Use static QMetaObject::invokeMethod
2021-09-09 21:53:14 +02:00
d35d3aabc3
Show error dialog for failed SQL queries
2021-09-09 21:45:46 +02:00
ed08818b6f
Use multi-arg
2021-08-25 02:57:57 +02:00
71adfc0a74
Use std::chrono_literals
2021-08-25 02:57:09 +02:00
d02241d32c
Fix compile with MSVC
2021-08-24 21:49:06 +02:00
ea2bfbda44
Formatting
2021-08-23 21:21:08 +02:00
e2d8149dcf
Formatting
2021-08-19 19:17:43 +02:00
5f156d6bab
Only read local files in SongLoader::EffectiveSongLoad
2021-08-19 19:17:43 +02:00
cecb9293f6
Add QRegularExpression::CaseInsensitiveOption
2021-08-13 23:33:41 +02:00
e6858719c9
Reduce network access managers
2021-08-12 23:00:42 +02:00
f1d3cadb3b
Add better logging for file open and write errors
2021-08-09 23:32:26 +02:00
553e8baa8b
Fix async song load
...
Fixes #739
2021-07-28 22:25:33 +02:00
62a5031ccf
Delay pause on resume playback
2021-07-23 21:54:46 +02:00
4abac65316
Properly disconnect PlaylistManager::AllPlaylistsLoaded on resume
2021-07-23 21:54:21 +02:00
c6e42e1032
Reset play offset when switching song while paused
...
Fixes #735
2021-07-23 21:32:12 +02:00
a353631892
Code tidy
2021-07-23 21:30:08 +02:00
16625b1dc7
Move some files from ext to src
2021-07-21 17:29:16 +02:00
2eab763d74
Check that QIODevice::open() is successful, and explicitly call close()
2021-07-14 20:52:57 +02:00
fab1d94d34
Delay resume playback on startup to make sure Tidal login is refreshed
2021-07-14 13:02:54 +02:00
d9e378211a
Fix sorting of radios
2021-07-14 11:22:24 +02:00
68dbc29f2c
Use QString::compare with Qt::CaseInsensitive to reduce allocations
2021-07-13 23:18:12 +02:00
4251bee3ca
Change some uses of QMap to QHash
2021-07-12 08:28:52 +02:00
e48b7d83a3
Formatting
2021-07-11 09:49:38 +02:00
a6742d401c
Formatting
2021-07-11 07:40:57 +02:00
134dc55891
Rename RadioView::SetModel
2021-07-11 05:53:10 +02:00
b053f99690
Add Song::is_radio()
2021-07-11 05:18:39 +02:00
5700c3f72e
Change GStreamer text
2021-07-11 05:17:45 +02:00
cdb3729a88
Use Song::SourceFromURL in SongLoader::AddAsRawStream
2021-07-11 05:17:17 +02:00
c33f2a1d27
Unref bus in SongLoader::LoadRemote()
2021-07-11 04:58:37 +02:00
09bbf1f4d7
Add radios
2021-07-11 01:08:06 +02:00
4cb3f9d177
Close files in song loader
2021-07-11 00:45:30 +02:00
432b0f3e54
songloader: Make sure timeout timer is started from correct thread
2021-07-10 21:48:31 +02:00
2bee41e90e
Fix compile of Utilities::Hmac with Qt 6.3
2021-07-07 23:54:21 +02:00
88819611f4
Remove TagLib dependency from Song class
2021-07-02 01:16:46 +02:00
b9f3f80d50
Use std::make_unique / std::make_shared
2021-07-01 02:02:02 +02:00
0e8ae1a206
Change to std::shared_ptr
2021-07-01 02:02:02 +02:00
57a36491ee
Remove mpris.cpp and mpris.h
2021-06-30 16:26:07 +02:00
f3a8dde5f0
Use std::make_shared
2021-06-30 16:15:55 +02:00
aa859b9002
Remove dead code
2021-06-28 00:21:50 +02:00
a2e7173983
Rename filter to filter_widget
2021-06-28 00:21:50 +02:00
8287efd51f
Remove silencing -Wclazy-qt6-deprecated-api-fixes to workaround clazy bugs
2021-06-25 18:19:37 +02:00
215057ce6f
Remove unneeded get()
2021-06-22 14:04:42 +02:00
6d8b0b3ab6
Simplify return
2021-06-22 14:04:42 +02:00
e5c85ddd32
Pass task ID to SetTaskBlocksCollectionScans
2021-06-22 14:04:42 +02:00
6bf3c34fe5
Fix parameter name mismatch
2021-06-22 14:04:42 +02:00
584f5e5935
Change bool/int condition
2021-06-22 14:04:42 +02:00
8c2b907ff5
Make static
2021-06-22 14:04:42 +02:00
c61d1ce6b4
Use std::any_of
2021-06-21 19:52:37 +02:00
e85c13b3fe
Change switch to if statement
2021-06-21 15:44:13 +02:00
ed09627fdb
Use std::make_unique
2021-06-21 15:40:44 +02:00
589bdf5dcd
Use default
2021-06-21 15:40:44 +02:00
50be44adf8
Add namespace comments
2021-06-20 23:55:02 +02:00
e1bf4347ab
Fix uninitialized variables
2021-06-20 23:53:28 +02:00
3a3305c020
Uppercase literal suffix
2021-06-20 23:49:04 +02:00
1295033fae
Clang-Tidy and Clazy fixes
2021-06-20 19:04:08 +02:00
755abec636
Use QProcess::startCommand with Qt 6
2021-06-20 02:48:58 +02:00
bee30e572f
Fix incorrect use of return
2021-06-20 02:25:36 +02:00
081df59ed7
Only call QSystemTrayIcon::isSystemTrayAvailable once
...
Workaround file descriptor leak
Fixes #724
2021-06-15 00:25:54 +02:00
e56defdc50
Formatting
2021-06-13 20:55:37 +02:00
f786a17014
Formatting
2021-06-12 20:53:23 +02:00
8fd32aba4f
Improve resume playback on startup, re-request stream URL when unpausing
...
Fixes #270
2021-06-10 23:14:05 +02:00
f8ed2afef1
Add song fingerprinting and tracking
...
Fixes #296
2021-06-05 21:56:40 +02:00
a4a20ec220
Make sure schedule playlist save timer is started from correct thread
2021-06-05 00:07:15 +02:00
0c5236ebcb
Fix crash when no system tray is available
2021-05-29 18:52:47 +02:00
67f831beba
Refactor systemtrayicon code
2021-05-20 21:40:08 +02:00
efcd35d4a1
Remove use of X11Extras and WinExtras
...
Modules are deprecated in Qt 6
See: QTBUG-83251
2021-05-12 23:15:04 +02:00
639ea35921
Use wchar version of GetDiskFreeSpaceEx on Windows Qt 5
2021-05-11 20:32:28 +02:00
4a0a1a32a4
Rename ENABLE_CHROMAPRINT to ENABLE_MUSICBRAINZ
2021-05-10 21:17:50 +02:00
2625d72818
Don't strip off "Live" from song title
2021-05-01 18:03:26 +02:00
88562890ae
Use int in MainWindow::UpdateTrackSliderPosition
2021-04-26 23:36:59 +02:00
86c267eb89
Seconds is already qint64
2021-04-26 23:13:37 +02:00
8c64d3b55c
Do most item reloading in the background, schedule playlist saving
2021-04-26 22:57:08 +02:00
9b60559855
Use QFile::encodeName() in Song::InitFromFilePartial
...
Fixes #693
2021-04-21 20:11:37 +02:00
83ad7d4935
Set exit before quit is called
2021-04-16 18:34:38 +02:00
ae2ca175d3
Fix remembering hidden state
...
Prevent SetHiddenInTray() or Exit() from being called again after
qApp->quit() in MainWindow::closeEvent()
2021-04-16 18:27:24 +02:00
4c0f7c3dd4
Add commandline option to resize window
2021-04-14 19:50:38 +02:00
efaf917939
Add pragma unused
2021-04-11 19:16:07 +02:00
7d3ceb7d8c
Fix Tidal authentication on macOS
2021-04-11 18:33:35 +02:00
e13c27d32c
Allow editing of playlist metadata for streams
2021-04-11 02:01:53 +02:00
c7bc9d471a
Allow keep running option on macOS too
2021-04-10 08:22:08 +02:00
5a58ac2845
Make CollectionQuery subclass QSqlQuery, don't copy QSqlQuery
2021-04-10 03:21:05 +02:00
b5cea4c27e
Make enabling FTS3 non-fatal
2021-04-08 22:33:43 +02:00
b7de5d6df3
Only enable FTS3 when schema needs upgrading
2021-04-08 22:13:21 +02:00
bddb371e31
Fix open in file browser when inode/directory mimetype is set to thunar
...
Fixes #677
2021-04-01 18:31:19 +02:00
a87f0e0475
Also strip variables with uppercase letters in OpenInFileManager()
2021-03-31 23:14:16 +02:00
f63e05b7d4
Use QString::SkipEmptyParts for older Qt versions
2021-03-29 22:45:01 +02:00
84b7fa02bb
Strip all variables from command in OpenInFileManager
...
Fixes #674
2021-03-29 22:37:55 +02:00
c6604734c9
Remove using std::placeholders
2021-03-26 23:33:56 +01:00
14fb647647
Fix uninitialized variables
2021-03-26 21:30:13 +01:00
29cbfe7c1a
Change last played to qint64
2021-03-25 23:23:13 +01:00
6b6117653a
Allow audio formats unsupported by taglib to be added
...
Fixes #669
2021-03-21 19:19:35 +01:00
59bffed47f
Use static_cast
2021-03-21 18:53:02 +01:00
78588d8cdf
Fix various clazy warnings
2021-03-21 04:47:11 +01:00
54f2aa5f77
Update copyrights
2021-03-20 21:14:47 +01:00
2695169514
Add type to metadata bundle to avoid updating previous song when it shouldn't
2021-03-13 03:14:30 +01:00
e2cd68e3e8
Fix saving existing cover from file embedded for multiple albums
2021-03-07 07:01:22 +01:00
89f1f8e6dc
Check for empty art automatic
2021-03-07 05:41:49 +01:00
04bbff338d
Fix deleting multiple covers in album cover manager
2021-03-07 03:43:49 +01:00
bbcd6a3261
Fix saving empty cleared cover
2021-03-07 03:42:11 +01:00
869f8cf380
Enable cover actions based on current cover
2021-03-07 02:34:17 +01:00
1ff6ba9480
Only enable album cover options for collection songs
2021-03-07 01:49:38 +01:00
5807bee23b
Load album cover controller settings when album cover manager is opened
2021-03-07 00:54:20 +01:00
32b94555c3
Remove 3rdparty taglib
2021-02-27 16:55:41 +01:00
133f094d72
Add support for saving embedded album covers
...
Fixes #286
2021-02-26 21:03:51 +01:00
193cf1c750
Rename protobuf namespace
...
Fixes #654
2021-02-20 17:06:55 +01:00
0ab214fd5d
Add methods to tagreader for saving embedded art
2021-02-16 22:50:35 +01:00
7fc5b70553
Remove const reference from signals
2021-02-10 18:32:10 +01:00
b3681002a7
Change int to qint64
2021-02-10 18:27:40 +01:00
03959a68d5
Formatting
2021-02-02 21:08:58 +01:00
98d5e27a8c
Remove use of NewClosure for playback resume
2021-01-30 21:52:17 +01:00
576956fa1d
Use QTimer::singleShot directly for database backup
2021-01-30 21:51:32 +01:00
60528525e0
Use QObject::connect() everywhere for consistency
2021-01-29 18:53:20 +01:00
Jonas Kvinge
Maxime Haselbauer
buckmelanoma
staticssleever668
Emmanuel
EmmanuelMess