Add fallthrough comments and remove -Wimplicit-fallthrough=0

Signed-off-by: Jonas Kvinge <jonas@jkvinge.net>

3rdparty/singleapplication/CMakeLists.txt

@@ -8,7 +8,7 @@ set(CMAKE_CXX_STANDARD 11)
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --std=c++11 -U__STRICT_ANSI__ -Wall -Woverloaded-virtual -Wno-sign-compare -fpermissive")
 
 if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra -Wimplicit-fallthrough=0 -Wpedantic")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra -Wpedantic")
 endif()
 
 if(CMAKE_VERSION VERSION_GREATER 3.0)

ext/gstmoodbar/CMakeLists.txt

@@ -5,7 +5,7 @@ set(CMAKE_CXX_STANDARD 11)
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --std=c++11 -U__STRICT_ANSI__ -Wall -Woverloaded-virtual -Wno-sign-compare -fpermissive")
 
 if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra -Wimplicit-fallthrough=0 -Wpedantic")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra -Wpedantic")
 endif()
 
 include_directories(${CMAKE_CURRENT_BINARY_DIR} ${CMAKE_CURRENT_SOURCE_DIR})

ext/libstrawberry-common/CMakeLists.txt

@@ -8,7 +8,7 @@ set(CMAKE_CXX_STANDARD 11)
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --std=c++11 -U__STRICT_ANSI__ -Wall -Woverloaded-virtual -Wno-sign-compare -fpermissive")
 
 if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra -Wimplicit-fallthrough=0 -Wpedantic")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra -Wpedantic")
 endif()
 
 set(SOURCES

ext/libstrawberry-tagreader/CMakeLists.txt

@@ -10,7 +10,7 @@ set(CMAKE_CXX_STANDARD 11)
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --std=c++11 -U__STRICT_ANSI__ -Wall -Woverloaded-virtual -Wno-sign-compare -fpermissive")
 
 if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra -Wimplicit-fallthrough=0 -Wpedantic")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra -Wpedantic")
 endif()
 
 set(MESSAGES

ext/strawberry-tagreader/CMakeLists.txt

@@ -12,7 +12,7 @@ set(CMAKE_CXX_STANDARD 11)
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --std=c++11 -U__STRICT_ANSI__ -Wall -Woverloaded-virtual -Wno-sign-compare -fpermissive")
 
 if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra -Wimplicit-fallthrough=0 -Wpedantic")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra -Wpedantic")
 endif()
 
 set(EXECUTABLE_OUTPUT_PATH ${CMAKE_BINARY_DIR})

src/CMakeLists.txt

@@ -19,7 +19,7 @@ set(CMAKE_CXX_STANDARD 11)
 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --std=c++11 -U__STRICT_ANSI__ -Wall -Woverloaded-virtual -Wno-sign-compare -fpermissive")
 
 if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra -Wimplicit-fallthrough=0 -Wpedantic")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra -Wpedantic")
 endif()
 
 option(BUILD_WERROR "Build with -Werror" OFF)

src/collection/collectionmodel.cpp

@@ -1239,10 +1239,17 @@ CollectionItem *CollectionModel::ItemFromSong(GroupBy type, bool signal, bool cr
       item->sort_text = SortTextForNumber(year) + " ";
       break;
     }
-    case GroupBy_Composer:  if (item->key.isNull()) item->key = s.composer();
+    case GroupBy_Composer:
-    case GroupBy_Performer: if (item->key.isNull()) item->key = s.performer();
+      if (item->key.isNull()) item->key = s.composer();
-    case GroupBy_Grouping:  if (item->key.isNull()) item->key = s.grouping();
+      // fallthrough
-    case GroupBy_Genre:     if (item->key.isNull()) item->key = s.genre();
+    case GroupBy_Performer:
+      if (item->key.isNull()) item->key = s.performer();
+      // fallthrough
+    case GroupBy_Grouping:
+      if (item->key.isNull()) item->key = s.grouping();
+      // fallthrough
+    case GroupBy_Genre:
+      if (item->key.isNull()) item->key = s.genre();
       item->display_text = TextOrUnknown(item->key);
       item->sort_text = SortTextForArtist(item->key);
       break;

src/context/contextview.cpp

@@ -514,6 +514,7 @@ bool ContextView::eventFilter(QObject *object, QEvent *event) {
     case QEvent::Paint:{
       handlePaintEvent(object, event);
     }
+    // fallthrough
     default:{
       return QObject::eventFilter(object, event);
     }

src/core/player.cpp

@@ -552,6 +552,7 @@ void Player::EngineStateChanged(Engine::State state) {
       break;
     case Engine::Error:
       emit Error();
+      // fallthrough
     case Engine::Empty:
     case Engine::Idle:
       emit Stopped();

src/scrobbler/scrobblingapi20.cpp

@@ -150,6 +150,7 @@ void ScrobblingAPI20::Authenticate(const bool https) {
       messagebox_error.setTextFormat(Qt::RichText);
       messagebox_error.exec();
     }
+    // fallthrough
   case QMessageBox::Save:
     QApplication::clipboard()->setText(url.toString());
     break;

src/tidal/tidalrequest.cpp

@@ -867,11 +867,12 @@ void TidalRequest::SongsFinishCheck(const qint64 artist_id, const qint64 album_i
           AddSongsRequest(offset_next);
           break;
         case QueryType_SearchSongs:
-          // If artist_id and album_id isn't zero it means that it's a songs search where we fetch all albums too. So pass through.
+          // If artist_id and album_id isn't zero it means that it's a songs search where we fetch all albums too. So fallthrough.
           if (artist_id == 0 && album_id == 0) {
             AddSongsSearchRequest(offset_next);
             break;
           }
+          // fallthrough
         case QueryType_Artists:
         case QueryType_SearchArtists:
         case QueryType_Albums: