clazy:exclude=range-loop-reference
This commit is contained in:
parent
e274e8070d
commit
978fb06349
|
@ -1025,7 +1025,7 @@ void Playlist::InsertItems(const PlaylistItemList &itemsIn, const int pos, const
|
||||||
// Exercise vetoes
|
// Exercise vetoes
|
||||||
SongList songs;
|
SongList songs;
|
||||||
songs.reserve(items.count());
|
songs.reserve(items.count());
|
||||||
for (PlaylistItemPtr item : items) { // clazy:exclude=range-loop
|
for (PlaylistItemPtr item : items) { // clazy:exclude=range-loop-reference
|
||||||
songs << item->Metadata();
|
songs << item->Metadata();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -2015,7 +2015,7 @@ SongList Playlist::GetAllSongs() const {
|
||||||
|
|
||||||
SongList ret;
|
SongList ret;
|
||||||
ret.reserve(items_.count());
|
ret.reserve(items_.count());
|
||||||
for (PlaylistItemPtr item : items_) { // clazy:exclude=range-loop
|
for (PlaylistItemPtr item : items_) { // clazy:exclude=range-loop-reference
|
||||||
ret << item->Metadata();
|
ret << item->Metadata();
|
||||||
}
|
}
|
||||||
return ret;
|
return ret;
|
||||||
|
@ -2027,7 +2027,7 @@ PlaylistItemList Playlist::GetAllItems() const { return items_; }
|
||||||
quint64 Playlist::GetTotalLength() const {
|
quint64 Playlist::GetTotalLength() const {
|
||||||
|
|
||||||
quint64 ret = 0;
|
quint64 ret = 0;
|
||||||
for (PlaylistItemPtr item : items_) { // clazy:exclude=range-loop
|
for (PlaylistItemPtr item : items_) { // clazy:exclude=range-loop-reference
|
||||||
quint64 length = item->Metadata().length_nanosec();
|
quint64 length = item->Metadata().length_nanosec();
|
||||||
if (length > 0) ret += length;
|
if (length > 0) ret += length;
|
||||||
}
|
}
|
||||||
|
|
|
@ -344,7 +344,7 @@ void PlaylistBackend::SavePlaylist(int playlist, const PlaylistItemList &items,
|
||||||
if (db_->CheckErrors(clear)) return;
|
if (db_->CheckErrors(clear)) return;
|
||||||
|
|
||||||
// Save the new ones
|
// Save the new ones
|
||||||
for (PlaylistItemPtr item : items) { // clazy:exclude=range-loop
|
for (PlaylistItemPtr item : items) { // clazy:exclude=range-loop-reference
|
||||||
insert.bindValue(":playlist", playlist);
|
insert.bindValue(":playlist", playlist);
|
||||||
item->BindToQuery(&insert);
|
item->BindToQuery(&insert);
|
||||||
|
|
||||||
|
|
|
@ -554,7 +554,7 @@ void ListenBrainzScrobbler::Submit() {
|
||||||
int i(0);
|
int i(0);
|
||||||
QList<quint64> list;
|
QList<quint64> list;
|
||||||
QList<ScrobblerCacheItemPtr> items = cache_->List();
|
QList<ScrobblerCacheItemPtr> items = cache_->List();
|
||||||
for (ScrobblerCacheItemPtr item : items) { // clazy:exclude=range-loop
|
for (ScrobblerCacheItemPtr item : items) { // clazy:exclude=range-loop-reference
|
||||||
if (item->sent_) continue;
|
if (item->sent_) continue;
|
||||||
item->sent_ = true;
|
item->sent_ = true;
|
||||||
++i;
|
++i;
|
||||||
|
|
|
@ -583,7 +583,7 @@ void ScrobblingAPI20::Submit() {
|
||||||
int i = 0;
|
int i = 0;
|
||||||
QList<quint64> list;
|
QList<quint64> list;
|
||||||
QList<ScrobblerCacheItemPtr> items = cache()->List();
|
QList<ScrobblerCacheItemPtr> items = cache()->List();
|
||||||
for (ScrobblerCacheItemPtr item : items) { // clazy:exclude=range-loop
|
for (ScrobblerCacheItemPtr item : items) { // clazy:exclude=range-loop-reference
|
||||||
if (item->sent_) continue;
|
if (item->sent_) continue;
|
||||||
item->sent_ = true;
|
item->sent_ = true;
|
||||||
if (!batch_) {
|
if (!batch_) {
|
||||||
|
|
|
@ -138,7 +138,7 @@ void SmartPlaylistsModel::Init() {
|
||||||
// Append the new ones
|
// Append the new ones
|
||||||
s.beginWriteArray(backend_->songs_table(), playlist_index + unwritten_defaults);
|
s.beginWriteArray(backend_->songs_table(), playlist_index + unwritten_defaults);
|
||||||
for (; version < default_smart_playlists_.count(); ++version) {
|
for (; version < default_smart_playlists_.count(); ++version) {
|
||||||
for (PlaylistGeneratorPtr gen : default_smart_playlists_[version]) { // clazy:exclude=range-loop
|
for (PlaylistGeneratorPtr gen : default_smart_playlists_[version]) { // clazy:exclude=range-loop-reference
|
||||||
SaveGenerator(&s, playlist_index++, gen);
|
SaveGenerator(&s, playlist_index++, gen);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue