From 978fb063499b23fcdd36fa6a5fb491614b9b63eb Mon Sep 17 00:00:00 2001 From: Jonas Kvinge Date: Wed, 25 Aug 2021 03:45:12 +0200 Subject: [PATCH] clazy:exclude=range-loop-reference --- src/playlist/playlist.cpp | 6 +++--- src/playlist/playlistbackend.cpp | 2 +- src/scrobbler/listenbrainzscrobbler.cpp | 2 +- src/scrobbler/scrobblingapi20.cpp | 2 +- src/smartplaylists/smartplaylistsmodel.cpp | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/playlist/playlist.cpp b/src/playlist/playlist.cpp index 14c555b8..22ce5b8b 100644 --- a/src/playlist/playlist.cpp +++ b/src/playlist/playlist.cpp @@ -1025,7 +1025,7 @@ void Playlist::InsertItems(const PlaylistItemList &itemsIn, const int pos, const // Exercise vetoes SongList songs; songs.reserve(items.count()); - for (PlaylistItemPtr item : items) { // clazy:exclude=range-loop + for (PlaylistItemPtr item : items) { // clazy:exclude=range-loop-reference songs << item->Metadata(); } @@ -2015,7 +2015,7 @@ SongList Playlist::GetAllSongs() const { SongList ret; ret.reserve(items_.count()); - for (PlaylistItemPtr item : items_) { // clazy:exclude=range-loop + for (PlaylistItemPtr item : items_) { // clazy:exclude=range-loop-reference ret << item->Metadata(); } return ret; @@ -2027,7 +2027,7 @@ PlaylistItemList Playlist::GetAllItems() const { return items_; } quint64 Playlist::GetTotalLength() const { quint64 ret = 0; - for (PlaylistItemPtr item : items_) { // clazy:exclude=range-loop + for (PlaylistItemPtr item : items_) { // clazy:exclude=range-loop-reference quint64 length = item->Metadata().length_nanosec(); if (length > 0) ret += length; } diff --git a/src/playlist/playlistbackend.cpp b/src/playlist/playlistbackend.cpp index 279b3411..47a25abe 100644 --- a/src/playlist/playlistbackend.cpp +++ b/src/playlist/playlistbackend.cpp @@ -344,7 +344,7 @@ void PlaylistBackend::SavePlaylist(int playlist, const PlaylistItemList &items, if (db_->CheckErrors(clear)) return; // Save the new ones - for (PlaylistItemPtr item : items) { // clazy:exclude=range-loop + for (PlaylistItemPtr item : items) { // clazy:exclude=range-loop-reference insert.bindValue(":playlist", playlist); item->BindToQuery(&insert); diff --git a/src/scrobbler/listenbrainzscrobbler.cpp b/src/scrobbler/listenbrainzscrobbler.cpp index 2e9b1ccb..3a54f12e 100644 --- a/src/scrobbler/listenbrainzscrobbler.cpp +++ b/src/scrobbler/listenbrainzscrobbler.cpp @@ -554,7 +554,7 @@ void ListenBrainzScrobbler::Submit() { int i(0); QList list; QList items = cache_->List(); - for (ScrobblerCacheItemPtr item : items) { // clazy:exclude=range-loop + for (ScrobblerCacheItemPtr item : items) { // clazy:exclude=range-loop-reference if (item->sent_) continue; item->sent_ = true; ++i; diff --git a/src/scrobbler/scrobblingapi20.cpp b/src/scrobbler/scrobblingapi20.cpp index 6459c0d0..437e00c1 100644 --- a/src/scrobbler/scrobblingapi20.cpp +++ b/src/scrobbler/scrobblingapi20.cpp @@ -583,7 +583,7 @@ void ScrobblingAPI20::Submit() { int i = 0; QList list; QList items = cache()->List(); - for (ScrobblerCacheItemPtr item : items) { // clazy:exclude=range-loop + for (ScrobblerCacheItemPtr item : items) { // clazy:exclude=range-loop-reference if (item->sent_) continue; item->sent_ = true; if (!batch_) { diff --git a/src/smartplaylists/smartplaylistsmodel.cpp b/src/smartplaylists/smartplaylistsmodel.cpp index 8e73e01f..96249bcd 100644 --- a/src/smartplaylists/smartplaylistsmodel.cpp +++ b/src/smartplaylists/smartplaylistsmodel.cpp @@ -138,7 +138,7 @@ void SmartPlaylistsModel::Init() { // Append the new ones s.beginWriteArray(backend_->songs_table(), playlist_index + unwritten_defaults); for (; version < default_smart_playlists_.count(); ++version) { - for (PlaylistGeneratorPtr gen : default_smart_playlists_[version]) { // clazy:exclude=range-loop + for (PlaylistGeneratorPtr gen : default_smart_playlists_[version]) { // clazy:exclude=range-loop-reference SaveGenerator(&s, playlist_index++, gen); } }