Funkwhale
/
strawberry-audio-player-windows-mac-linux
mirror of https://github.com/strawberrymusicplayer/strawberry
1
0
Fork 0
Code Issues Releases Wiki Activity

Make const

This commit is contained in:
Jonas Kvinge 2021-06-22 13:45:29 +02:00
parent 8c2b907ff5
commit 58a5367015
33 changed files with 78 additions and 78 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
3rdparty/singleapplication/singleapplication.cpp vendored
View File

@ -178,7 +178,7 @@ SingleApplication::~SingleApplication() {
* Checks if the current application instance is primary. * Checks if the current application instance is primary.
* @return Returns true if the instance is primary, false otherwise. * @return Returns true if the instance is primary, false otherwise.
*/ */
bool SingleApplication::isPrimary() { bool SingleApplication::isPrimary() const {
Q_D(SingleApplication); Q_D(SingleApplication);
return d->server_ != nullptr; return d->server_ != nullptr;
} }
@ -187,7 +187,7 @@ bool SingleApplication::isPrimary() {
* Checks if the current application instance is secondary. * Checks if the current application instance is secondary.
* @return Returns true if the instance is secondary, false otherwise. * @return Returns true if the instance is secondary, false otherwise.
*/ */
bool SingleApplication::isSecondary() { bool SingleApplication::isSecondary() const {
Q_D(SingleApplication); Q_D(SingleApplication);
return d->server_ == nullptr; return d->server_ == nullptr;
} }
@ -197,7 +197,7 @@ bool SingleApplication::isSecondary() {
* It is reset when the first (primary) instance of your app starts and only incremented afterwards. * It is reset when the first (primary) instance of your app starts and only incremented afterwards.
* @return Returns a unique instance id. * @return Returns a unique instance id.
*/ */
quint32 SingleApplication::instanceId() { quint32 SingleApplication::instanceId() const {
Q_D(SingleApplication); Q_D(SingleApplication);
return d->instanceNumber_; return d->instanceNumber_;
} }
@ -207,7 +207,7 @@ quint32 SingleApplication::instanceId() {
* Especially useful when SingleApplication is coupled with OS. specific APIs. * Especially useful when SingleApplication is coupled with OS. specific APIs.
* @return Returns the primary instance PID. * @return Returns the primary instance PID.
*/ */
qint64 SingleApplication::primaryPid() { qint64 SingleApplication::primaryPid() const {
Q_D(SingleApplication); Q_D(SingleApplication);
return d->primaryPid(); return d->primaryPid();
} }
@ -216,7 +216,7 @@ qint64 SingleApplication::primaryPid() {
* Returns the username the primary instance is running as. * Returns the username the primary instance is running as.
* @return Returns the username the primary instance is running as. * @return Returns the username the primary instance is running as.
*/ */
QString SingleApplication::primaryUser() { QString SingleApplication::primaryUser() const {
Q_D(SingleApplication); Q_D(SingleApplication);
return d->primaryUser(); return d->primaryUser();
} }
@ -225,7 +225,7 @@ QString SingleApplication::primaryUser() {
* Returns the username the current instance is running as. * Returns the username the current instance is running as.
* @return Returns the username the current instance is running as. * @return Returns the username the current instance is running as.
*/ */
QString SingleApplication::currentUser() { QString SingleApplication::currentUser() const {
Q_D(SingleApplication); Q_D(SingleApplication);
return d->getUsername(); return d->getUsername();
} }

12
3rdparty/singleapplication/singleapplication.h vendored
View File

@ -97,37 +97,37 @@ class SingleApplication : public QApplication { // clazy:exclude=ctor-missing-p
* @brief Returns if the instance is the primary instance * @brief Returns if the instance is the primary instance
* @returns {bool} * @returns {bool}
*/ */
bool isPrimary(); bool isPrimary() const;
/** /**
* @brief Returns if the instance is a secondary instance * @brief Returns if the instance is a secondary instance
* @returns {bool} * @returns {bool}
*/ */
bool isSecondary(); bool isSecondary() const;
/** /**
* @brief Returns a unique identifier for the current instance * @brief Returns a unique identifier for the current instance
* @returns {qint32} * @returns {qint32}
*/ */
quint32 instanceId(); quint32 instanceId() const;
/** /**
* @brief Returns the process ID (PID) of the primary instance * @brief Returns the process ID (PID) of the primary instance
* @returns {qint64} * @returns {qint64}
*/ */
qint64 primaryPid(); qint64 primaryPid() const;
/** /**
* @brief Returns the username of the user running the primary instance * @brief Returns the username of the user running the primary instance
* @returns {QString} * @returns {QString}
*/ */
QString primaryUser(); QString primaryUser() const;
/** /**
* @brief Returns the username of the current user * @brief Returns the username of the current user
* @returns {QString} * @returns {QString}
*/ */
QString currentUser(); QString currentUser() const;
/** /**
* @brief Sends a message to the primary instance. Returns true on success. * @brief Sends a message to the primary instance. Returns true on success.

6
3rdparty/singleapplication/singleapplication_p.cpp vendored
View File

@ -284,7 +284,7 @@ bool SingleApplicationPrivate::connectToPrimary(const int timeout, const Connect
} }
quint16 SingleApplicationPrivate::blockChecksum() { quint16 SingleApplicationPrivate::blockChecksum() const {
#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0) #if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)
quint16 checksum = qChecksum(QByteArray(static_cast<const char*>(memory_->constData()), offsetof(InstancesInfo, checksum))); quint16 checksum = qChecksum(QByteArray(static_cast<const char*>(memory_->constData()), offsetof(InstancesInfo, checksum)));
@ -296,7 +296,7 @@ quint16 SingleApplicationPrivate::blockChecksum() {
} }
qint64 SingleApplicationPrivate::primaryPid() { qint64 SingleApplicationPrivate::primaryPid() const {
memory_->lock(); memory_->lock();
InstancesInfo *inst = static_cast<InstancesInfo*>(memory_->data()); InstancesInfo *inst = static_cast<InstancesInfo*>(memory_->data());
@ -307,7 +307,7 @@ qint64 SingleApplicationPrivate::primaryPid() {
} }
QString SingleApplicationPrivate::primaryUser() { QString SingleApplicationPrivate::primaryUser() const {
memory_->lock(); memory_->lock();
InstancesInfo *inst = static_cast<InstancesInfo*>(memory_->data()); InstancesInfo *inst = static_cast<InstancesInfo*>(memory_->data());

6
3rdparty/singleapplication/singleapplication_p.h vendored
View File

@ -86,9 +86,9 @@ class SingleApplicationPrivate : public QObject {
void startPrimary(); void startPrimary();
void startSecondary(); void startSecondary();
bool connectToPrimary(const int timeout, const ConnectionType connectionType); bool connectToPrimary(const int timeout, const ConnectionType connectionType);
quint16 blockChecksum(); quint16 blockChecksum() const;
qint64 primaryPid(); qint64 primaryPid() const;
QString primaryUser(); QString primaryUser() const;
void readInitMessageHeader(QLocalSocket *socket); void readInitMessageHeader(QLocalSocket *socket);
void readInitMessageBody(QLocalSocket *socket); void readInitMessageBody(QLocalSocket *socket);
static void randomSleep(); static void randomSleep();

12
3rdparty/singleapplication/singlecoreapplication.cpp vendored
View File

@ -178,7 +178,7 @@ SingleCoreApplication::~SingleCoreApplication() {
* Checks if the current application instance is primary. * Checks if the current application instance is primary.
* @return Returns true if the instance is primary, false otherwise. * @return Returns true if the instance is primary, false otherwise.
*/ */
bool SingleCoreApplication::isPrimary() { bool SingleCoreApplication::isPrimary() const {
Q_D(SingleCoreApplication); Q_D(SingleCoreApplication);
return d->server_ != nullptr; return d->server_ != nullptr;
} }
@ -187,7 +187,7 @@ bool SingleCoreApplication::isPrimary() {
* Checks if the current application instance is secondary. * Checks if the current application instance is secondary.
* @return Returns true if the instance is secondary, false otherwise. * @return Returns true if the instance is secondary, false otherwise.
*/ */
bool SingleCoreApplication::isSecondary() { bool SingleCoreApplication::isSecondary() const {
Q_D(SingleCoreApplication); Q_D(SingleCoreApplication);
return d->server_ == nullptr; return d->server_ == nullptr;
} }
@ -197,7 +197,7 @@ bool SingleCoreApplication::isSecondary() {
* It is reset when the first (primary) instance of your app starts and only incremented afterwards. * It is reset when the first (primary) instance of your app starts and only incremented afterwards.
* @return Returns a unique instance id. * @return Returns a unique instance id.
*/ */
quint32 SingleCoreApplication::instanceId() { quint32 SingleCoreApplication::instanceId() const {
Q_D(SingleCoreApplication); Q_D(SingleCoreApplication);
return d->instanceNumber_; return d->instanceNumber_;
} }
@ -207,7 +207,7 @@ quint32 SingleCoreApplication::instanceId() {
* Especially useful when SingleCoreApplication is coupled with OS. specific APIs. * Especially useful when SingleCoreApplication is coupled with OS. specific APIs.
* @return Returns the primary instance PID. * @return Returns the primary instance PID.
*/ */
qint64 SingleCoreApplication::primaryPid() { qint64 SingleCoreApplication::primaryPid() const {
Q_D(SingleCoreApplication); Q_D(SingleCoreApplication);
return d->primaryPid(); return d->primaryPid();
} }
@ -216,7 +216,7 @@ qint64 SingleCoreApplication::primaryPid() {
* Returns the username the primary instance is running as. * Returns the username the primary instance is running as.
* @return Returns the username the primary instance is running as. * @return Returns the username the primary instance is running as.
*/ */
QString SingleCoreApplication::primaryUser() { QString SingleCoreApplication::primaryUser() const {
Q_D(SingleCoreApplication); Q_D(SingleCoreApplication);
return d->primaryUser(); return d->primaryUser();
} }
@ -225,7 +225,7 @@ QString SingleCoreApplication::primaryUser() {
* Returns the username the current instance is running as. * Returns the username the current instance is running as.
* @return Returns the username the current instance is running as. * @return Returns the username the current instance is running as.
*/ */
QString SingleCoreApplication::currentUser() { QString SingleCoreApplication::currentUser() const {
Q_D(SingleCoreApplication); Q_D(SingleCoreApplication);
return d->getUsername(); return d->getUsername();
} }

12
3rdparty/singleapplication/singlecoreapplication.h vendored
View File

@ -96,37 +96,37 @@ class SingleCoreApplication : public QCoreApplication {
* @brief Returns if the instance is the primary instance * @brief Returns if the instance is the primary instance
* @returns {bool} * @returns {bool}
*/ */
bool isPrimary(); bool isPrimary() const;
/** /**
* @brief Returns if the instance is a secondary instance * @brief Returns if the instance is a secondary instance
* @returns {bool} * @returns {bool}
*/ */
bool isSecondary(); bool isSecondary() const;
/** /**
* @brief Returns a unique identifier for the current instance * @brief Returns a unique identifier for the current instance
* @returns {qint32} * @returns {qint32}
*/ */
quint32 instanceId(); quint32 instanceId() const;
/** /**
* @brief Returns the process ID (PID) of the primary instance * @brief Returns the process ID (PID) of the primary instance
* @returns {qint64} * @returns {qint64}
*/ */
qint64 primaryPid(); qint64 primaryPid() const;
/** /**
* @brief Returns the username of the user running the primary instance * @brief Returns the username of the user running the primary instance
* @returns {QString} * @returns {QString}
*/ */
QString primaryUser(); QString primaryUser() const;
/** /**
* @brief Returns the username of the current user * @brief Returns the username of the current user
* @returns {QString} * @returns {QString}
*/ */
QString currentUser(); QString currentUser() const;
/** /**
* @brief Sends a message to the primary instance. Returns true on success. * @brief Sends a message to the primary instance. Returns true on success.

6
3rdparty/singleapplication/singlecoreapplication_p.cpp vendored
View File

@ -284,7 +284,7 @@ bool SingleCoreApplicationPrivate::connectToPrimary(const int timeout, const Con
} }
quint16 SingleCoreApplicationPrivate::blockChecksum() { quint16 SingleCoreApplicationPrivate::blockChecksum() const {
#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0) #if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0)
quint16 checksum = qChecksum(QByteArray(static_cast<const char*>(memory_->constData()), offsetof(InstancesInfo, checksum))); quint16 checksum = qChecksum(QByteArray(static_cast<const char*>(memory_->constData()), offsetof(InstancesInfo, checksum)));
@ -296,7 +296,7 @@ quint16 SingleCoreApplicationPrivate::blockChecksum() {
} }
qint64 SingleCoreApplicationPrivate::primaryPid() { qint64 SingleCoreApplicationPrivate::primaryPid() const {
memory_->lock(); memory_->lock();
InstancesInfo *inst = static_cast<InstancesInfo*>(memory_->data()); InstancesInfo *inst = static_cast<InstancesInfo*>(memory_->data());
@ -307,7 +307,7 @@ qint64 SingleCoreApplicationPrivate::primaryPid() {
} }
QString SingleCoreApplicationPrivate::primaryUser() { QString SingleCoreApplicationPrivate::primaryUser() const {
memory_->lock(); memory_->lock();
InstancesInfo *inst = static_cast<InstancesInfo*>(memory_->data()); InstancesInfo *inst = static_cast<InstancesInfo*>(memory_->data());

6
3rdparty/singleapplication/singlecoreapplication_p.h vendored
View File

@ -86,9 +86,9 @@ class SingleCoreApplicationPrivate : public QObject {
void startPrimary(); void startPrimary();
void startSecondary(); void startSecondary();
bool connectToPrimary(const int timeout, const ConnectionType connectionType); bool connectToPrimary(const int timeout, const ConnectionType connectionType);
quint16 blockChecksum(); quint16 blockChecksum() const;
qint64 primaryPid(); qint64 primaryPid() const;
QString primaryUser(); QString primaryUser() const;
void readInitMessageHeader(QLocalSocket *socket); void readInitMessageHeader(QLocalSocket *socket);
void readInitMessageBody(QLocalSocket *socket); void readInitMessageBody(QLocalSocket *socket);
static void randomSleep(); static void randomSleep();

4
src/analyzer/fht.cpp
View File

@ -58,11 +58,11 @@ void FHT::makeCasTable(void) {
} }
} }
void FHT::scale(float *p, float d) { void FHT::scale(float *p, float d) const {
for (int i = 0; i < (num_ / 2); i++) *p++ *= d; for (int i = 0; i < (num_ / 2); i++) *p++ *= d;
} }
void FHT::ewma(float *d, float *s, float w) { void FHT::ewma(float *d, float *s, float w) const {
for (int i = 0; i < (num_ / 2); i++, d++, s++) *d = *d * w + *s * (1 - w); for (int i = 0; i < (num_ / 2); i++, d++, s++) *d = *d * w + *s * (1 - w);
} }

4
src/analyzer/fht.h
View File

@ -68,7 +68,7 @@ class FHT {
~FHT(); ~FHT();
int sizeExp() const; int sizeExp() const;
int size() const; int size() const;
void scale(float*, float); void scale(float*, float) const;
/** /**
* Exponentially Weighted Moving Average (EWMA) filter. * Exponentially Weighted Moving Average (EWMA) filter.
@ -76,7 +76,7 @@ class FHT {
* @param s is fresh input. * @param s is fresh input.
* @param w is the weighting factor. * @param w is the weighting factor.
*/ */
void ewma(float *d, float *s, float w); void ewma(float *d, float *s, float w) const;
/** /**
* Logarithmic audio spectrum. Maps semi-logarithmic spectrum * Logarithmic audio spectrum. Maps semi-logarithmic spectrum

2
src/collection/collectionquery.cpp
View File

@ -121,7 +121,7 @@ CollectionQuery::CollectionQuery(const QSqlDatabase &db, const QString &songs_ta
} }
QString CollectionQuery::GetInnerQuery() { QString CollectionQuery::GetInnerQuery() const {
return duplicates_only_ return duplicates_only_
? QString(" INNER JOIN (select * from duplicated_songs) dsongs " ? QString(" INNER JOIN (select * from duplicated_songs) dsongs "
"ON (%songs_table.artist = dsongs.dup_artist " "ON (%songs_table.artist = dsongs.dup_artist "

2
src/collection/collectionquery.h
View File

@ -107,7 +107,7 @@ class CollectionQuery : public QSqlQuery {
int limit() const { return limit_; } int limit() const { return limit_; }
private: private:
QString GetInnerQuery(); QString GetInnerQuery() const;
QSqlDatabase db_; QSqlDatabase db_;
QString songs_table_; QString songs_table_;

8
src/collection/collectionview.cpp
View File

@ -636,7 +636,7 @@ void CollectionView::FilterReturnPressed() {
emit doubleClicked(currentIndex()); emit doubleClicked(currentIndex());
} }
void CollectionView::ShowInBrowser() { void CollectionView::ShowInBrowser() const {
SongList songs = GetSelectedSongs(); SongList songs = GetSelectedSongs();
QList<QUrl> urls; QList<QUrl> urls;
@ -649,13 +649,13 @@ void CollectionView::ShowInBrowser() {
} }
int CollectionView::TotalSongs() { int CollectionView::TotalSongs() const {
return total_song_count_; return total_song_count_;
} }
int CollectionView::TotalArtists() { int CollectionView::TotalArtists() const {
return total_artist_count_; return total_artist_count_;
} }
int CollectionView::TotalAlbums() { int CollectionView::TotalAlbums() const {
return total_album_count_; return total_album_count_;
} }

8
src/collection/collectionview.h
View File

@ -66,9 +66,9 @@ class CollectionView : public AutoExpandingTreeView {
void keyboardSearch(const QString &search) override; void keyboardSearch(const QString &search) override;
void scrollTo(const QModelIndex &idx, ScrollHint hint = EnsureVisible) override; void scrollTo(const QModelIndex &idx, ScrollHint hint = EnsureVisible) override;
int TotalSongs(); int TotalSongs() const;
int TotalArtists(); int TotalArtists() const;
int TotalAlbums(); int TotalAlbums() const;
public slots: public slots:
void TotalSongCountUpdated(const int count); void TotalSongCountUpdated(const int count);
@ -107,7 +107,7 @@ class CollectionView : public AutoExpandingTreeView {
void CopyToDevice(); void CopyToDevice();
void EditTracks(); void EditTracks();
void RescanSongs(); void RescanSongs();
void ShowInBrowser(); void ShowInBrowser() const;
void ShowInVarious(); void ShowInVarious();
void NoShowInVarious(); void NoShowInVarious();
void Delete(); void Delete();

2
src/collection/collectionviewcontainer.cpp
View File

@ -46,7 +46,7 @@ CollectionViewContainer::CollectionViewContainer(QWidget *parent) : QWidget(pare
CollectionViewContainer::~CollectionViewContainer() { delete ui_; } CollectionViewContainer::~CollectionViewContainer() { delete ui_; }
CollectionView *CollectionViewContainer::view() const { return ui_->view; } CollectionView *CollectionViewContainer::view() const { return ui_->view; }
CollectionFilterWidget *CollectionViewContainer::filter() const { return ui_->filter; } CollectionFilterWidget *CollectionViewContainer::filter() const { return ui_->filter; }
void CollectionViewContainer::ReloadSettings() { void CollectionViewContainer::ReloadSettings() const {
filter()->ReloadSettings(); filter()->ReloadSettings();
view()->ReloadSettings(); view()->ReloadSettings();
} }

2
src/collection/collectionviewcontainer.h
View File

@ -41,7 +41,7 @@ class CollectionViewContainer : public QWidget {
CollectionFilterWidget *filter() const; CollectionFilterWidget *filter() const;
CollectionView *view() const; CollectionView *view() const;
void ReloadSettings(); void ReloadSettings() const;
private: private:
Ui_CollectionViewContainer *ui_; Ui_CollectionViewContainer *ui_;

2
src/context/contextalbumsview.cpp
View File

@ -418,7 +418,7 @@ void ContextAlbumsView::CopyToDevice() {
#endif #endif
} }
void ContextAlbumsView::ShowInBrowser() { void ContextAlbumsView::ShowInBrowser() const {
const SongList songs = GetSelectedSongs(); const SongList songs = GetSelectedSongs();
QList<QUrl> urls; QList<QUrl> urls;

2
src/context/contextalbumsview.h
View File

@ -96,7 +96,7 @@ class ContextAlbumsView : public AutoExpandingTreeView {
void Organize(); void Organize();
void CopyToDevice(); void CopyToDevice();
void EditTracks(); void EditTracks();
void ShowInBrowser(); void ShowInBrowser() const;
private: private:
void RecheckIsEmpty(); void RecheckIsEmpty();

6
src/internet/internetcollectionview.cpp
View File

@ -440,12 +440,12 @@ void InternetCollectionView::FilterReturnPressed() {
} }
int InternetCollectionView::TotalSongs() { int InternetCollectionView::TotalSongs() const {
return total_song_count_; return total_song_count_;
} }
int InternetCollectionView::TotalArtists() { int InternetCollectionView::TotalArtists() const {
return total_artist_count_; return total_artist_count_;
} }
int InternetCollectionView::TotalAlbums() { int InternetCollectionView::TotalAlbums() const {
return total_album_count_; return total_album_count_;
} }

6
src/internet/internetcollectionview.h
View File

@ -65,9 +65,9 @@ class InternetCollectionView : public AutoExpandingTreeView {
void keyboardSearch(const QString &search) override; void keyboardSearch(const QString &search) override;
void scrollTo(const QModelIndex &idx, ScrollHint hint = EnsureVisible) override; void scrollTo(const QModelIndex &idx, ScrollHint hint = EnsureVisible) override;
int TotalSongs(); int TotalSongs() const;
int TotalArtists(); int TotalArtists() const;
int TotalAlbums(); int TotalAlbums() const;
public slots: public slots:
void TotalSongCountUpdated(int count); void TotalSongCountUpdated(int count);

2
src/internet/internetcollectionviewcontainer.cpp
View File

@ -52,7 +52,7 @@ InternetCollectionViewContainer::InternetCollectionViewContainer(QWidget *parent
InternetCollectionViewContainer::~InternetCollectionViewContainer() { delete ui_; } InternetCollectionViewContainer::~InternetCollectionViewContainer() { delete ui_; }
void InternetCollectionViewContainer::ReloadSettings() { void InternetCollectionViewContainer::ReloadSettings() const {
filter()->ReloadSettings(); filter()->ReloadSettings();
view()->ReloadSettings(); view()->ReloadSettings();
} }

2
src/internet/internetcollectionviewcontainer.h
View File

@ -45,7 +45,7 @@ class InternetCollectionViewContainer : public QWidget {
explicit InternetCollectionViewContainer(QWidget *parent = nullptr); explicit InternetCollectionViewContainer(QWidget *parent = nullptr);
~InternetCollectionViewContainer() override; ~InternetCollectionViewContainer() override;
void ReloadSettings(); void ReloadSettings() const;
QStackedWidget *stacked() const { return ui_->stacked; } QStackedWidget *stacked() const { return ui_->stacked; }
QWidget *help_page() const { return ui_->help_page; } QWidget *help_page() const { return ui_->help_page; }

2
src/playlist/playlistmanager.cpp
View File

@ -543,7 +543,7 @@ void PlaylistManager::RemoveItemsWithoutUndo(const int id, const QList<int> &ind
} }
void PlaylistManager::RemoveCurrentSong() { void PlaylistManager::RemoveCurrentSong() const {
active()->removeRows(active()->current_index().row(), 1); active()->removeRows(active()->current_index().row(), 1);
} }

2
src/playlist/playlistmanager.h
View File

@ -213,7 +213,7 @@ class PlaylistManager : public PlaylistManagerInterface {
// Removes items with given indices from the playlist. This operation is not undoable. // Removes items with given indices from the playlist. This operation is not undoable.
void RemoveItemsWithoutUndo(const int id, const QList<int> &indices); void RemoveItemsWithoutUndo(const int id, const QList<int> &indices);
// Remove the current playing song // Remove the current playing song
void RemoveCurrentSong(); void RemoveCurrentSong() const;
void PlaySmartPlaylist(PlaylistGeneratorPtr generator, const bool as_new, const bool clear) override; void PlaySmartPlaylist(PlaylistGeneratorPtr generator, const bool as_new, const bool clear) override;

2
src/settings/coverssettingspage.cpp
View File

@ -206,7 +206,7 @@ void CoversSettingsPage::DisableAuthentication() {
} }
void CoversSettingsPage::DisconnectAuthentication(CoverProvider *provider) { void CoversSettingsPage::DisconnectAuthentication(CoverProvider *provider) const {
QObject::disconnect(provider, &CoverProvider::AuthenticationFailure, this, &CoversSettingsPage::AuthenticationFailure); QObject::disconnect(provider, &CoverProvider::AuthenticationFailure, this, &CoversSettingsPage::AuthenticationFailure);
QObject::disconnect(provider, &CoverProvider::AuthenticationSuccess, this, &CoversSettingsPage::AuthenticationSuccess); QObject::disconnect(provider, &CoverProvider::AuthenticationSuccess, this, &CoversSettingsPage::AuthenticationSuccess);

2
src/settings/coverssettingspage.h
View File

@ -50,7 +50,7 @@ class CoversSettingsPage : public SettingsPage {
void NoProviderSelected(); void NoProviderSelected();
void ProvidersMove(const int d); void ProvidersMove(const int d);
void DisableAuthentication(); void DisableAuthentication();
void DisconnectAuthentication(CoverProvider *provider); void DisconnectAuthentication(CoverProvider *provider) const;
static bool ProviderCompareOrder(CoverProvider *a, CoverProvider *b); static bool ProviderCompareOrder(CoverProvider *a, CoverProvider *b);
private slots: private slots:

2
src/settings/lyricssettingspage.cpp
View File

@ -196,7 +196,7 @@ void LyricsSettingsPage::DisableAuthentication() {
} }
void LyricsSettingsPage::DisconnectAuthentication(LyricsProvider *provider) { void LyricsSettingsPage::DisconnectAuthentication(LyricsProvider *provider) const {
QObject::disconnect(provider, &LyricsProvider::AuthenticationFailure, this, &LyricsSettingsPage::AuthenticationFailure); QObject::disconnect(provider, &LyricsProvider::AuthenticationFailure, this, &LyricsSettingsPage::AuthenticationFailure);
QObject::disconnect(provider, &LyricsProvider::AuthenticationSuccess, this, &LyricsSettingsPage::AuthenticationSuccess); QObject::disconnect(provider, &LyricsProvider::AuthenticationSuccess, this, &LyricsSettingsPage::AuthenticationSuccess);

2
src/settings/lyricssettingspage.h
View File

@ -50,7 +50,7 @@ class LyricsSettingsPage : public SettingsPage {
void NoProviderSelected(); void NoProviderSelected();
void ProvidersMove(const int d); void ProvidersMove(const int d);
void DisableAuthentication(); void DisableAuthentication();
void DisconnectAuthentication(LyricsProvider *provider); void DisconnectAuthentication(LyricsProvider *provider) const;
static bool ProviderCompareOrder(LyricsProvider *a, LyricsProvider *b); static bool ProviderCompareOrder(LyricsProvider *a, LyricsProvider *b);
private slots: private slots:

2
src/subsonic/subsonicbaserequest.cpp
View File

@ -53,7 +53,7 @@ SubsonicBaseRequest::SubsonicBaseRequest(SubsonicService *service, QObject *pare
} }
QUrl SubsonicBaseRequest::CreateUrl(const QString &ressource_name, const QList<Param> &params_provided) { QUrl SubsonicBaseRequest::CreateUrl(const QString &ressource_name, const QList<Param> &params_provided) const {
ParamList params = ParamList() << params_provided ParamList params = ParamList() << params_provided
<< Param("c", client_name()) << Param("c", client_name())

2
src/subsonic/subsonicbaserequest.h
View File

@ -53,7 +53,7 @@ class SubsonicBaseRequest : public QObject {
typedef QPair<QByteArray, QByteArray> EncodedParam; typedef QPair<QByteArray, QByteArray> EncodedParam;
typedef QList<EncodedParam> EncodedParamList; typedef QList<EncodedParam> EncodedParamList;
QUrl CreateUrl(const QString &ressource_name, const QList<Param> &params_provided); QUrl CreateUrl(const QString &ressource_name, const QList<Param> &params_provided) const;
QNetworkReply *CreateGetRequest(const QString &ressource_name, const QList<Param> &params_provided); QNetworkReply *CreateGetRequest(const QString &ressource_name, const QList<Param> &params_provided);
QByteArray GetReplyData(QNetworkReply *reply); QByteArray GetReplyData(QNetworkReply *reply);
QJsonObject ExtractJsonObj(QByteArray &data); QJsonObject ExtractJsonObj(QByteArray &data);

2
src/transcoder/transcoder.cpp
View File

@ -394,7 +394,7 @@ GstBusSyncReply Transcoder::BusCallbackSync(GstBus*, GstMessage *msg, gpointer d
} }
void Transcoder::JobState::ReportError(GstMessage *msg) { void Transcoder::JobState::ReportError(GstMessage *msg) const {
GError *error = nullptr; GError *error = nullptr;
gchar *debugs = nullptr; gchar *debugs = nullptr;

2
src/transcoder/transcoder.h
View File

@ -100,7 +100,7 @@ class Transcoder : public QObject {
~JobState(); ~JobState();
void PostFinished(const bool success); void PostFinished(const bool success);
void ReportError(GstMessage *msg); void ReportError(GstMessage *msg) const;
Job job_; Job job_;
Transcoder *parent_; Transcoder *parent_;

12
src/widgets/fancytabwidget.cpp
View File

@ -360,12 +360,12 @@ class TabData : public QObject { // clazy:exclude=missing-qobject-macro
page_->setLayout(layout); page_->setLayout(layout);
} }
QWidget *widget_view() { return widget_view_; } QWidget *widget_view() const { return widget_view_; }
QString name() { return name_; } QString name() const { return name_; }
QIcon icon() { return icon_; } QIcon icon() const { return icon_; }
QString label() { return label_; } QString label() const { return label_; }
QWidget *page() { return page_; } QWidget *page() const { return page_; }
int index() { return index_; } int index() const { return index_; }
private: private:
QWidget *widget_view_; QWidget *widget_view_;