Fix dtor compile warnings with Clang

This commit is contained in:
Jonas Kvinge 2024-07-30 16:34:20 +02:00
parent 9bfd14d067
commit 388dcf2a1f
6 changed files with 3 additions and 6 deletions

View File

@ -32,6 +32,7 @@
#include "tagreaderbase.h"
TagReaderBase::TagReaderBase() = default;
TagReaderBase::~TagReaderBase() = default;
QString TagReaderBase::ErrorString(const Result &result) {

View File

@ -34,7 +34,7 @@
class TagReaderBase {
public:
explicit TagReaderBase();
~TagReaderBase() = default;
virtual ~TagReaderBase();
class Result {
public:

View File

@ -99,7 +99,6 @@ class TagReaderGME : public TagReaderBase {
public:
explicit TagReaderGME();
~TagReaderGME() = default;
bool IsMediaFile(const QString &filename) const override;

View File

@ -55,7 +55,7 @@ class FileRefFactory;
class TagReaderTagLib : public TagReaderBase {
public:
explicit TagReaderTagLib();
~TagReaderTagLib();
~TagReaderTagLib() override;
static inline TagLib::String StdStringToTagLibString(const std::string &s) {
return TagLib::String(s.c_str(), TagLib::String::UTF8);

View File

@ -46,8 +46,6 @@
TagReaderTagParser::TagReaderTagParser() = default;
TagReaderTagParser::~TagReaderTagParser() = default;
bool TagReaderTagParser::IsMediaFile(const QString &filename) const {
qLog(Debug) << "Checking for valid file" << filename;

View File

@ -37,7 +37,6 @@
class TagReaderTagParser : public TagReaderBase {
public:
explicit TagReaderTagParser();
~TagReaderTagParser();
bool IsMediaFile(const QString &filename) const override;