diff --git a/ext/libstrawberry-tagreader/tagreaderbase.cpp b/ext/libstrawberry-tagreader/tagreaderbase.cpp index ff03c262b..ddf86d4e0 100644 --- a/ext/libstrawberry-tagreader/tagreaderbase.cpp +++ b/ext/libstrawberry-tagreader/tagreaderbase.cpp @@ -32,6 +32,7 @@ #include "tagreaderbase.h" TagReaderBase::TagReaderBase() = default; +TagReaderBase::~TagReaderBase() = default; QString TagReaderBase::ErrorString(const Result &result) { diff --git a/ext/libstrawberry-tagreader/tagreaderbase.h b/ext/libstrawberry-tagreader/tagreaderbase.h index dd5e41ec3..fba315d6f 100644 --- a/ext/libstrawberry-tagreader/tagreaderbase.h +++ b/ext/libstrawberry-tagreader/tagreaderbase.h @@ -34,7 +34,7 @@ class TagReaderBase { public: explicit TagReaderBase(); - ~TagReaderBase() = default; + virtual ~TagReaderBase(); class Result { public: diff --git a/ext/libstrawberry-tagreader/tagreadergme.h b/ext/libstrawberry-tagreader/tagreadergme.h index 3f298c879..4ad5f637b 100644 --- a/ext/libstrawberry-tagreader/tagreadergme.h +++ b/ext/libstrawberry-tagreader/tagreadergme.h @@ -99,7 +99,6 @@ class TagReaderGME : public TagReaderBase { public: explicit TagReaderGME(); - ~TagReaderGME() = default; bool IsMediaFile(const QString &filename) const override; diff --git a/ext/libstrawberry-tagreader/tagreadertaglib.h b/ext/libstrawberry-tagreader/tagreadertaglib.h index 6192c4282..d66a8ab89 100644 --- a/ext/libstrawberry-tagreader/tagreadertaglib.h +++ b/ext/libstrawberry-tagreader/tagreadertaglib.h @@ -55,7 +55,7 @@ class FileRefFactory; class TagReaderTagLib : public TagReaderBase { public: explicit TagReaderTagLib(); - ~TagReaderTagLib(); + ~TagReaderTagLib() override; static inline TagLib::String StdStringToTagLibString(const std::string &s) { return TagLib::String(s.c_str(), TagLib::String::UTF8); diff --git a/ext/libstrawberry-tagreader/tagreadertagparser.cpp b/ext/libstrawberry-tagreader/tagreadertagparser.cpp index e8135b785..24aabda6e 100644 --- a/ext/libstrawberry-tagreader/tagreadertagparser.cpp +++ b/ext/libstrawberry-tagreader/tagreadertagparser.cpp @@ -46,8 +46,6 @@ TagReaderTagParser::TagReaderTagParser() = default; -TagReaderTagParser::~TagReaderTagParser() = default; - bool TagReaderTagParser::IsMediaFile(const QString &filename) const { qLog(Debug) << "Checking for valid file" << filename; diff --git a/ext/libstrawberry-tagreader/tagreadertagparser.h b/ext/libstrawberry-tagreader/tagreadertagparser.h index 9266386a5..41e682d23 100644 --- a/ext/libstrawberry-tagreader/tagreadertagparser.h +++ b/ext/libstrawberry-tagreader/tagreadertagparser.h @@ -37,7 +37,6 @@ class TagReaderTagParser : public TagReaderBase { public: explicit TagReaderTagParser(); - ~TagReaderTagParser(); bool IsMediaFile(const QString &filename) const override;