Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity
Clementine-audio-player-Mac.../src/devices
History
Jim Broadus 95187ed0a1 Fix encoding of GError messages when logging. (#6228) 
GError messages contain non-ascii characters. This normally just produces some garbage when we use the default QString contructor that assumes ASCII for logging. However, when a message includes the right double quote, UTF-8 sequence 0xE2 0x80 0x9D, the final byte is OSC. VT100 expects a command sequence to follow and stops echoing output until it sees ST or BEL character, which may never come. Thus, the console output is halted.

This change uses QString::fromLocal8Bit instead of depending on the default constructor. About half of the sites in the codebase had already been converted.

One side effect is that log messages are quoted. There are additional options to control this, but those were only introduced in Qt 5.4.
 		2018-12-02 09:51:19 +00:00
..
cddadevice.cpp Revert "Use constructor for QString and make format" 2014-11-05 12:25:09 +01:00
cddadevice.h Finish CD integration update to Gstreamer 1.0 2014-10-26 03:32:37 +01:00
cddalister.cpp Reformat all non-3rd-party C/C++/Objective-C++. 2014-02-07 16:34:20 +01:00
cddalister.h gstreamer-cdda is in gst-plugins-base in 1.0 and has a different header name. 2014-09-22 22:28:53 +10:00
cddasongloader.cpp Fix encoding of GError messages when logging. (#6228) 2018-12-02 09:51:19 +00:00
cddasongloader.h Load the audio cd in a separate thread 2018-07-06 17:09:21 +01:00
connecteddevice.cpp Reformat all non-3rd-party C/C++/Objective-C++. 2014-02-07 16:34:20 +01:00
connecteddevice.h Reformat all non-3rd-party C/C++/Objective-C++. 2014-02-07 16:34:20 +01:00
devicedatabasebackend.cpp Reformat all non-3rd-party C/C++/Objective-C++. 2014-02-07 16:34:20 +01:00
devicedatabasebackend.h Use nullptr as parent parameter default everywhere 2014-02-10 16:03:54 +01:00
devicekitlister.cpp Spelling: D-Bus (#5837) 2017-08-28 23:37:25 +02:00
devicekitlister.h Reformat all non-3rd-party C/C++/Objective-C++. 2014-02-07 16:34:20 +01:00
devicelister.cpp Reformat all non-3rd-party C/C++/Objective-C++. 2014-02-07 16:34:20 +01:00
devicelister.h Reformat all non-3rd-party C/C++/Objective-C++. 2014-02-07 16:34:20 +01:00
devicemanager.cpp Fixes for cross compiling for mac. 2016-12-15 11:36:05 +00:00
devicemanager.h Some more NULL -> nullptr conversions. 2014-02-21 17:30:46 +01:00
deviceproperties.cpp Remove most usages of QFutureWatcher 2015-11-27 14:28:12 +00:00
deviceproperties.h Remove most usages of QFutureWatcher 2015-11-27 14:28:12 +00:00
deviceproperties.ui
…
devicestatefiltermodel.cpp Reformat all non-3rd-party C/C++/Objective-C++. 2014-02-07 16:34:20 +01:00
devicestatefiltermodel.h Reformat all non-3rd-party C/C++/Objective-C++. 2014-02-07 16:34:20 +01:00
deviceview.cpp check custom icon location, then system theme & then fallback theme 2015-10-13 22:35:49 -05:00
deviceview.h Use nullptr as parent parameter default everywhere 2014-02-10 16:03:54 +01:00
deviceviewcontainer.cpp check custom icon location, then system theme & then fallback theme 2015-10-13 22:35:49 -05:00
deviceviewcontainer.h Use nullptr as parent parameter default everywhere 2014-02-10 16:03:54 +01:00
deviceviewcontainer.ui Show a message in the Devices pane on Windows to say that most devices won't work. Fixes #4059 2014-01-05 11:32:07 +11:00
filesystemdevice.cpp Reformat all non-3rd-party C/C++/Objective-C++. 2014-02-07 16:34:20 +01:00
filesystemdevice.h Reformat all non-3rd-party C/C++/Objective-C++. 2014-02-07 16:34:20 +01:00
giolister.cpp Fix encoding of GError messages when logging. (#6228) 2018-12-02 09:51:19 +00:00
giolister.h disconnect GVolumeMonitor signals from GioLister before destroying it 2016-05-11 17:58:12 +03:00
gpoddevice.cpp Fix encoding of GError messages when logging. (#6228) 2018-12-02 09:51:19 +00:00
gpoddevice.h Fix device loader error messages. (#6215) 2018-11-28 10:23:31 +00:00
gpodloader.cpp Fix encoding of GError messages when logging. (#6228) 2018-12-02 09:51:19 +00:00
gpodloader.h Reformat all non-3rd-party C/C++/Objective-C++. 2014-02-07 16:34:20 +01:00
macdevicelister.h Reformat all non-3rd-party C/C++/Objective-C++. 2014-02-07 16:34:20 +01:00
macdevicelister.mm Some more NULL -> nullptr conversions. 2014-02-21 17:30:46 +01:00
mtpconnection.cpp Reformat all non-3rd-party C/C++/Objective-C++. 2014-02-07 16:34:20 +01:00
mtpconnection.h Reformat all non-3rd-party C/C++/Objective-C++. 2014-02-07 16:34:20 +01:00
mtpdevice.cpp Fix device loader error messages. (#6215) 2018-11-28 10:23:31 +00:00
mtpdevice.h Fix device loader error messages. (#6215) 2018-11-28 10:23:31 +00:00
mtploader.cpp Reformat all non-3rd-party C/C++/Objective-C++. 2014-02-07 16:34:20 +01:00
mtploader.h Reformat all non-3rd-party C/C++/Objective-C++. 2014-02-07 16:34:20 +01:00
udisks2lister.cpp Spelling: D-Bus (#5838) 2017-08-28 23:37:47 +02:00
udisks2lister.h Remove non-static data member initializers 2016-07-06 14:26:45 +01:00