8682d4de48
Fix sentinels in variadic function calls
...
Replace sentinel NULL with nullptr, guaranteed to be correctly expanded.
NULL may be defined as plain 0 in C++; which may lead to undefined upper
bits passed in variadic function arguments, causing crashes.
See: https://ewontfix.com/11/
2021-08-23 21:33:46 +01:00
341dc7326f
Reformat all C++
2020-09-22 14:56:06 +01:00
e63c1edbbf
Fix formatting
2020-01-05 19:08:03 +01:00
341a4d1423
Replace QTime with QElapsedTimer
2020-01-05 19:01:54 +01:00
9e85eb2c0f
Fix gst_buffer_unref assertion in chromaprinter
2019-06-09 10:29:41 +01:00
8c198a99a5
Qt 5 fixes
2018-11-21 10:31:17 +00:00
2096b1f268
Merge branch 'master' into qt5
2016-12-13 20:26:19 +01:00
ded3126857
Add compatibility with chromaprint >= 1.4
2016-12-08 23:12:17 +01:00
5aec1c0e24
Merge remote-tracking branch 'upstream/master' into qt5
...
Update qt version to 5.4.2
2015-06-03 22:57:58 +02:00
96f4d64449
Minor coding improvements for c71aa6 .
2015-05-04 15:43:23 +02:00
c71aa61f8f
Simplification and cleanup fixes for chromaprint fingerprint creation.
...
Fixes among other things the "GLib-CRITICAL **: Source ID XXX was not found" error.
2015-05-04 15:11:31 +02:00
8b226c2171
Update non optionnals sources to qt5
2015-04-11 23:24:07 +02:00
af8f4100cd
Fix crash when trying to fingerprint but missing a plugin.
2015-02-03 18:13:23 +01:00
6bb81328e8
Merge branch 'master' into gstreamer-1.2
...
Conflicts:
ext/clementine-spotifyblob/mediapipeline.cpp
gst/moodbar/gstfftwspectrum.c
src/core/songloader.cpp
src/core/songloader.h
src/engines/gstengine.cpp
src/engines/gstenginepipeline.cpp
src/moodbar/moodbarpipeline.cpp
src/musicbrainz/chromaprinter.cpp
src/transcoder/transcoder.cpp
src/ui/mainwindow.cpp
src/visualisations/projectmvisualisation.cpp
2014-06-09 16:20:24 +10:00
bebd781fdf
Reformat all non-3rd-party C/C++/Objective-C++.
...
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
-style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
71893e4847
Use nullptr instead of NULL everywhere.
2014-02-06 17:29:59 +01:00
5ac83bd463
Merge branch 'master' into gstreamer-1.2
2014-01-25 00:24:31 +11:00
7fdaff079d
Don't try to stop the chromaprinter event loop a second time after it's
...
already been stopped. This can happen if the song is exactly 30 seconds long.
Fixes issue 4001
2013-12-03 20:32:26 +11:00
56c949815b
First pass at Gstreamer 1.0 porting.
...
This at least compiles against gstreamer 1.2.
Things that work:
* Playing audio
* Automatically completing tags
Things that don't work
* Spotify
* Moodbar
Things I haven't tested
* Transcoding
2013-09-26 17:49:24 +02:00
e4f0f25feb
Use utf-8 instead of the local system encoding when passing filenames to gstreamer in the chromaprinter. Might fix issue 3703.
2013-06-01 12:55:59 +10:00
90803fa0e0
Remove use of deprecated gstreamer functions.
2013-01-29 13:19:26 +01:00
145b811eef
Fix a memory leak when fingerprinting songs. Fixes issue 3403.
2013-01-06 07:51:48 +11:00
cbc650f44b
Use CHECKED_GCONNECT instead of g_signal_connect everywhere.
2012-06-08 15:34:00 +02:00
822d766a04
Add constants for chromaprinter decode rate & channels.
2012-02-02 14:15:55 +01:00
4157169ab5
Fix leak of Chromaprint context.
2012-02-02 14:13:34 +01:00
0c5f422eb8
* Add check that chromaprinter is only used from a non-UI thread.
...
* Update copyright date
2012-01-09 15:32:15 +01:00
d17629586f
Use the system version of libchromaprint if available
2012-01-07 15:27:50 +00:00
9bb37fda62
Disable callbacks after generating fingerprint.
2012-01-06 16:45:34 +00:00
db83c411c2
* Use Chromaprinter instead of OFA fingerprinter.
...
* Send fingerprint to Acoustid instead of MusicDNS.
* Retrieve MBID instead of PUID and send to Musicbrainz.
2012-01-06 16:31:29 +00:00
423295b01e
Add Chromaprinter class to generate fingerprint from gstreamer PCM output.
2012-01-06 15:58:46 +00:00
Ismael Luceno
John Maguire
Jonas Kvinge
Chocobozzz
Alexander Bikadorov
John Maguire
David Sansome