1
0
mirror of https://github.com/clementine-player/Clementine synced 2024-12-17 20:09:50 +01:00
Commit Graph

85 Commits

Author SHA1 Message Date
John Maguire
6794b67a2f Fix LibraryModel tests. 2010-05-11 19:03:29 +00:00
John Maguire
5dd0a9c35f Autodetect weird encodings in ID3v1 tags.
Fixes issue #254
2010-05-11 12:03:55 +00:00
David Sansome
1aee5e4667 Split all the source files up into seven new directories. 2010-05-10 21:50:31 +00:00
David Sansome
481dbae992 Save magnatune playlist items properly, also fix tests from before 2010-05-10 14:19:43 +00:00
David Sansome
88ab9a8299 Add a table for the Magnatune library, and add the Magnatune database to it when the Magnatune node is expanded. Sort the Magnatune library model properly, and don't crash when adding or removing items. 2010-05-09 16:53:35 +00:00
David Sansome
6b8d6c93f9 Add a MergedProxyModel that lets us merge two models into one... 2010-05-09 15:51:04 +00:00
David Sansome
1b00aaa8b3 Big refactoring of the Library <-> LibraryBackend <-> SQLite interaction.
The LibraryBackend has now been split into a Database class that deals with setting up sqlite, and PlaylistBackend that contains the functions for persisting the playlist.  The LibraryBackend now only contains functions for accessing "a collection of songs", and can be parameterised with table names to access different collections.  It also no longer lives in a background thread, and follows the Qt memory management model instead of using shared_ptr.
Most of Library has been moved into LibraryModel - a QAbstractItemModel for any LibraryBackend.  What's left of Library is now specific to the user's local library on disk.
2010-05-09 00:10:26 +00:00
David Sansome
0c9e69ed30 Group "remove" undo commands in the playlist. Fixes issue #262 2010-04-29 23:58:31 +00:00
David Sansome
48bd5020cd Don't crash when editing a song that doesn't exist any more, also don't even add deleted songs to the playlist. Fixes issue #253. 2010-04-27 17:37:26 +00:00
David Sansome
36af3ddbe4 After shuffling the playlist, make sure next works as expected. Fixes issue #248 2010-04-26 11:36:10 +00:00
David Sansome
5fed8efc44 Test WMA files too 2010-04-21 18:21:27 +00:00
David Sansome
7263983e0c More debug output in CanDecode, and set the gst path in GstEngine rather than main() 2010-04-21 17:11:50 +00:00
David Sansome
4eedddd57c Make the gst engine emit Error() instead of showing its own dialog when a plugin couldn't be found. 2010-04-21 11:14:12 +00:00
David Sansome
0656330548 Test we can load various popular file formats 2010-04-20 22:00:02 +00:00
David Sansome
58ae505377 If you remove the currently playing song, then undo it, keep the "currently playing" status on the newly re-added song. Updates issue #152. 2010-04-20 19:08:12 +00:00
David Sansome
57c9a0d00a Tests for playlist undo/redo 2010-04-20 18:41:12 +00:00
David Sansome
2a33954725 Codereview comments from r701 2010-04-14 22:36:28 +00:00
David Sansome
ed152be391 Scoped transaction test 2010-04-14 22:32:07 +00:00
David Sansome
c29742a739 Fix the playlist test to use shared_ptrs 2010-04-14 22:11:59 +00:00
David Sansome
d1966aa7f6 Check these additional tables exist 2010-04-14 21:09:28 +00:00
David Sansome
af07b5becd Store the playlist in the database. This is still quite slow. 2010-04-14 21:03:00 +00:00
David Sansome
04f467b2fe Add missing file - buildbot is useful! 2010-04-14 16:25:04 +00:00
David Sansome
76ef868c0a Don't pass non-const references 2010-04-14 16:12:33 +00:00
David Sansome
65440dd374 Codereview comments from r685 2010-04-14 16:00:45 +00:00
David Sansome
3172f6b950 Basic playlist manipulation tests 2010-04-14 15:57:58 +00:00
David Sansome
747ae61620 More playlist tests 2010-04-14 15:39:24 +00:00
David Sansome
921eb94a21 Abstract the QSettings usage out of Playlist and PlaylistSequence, create a mock for it, and add a basic playlist test 2010-04-14 14:48:10 +00:00
John Maguire
f429b53212 Use static version of qsqlite plugin on mac as well & disable qxt for mac.
The plugin shipped with Qt has the sqlite symbols set to hidden. It seems dlsym() actually cares about that on Snow Leopard whereas it doesn't in Leopard.
If it can't find the sqlite functions in the given library, then it will go fishing and find /usr/lib/libsqlite3.dylib and that's bad :-(
2010-04-13 19:43:08 +00:00
David Sansome
7238bd7014 Fix tests 2010-04-11 21:45:01 +00:00
David Sansome
a4e14afdbb Load translations from an empty context too. 2010-04-08 14:29:08 +00:00
David Sansome
9f3fc3d8ab Add the library test back in 2010-04-04 16:28:34 +00:00
David Sansome
fd2da463b1 Update library backend tests 2010-04-04 13:17:07 +00:00
David Sansome
48270bfeec Fix tests 2010-04-01 17:03:42 +00:00
David Sansome
29ba8d5bd3 Fix tests on windows 2010-03-31 19:33:12 +00:00
David Sansome
b8be261700 Some little fixes for compilation on Windows 2010-03-31 02:55:05 +00:00
David Sansome
4c42813d9f Add "group by" support to the library, and improve the whole library model to make it more robust.
Still todo: the "Group by advanced..." dialog, unit tests.
Updates issue #94.
2010-03-31 00:30:57 +00:00
John Maguire
df38ebf9d9 A few little mac fixes. 2010-03-30 15:53:45 +00:00
David Sansome
1081c948ae Add missing copyright headers 2010-03-29 19:25:08 +00:00
David Sansome
ea1df6dbff Fix the translation resource file generation - thanks Henry Sylvain. Also add a test to make sure they're always found. 2010-03-29 19:12:06 +00:00
John Maguire
5e482b99ec Namespace test only targets. 2010-03-29 13:52:29 +00:00
John Maguire
813fa70db1 Only build test main twice rather than once per test. 2010-03-29 13:47:46 +00:00
David Sansome
0e4fb1b789 Fix loading songs with a # (or other URL special characters) in the name. Fixes issue #117 2010-03-27 15:53:02 +00:00
John Maguire
2afd94ce47 Switch cover manager filter from OR to AND. 2010-03-26 15:04:38 +00:00
John Maguire
1cad21a3e0 Only enable gui in tests that need it. 2010-03-26 12:50:27 +00:00
John Maguire
2b812a76fd Split search query in cover manager.
Add unit tests.
Fixes issue #119
2010-03-26 12:22:19 +00:00
John Maguire
2e71390acd Switch from OR to AND in split queries.
Fixes issue #116
2010-03-25 15:59:58 +00:00
John Maguire
95252ccc71 Support query splitting in library search.
Improve performance of LIKE().
Fixes issue #104
2010-03-25 13:58:24 +00:00
David Sansome
ceb225c236 More tests for edge cases when removing songs from the library 2010-03-24 19:53:00 +00:00
David Sansome
1103ef77da More library tests 2010-03-24 19:05:49 +00:00
David Sansome
af5ede8dd0 Library tests for some corner cases 2010-03-24 17:48:25 +00:00