Commit Graph

355 Commits

Author SHA1 Message Date
Morris Hafner 8a6cc8b506 Add missing <functional> includes (#5630) 2017-02-13 16:46:46 +00:00
Chocobozzz 2ede85bdcd Merge branch 'master' into qt5 2016-12-18 17:04:08 +01:00
John Maguire 6f356592a5 Fixes for cross compiling for mac. 2016-12-15 11:36:05 +00:00
Chocobozzz 18a89f78a9 Merge remote-tracking branch 'upstream/master' into qt5 2016-10-07 14:30:09 +02:00
John Maguire 1f95a23fd4 Remove non-static data member initializers 2016-07-06 14:26:45 +01:00
John Maguire 6b90f69894 Fix typo 2016-06-01 11:46:52 +01:00
John Maguire b90fb73480 Merge pull request #5394 from Chemrat/udisks2
Udisks2 support
2016-06-01 00:10:26 +01:00
Valeriy ecaa9de788 fix variable names 2016-05-31 20:31:39 +03:00
Valeriy 1812f089b0 feed udisks2lister.* through format.py
add copyright headers
2016-05-31 18:31:00 +03:00
Valeriy 0172f7265b fix code style 2016-05-31 18:19:46 +03:00
Valeriy cc6a99ef92 handle our unmount responses because those unmount jobs expire too fast
for jobs use dbus interface when possible
clean up the code a bit
2016-05-30 18:24:02 +03:00
Valeriy ed986d3863 UDisks2.Job interface support 2016-05-22 23:44:22 +03:00
Valeriy 68001ff7e8 udisks2: handle unmount jobs too, more verbose logging 2016-05-21 23:29:18 +03:00
Valeriy d4e932db9a udisks2 support for devicemanager (refs #3264) 2016-05-17 22:56:16 +03:00
Valeriy cbc7092ed9 fix code style 2016-05-17 14:47:02 +03:00
Valeriy 806e689d1d replace foreach with range-based for 2016-05-11 19:00:30 +03:00
Valeriy 948140fab5 disconnect GVolumeMonitor signals from GioLister before destroying it
fixes #5369
2016-05-11 17:58:12 +03:00
Chocobozzz ff7026c9fe Merge remote-tracking branch 'upstream/master' into qt5 2015-12-13 20:05:12 +01:00
John Maguire f300946c81 Remove most usages of QFutureWatcher 2015-11-27 14:28:12 +00:00
narunlifescience dd953fd86c check custom icon location, then system theme & then fallback theme
icons added & replaced
2015-10-13 22:35:49 -05:00
Chocobozzz 42aafd247a Update optional components to qt5 2015-04-15 18:26:09 +02:00
Chocobozzz 8b226c2171 Update non optionnals sources to qt5 2015-04-11 23:24:07 +02:00
Chocobozzz 8fba1c30f4 Make format 2014-11-05 13:05:58 +01:00
Chocobozzz da99c55eed Use constructor for QString 2014-11-05 12:25:55 +01:00
Chocobozzz 2e64b24290 Revert "Use constructor for QString and make format"
This reverts commit 5a2348fae6.
2014-11-05 12:25:09 +01:00
Chocobozzz 5a2348fae6 Use constructor for QString and make format 2014-11-05 11:51:38 +01:00
Chocobozzz 942fda88bf Check if there is a current icon item in the device manager. Fixes #4604 #4555 2014-11-04 21:46:10 +01:00
Arnaud Bienner 7ac9e4c6d1 Fix a bug in InsertItems functions that makes Cdda tracks to not be saved/restored correctly when restarting Clementine 2014-10-26 17:08:12 +01:00
Arnaud Bienner 5a7c462fc3 Remove useless includes 2014-10-26 03:37:17 +01:00
Arnaud Bienner dc0d3436c8 Finish CD integration update to Gstreamer 1.0
Move everything related to CDDA to a seperate class, so we can more easily reuse it in SongLoader
2014-10-26 03:32:37 +01:00
Arnaud Bienner a8266173c5 Start to reactivate audio CD support 2014-10-26 00:28:03 +02:00
David Sansome 39d99247a2 gstreamer-cdda is in gst-plugins-base in 1.0 and has a different header name.
This still doesn't work because the API has changed and track listings are
now delivered via a bus message instead of direct access to the struct's
members.
2014-09-22 22:28:53 +10:00
Mattias Andersson 0be0498e94 Reset the model during init of CddaDevice
This ensures that the track list in the device tab is correctly updated when a
disc is replaced with one that doesn't exist in the MusicBrainz database.
2014-05-24 13:54:07 +02:00
John Maguire 5146bcdebc Some more NULL -> nullptr conversions. 2014-02-21 17:30:46 +01:00
John Maguire 192b60d965 Use nullptr as parent parameter default everywhere 2014-02-10 16:03:54 +01:00
John Maguire 3323c2d094 Convert all instances of foreach() to a C++11 for
find ext src -name '*.cpp' -exec \
    sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
Krzysztof A. Sobiecki 0ecf1e76a6 Reformat done with clang-3.5 svn200967 2014-02-07 17:08:31 +01:00
John Maguire bebd781fdf Reformat all non-3rd-party C/C++/Objective-C++.
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
 -style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
John Maguire 71893e4847 Use nullptr instead of NULL everywhere. 2014-02-06 17:29:59 +01:00
John Maguire d309d4ab27 Use c++11 instead of boost where possible. 2014-02-06 16:51:39 +01:00
John Maguire b96ec7555a Reformat all Objective-C++ files with clang-format.
clang-format -style=Google -i src/*/*.mm
2014-01-30 14:54:51 +01:00
David Sansome 8416188056 Show a message in the Devices pane on Windows to say that most devices won't work. Fixes #4059 2014-01-05 11:32:07 +11:00
John Maguire 95330a3d7c Deal more gracefully with a device's library not having any directories on second mount.
Fixes issue #3940
2013-11-04 18:44:07 +01:00
John Maguire a650ac91bd Don't probe stupid printers on OS X. 2013-07-09 12:03:01 +02:00
David Sansome eb20fb5945 Remove all the soruce for WMDM devices. Fixes issue 3748 2013-06-30 08:25:12 +00:00
John Maguire 3d434f1c88 Remove iDevice support as it doesn't work well for modern devices and libgpod shows no signs of updating to support them.
Fixes issue #3683
2013-05-17 15:30:56 +02:00
David Sansome d89954ae31 Fix style, hide the new columns by default, and move the new columns to the end of the enum 2013-03-10 18:16:14 +11:00
Uwe Klotz a6d3b48231 Extend tag support: performer, grouping
The transaction handling while upgrading the database schema had to be revised.
Furthermore some QSqlQuery statements needed to be finished properly.

Fixes issue 2556
2013-03-10 18:16:03 +11:00
John Maguire 42e7e4ff6f Use boost::bind in DeviceManager. 2012-11-21 17:21:20 +01:00
John Maguire 80d35ef128 Merge remote branch 'origin/mingw-w64' 2012-11-19 18:17:19 +01:00
Arnaud Bienner e9c98733b3 Also update song count when tags are loaded: I don't know why but there not updated in Init 2012-11-18 22:14:06 +01:00
Arnaud Bienner fb07308607 Slightly modify the way CddaLister::Init worksr: as cdio_get_devices sometimes return only symlinks, we should not ignore them. 2012-11-18 22:05:18 +01:00
John Maguire 8501ac0d96 Do WMDM static init in main() to avoid static mutex. 2012-11-15 22:08:04 +00:00
John Maguire 543a6bf2fa Remove use of linked SAC shim and depend on DLL version (which doesn't exist yet) 2012-11-13 17:04:54 +01:00
John Maguire 79318cc4e1 Build fixes for mingw-w64 2012-11-13 14:43:13 +01:00
Veniamin Gvozdikov e6e72dc68d Change the include order to fix a build error on FreeBSD.
Fixes issue 3247
2012-10-31 10:45:18 -07:00
John Maguire 896a8739e9 Maybe fix mac build. 2012-09-26 18:12:14 +02:00
John Maguire 5ddabb4b76 Remove use of functions deprecated in Mountain Lion. 2012-09-13 16:24:45 +02:00
Arnaud Bienner 0e3dc5a8be Add new ConcurrentRun templates for void functions, and functions with 3 arguments + corresponding test cases.
+ SongLoader now has its own QThreadPool to load folders/playlist in background.
Update issue 2598
This should fix slowliness problems reported.
2012-07-16 00:06:55 +02:00
John Maguire 905ef90882 Add missing header. 2012-06-29 17:06:47 +02:00
John Maguire 20b11961f9 Set the max size of the DeviceManager thread pool to 1. 2012-06-29 16:58:30 +02:00
John Maguire 58a3a6831a Move loading of devices from the database onto a different thread. 2012-06-29 16:56:17 +02:00
John Maguire cbc650f44b Use CHECKED_GCONNECT instead of g_signal_connect everywhere. 2012-06-08 15:34:00 +02:00
Patrick Stewart fd35ce8b5d When listing devicekit devices, include drives that only contain a single partition (with no partition table).
Fixes issue 1508
2012-06-05 18:42:11 +01:00
John Maguire c62e996607 Fix come compile warnings from Clang 3.1 2012-06-04 17:44:01 +02:00
David Sansome 5d4844acdd Add copyright headers to ilister.{cpp,h} 2012-03-27 21:31:20 +01:00
David Sansome 119c9c27ac Detect libimobiledevice 1.1.2 and use its new "udid" field instead of "uuid". 2012-03-27 21:24:38 +01:00
David Sansome 526a9d9960 Fix compilation of the WMDM device lister on windows 2012-02-26 16:00:00 +00:00
David Sansome ab5ccf69da Refactoring: remove BackgroundThread 2012-02-26 15:05:46 +00:00
David Sansome bacef04405 Refactoring: remove a couple of the AlbumCoverLoader instances and instead use a shared CurrentArtLoader. 2012-02-26 14:40:51 +00:00
David Sansome 48f15c9fc7 Refactoring: instead of passing individual pointers to useful core classes (like TaskManager or LibraryBackend) to each class that uses them, pass one singleton-like Application instance everywhere. 2012-02-26 14:40:51 +00:00
David Sansome 10af3fef37 Maybe fix a string concatenation crash on startup on OS X. 2012-02-21 12:10:25 +00:00
John Maguire 3e65d3d5f0 Add ScopedNSAutoreleasePool from Chromium. 2012-01-31 13:54:03 +01:00
John Maguire b86be65ea1 Add ScopedIOObject. 2012-01-23 18:12:51 -08:00
Руслан Ижбулатов 5c45e22e28 Make SAC and WMDM optional 2012-01-22 14:35:22 +00:00
John Maguire ab33d9aa8c Fix a bunch of small memory leaks in the mac device handling code. 2012-01-20 16:25:05 -08:00
John Maguire 028ac3126c Use scoped_nsobject & ScopedCFTypeRef in a load of places. 2012-01-20 16:06:56 -08:00
John Maguire fddde512c9 Update old logging statements. 2012-01-20 15:22:14 -08:00
David Sansome e9c0b4bd69 Musicbrainz tagging improvements:
* Fix a bug where the song title would be used for the album field
  * Get the album's year as well
  * Include all releases for a song in the results list
  * Remove duplicate albums
  * Sort results
2012-01-07 21:51:02 +00:00
David Sansome b873209d39 Remove the <xiphcomment.h> include from song.h so that windows headers don't infect everything else. Also move other bits of song.h into song.cpp, and reduce the number of includes in song.h. 2011-11-28 13:56:55 +00:00
John Maguire 177c658366 Fix CF handle leak. 2011-11-21 16:33:01 +01:00
John Maguire b74c735268 Don't probe USB hubs and HID devices on Mac as some of them don't like it.
Update issue #981
Hopefully this fixes it.
2011-11-21 15:16:24 +01:00
John Maguire 9c6964da2c Remove another deprecated glib function call. 2011-10-26 12:06:51 +02:00
John Maguire 01f3f5c5ea Stop using deprecated glib eject functions. 2011-10-26 11:51:11 +02:00
John Maguire 309634bc18 Blacklist eLicenser copy protection dongle from Mac MTP probing.
Fixes issue #2232
2011-09-15 17:42:03 +02:00
John Maguire e1f66960f8 Swap vendor id and product id for ilok2.
Update issue #2226
D'oh, fixed.
2011-09-13 16:39:40 +02:00
John Maguire 17adb2bd6d Blacklist ilok2 device from Mac MTP detection.
Update issue #2226
Hopefully this will fix it.
2011-09-13 15:57:13 +02:00
David Sansome 143bbb4019 Make the BusyIndicator contain a label too 2011-08-27 15:03:04 +01:00
Arnaud Bienner 5841bb58a7 Correct typo in comment 2011-08-19 22:31:48 +02:00
Arnaud Bienner f33b62a877 Oops... Actually, it's better like this :) 2011-08-18 22:10:09 +02:00
Arnaud Bienner 299f15b7ee Allow GIO to handle CD devices if libcdio isn't installed 2011-08-18 21:41:14 +02:00
Arnaud Bienner 91537777c8 Ignore cdda devices detected via gio ealier, to avoid crash when getting device's filesystem info. This seems to happen because both giolister and cddadevice try to access to the device at the same time 2011-08-18 21:34:45 +02:00
Arnaud Bienner 419447e192 Reset song count during init 2011-08-18 20:23:11 +02:00
John Maguire 8ad150bd6b Don't detect CD devices on Mac when we can't use them and fix an iokit
device leak.
2011-08-15 18:13:05 +02:00
John Maguire 56a4d6b743 Fix double unref on cdda element. 2011-08-15 18:08:09 +02:00
John Maguire 50824cafe9 Make AskForScan() per-device rather than per device lister and fix cddadevice to use the url rather than the unique id. 2011-08-11 22:10:14 +02:00
John Maguire b458c9d24c Merge branch 'master' of https://code.google.com/p/clementine-player
Conflicts:
	src/devices/devicemanager.cpp
2011-08-11 21:46:48 +02:00
John Maguire 75a53d0b36 Detect CD removal on mac. 2011-08-11 21:43:00 +02:00
John Maguire 47a171fca7 Detect cd insertion on mac. 2011-08-11 21:37:09 +02:00
Arnaud Bienner 4509757233 We cannot change CD device's content: return false for those methods. This will display an error message, more explicit than doing nothing without any warning 2011-08-11 01:16:08 +02:00