1
0
mirror of https://github.com/clementine-player/Clementine synced 2025-02-02 20:36:44 +01:00

58 Commits

Author SHA1 Message Date
Eoin O'Neill
e2f63e3945 Implemented SPC playback functionality.
Would like to add more playback support for additional GME supported file types. GME is already supported by the GStreamer backend.
2018-06-16 10:06:37 +01:00
Jonas Kvinge
37912a87b8 Fix WavPack playback (#6048) 2018-05-01 18:29:47 +01:00
Ilya Selyuminov
1a477201ed Use CaseInsensitive file type checking #5499 (#5592)
* Fix Seafile setting page loading

Check access_token instead of QSetting parameters to make
sure that we're logged in.

* Use CaseInsensitive file type checking  (#5499)

CloudFileService and TagReader classes use
QString::endWith() method for checking file type.
This method is CaseSensitive by default.
2017-01-12 15:58:44 +00:00
Hugues Morisset
fa7bcff43d Fix undefined symbol error conversion from std::string to TagLib::String
Taglib version 1.9.1-2.4 on debian
2016-10-10 12:49:49 +01:00
Jan Suchomel
622a3e478a Add support for displaying lyrics from a Vorbis comment (#5495)
* Added support for displaying lyrics from Vorbis Comments.

* Fixed style issues
2016-09-18 13:23:39 +01:00
beedaddy
126ed1a551 Fix fetching cover art for taglib >= 1.11 (#5434) 2016-07-12 11:39:25 +01:00
David Sansome
170c64cd8b Link statically to libprotobuf from the spotifyblob 2015-12-14 00:02:07 +11:00
Martin Babutzka
bd3b953b08 Softened the metadata-editor behavior to not deliberately delete additional, valid frames which are stored in mp3-files.
Stashed commit of the following:

e54bcd2f058d186c2c919a84152ed5e8526047fc
Fixed bugs/comments from John Maguire

01c71c4c67be44dd6889498abc323a6d2d20dd99
Added description "Clementine editor" to new created lyrics frames.

70dfa0d1f177523ff897985ae022979cd052a6ed
Updated the SetTextFrame method as well:
Existing frames are cached and only the first frame (which is actually shown in the metadata editor) will be updated.
Prevents the cruel deletion of all other existing frames in a well defined mp3-file.

dfddf76eda417442c8c168eb8868038b0675cb10
Updated behavior of metadata-editor concerning lyrics (might follow for other id3v2-tag properties):
Existing further frames in the tags are not deleted but cached so only the true changes by the metadata-editor are applied on the edited frame.
Further frames in the metadata are preserved.
2015-07-27 22:52:29 +02:00
Eduardo Sánchez Muñoz
ef1992570b Define some original year tag keys as constants and enclose some if bodies with {}. 2015-07-01 15:02:52 +02:00
Eduardo Sánchez Muñoz
8dd4506697 Add support for more original year tags. 2015-07-01 00:50:19 +02:00
Eduardo Sánchez Muñoz
c46fb5eec7 Code formatting fixes 2015-06-30 19:51:01 +02:00
Eduardo Sánchez Muñoz
e0816800b1 Add support for original year tags. 2015-06-30 18:34:34 +02:00
Martin Babutzka
0b16dad50f - Fixed decoding of non-ASCII lyric texts
- Lyrics can now be viewed/edited in the metadata-editor

Squashed commit of the following:

commit 0851f619c27348e3ceeaf31a8edc3a567ccee99c
Author: Martin Babutzka <martin.babutzka@online.de>
Date:   Wed Jun 10 21:21:50 2015 +0200

    'make format' and brackets in a condition clause.

commit bab7a1d07af3bc53034e3883d352ae6d4dd33e2a
Author: Martin Babutzka <martin.babutzka@online.de>
Date:   Sun Jun 7 01:51:31 2015 +0200

    Added capability to SAVE lyrics frames to mp3 files in tagreader.
    Improved scaling properties of edittags dialog.

commit 4bd71a2d6a4479a664bf8b5b3ead05c23c86e15d
Author: Martin Babutzka <martin.babutzka@online.de>
Date:   Sat Jun 6 23:33:22 2015 +0200

    Updated lyrics tag buddy to lyrics

commit 2ceb8967f67e76a0f78b25a7a128c4429a93bcd9
Author: Martin Babutzka <martin.babutzka@online.de>
Date:   Sun May 17 18:52:33 2015 +0200

    Add lyrics field to tag editor

commit 04b65e33a83e449055659a72a283954311a12fb7
Author: Martin Babutzka <martin.babutzka@online.de>
Date:   Fri May 8 23:24:02 2015 +0200

    Using decode method to fix non-ASCII letters.
2015-06-10 21:23:40 +02:00
Chocobozzz
60a8ae5880 Fix setting album artist tag for FLAC files if it already exists 2015-05-09 21:13:39 +02:00
Martin Babutzka
258ae281d8 IDv3 tag lyrics support.
Squashed the following commits:

5c723ad commit: Fix: Includes alpha sort
15ac350 commit: Fix: Updated Database::kSchemaVersion to 49.
767a26a commit: Fixed small code style issue. Added schema-49 to data.qrc instead schema-48
bf6aa64 commit: fixup! Modified async handling of CollapsibleInfoPane as recommended by Andreas. Display of IDv2 tag lyrics works now.
c1f97e9 commit: fixup! Added support to read/display the ID tag lyrics in MP3 files:
c946b1d commit: Added support to read/display the ID tag lyrics in MP3 files:

-Added schema to the database to store it
-Added readers/writers for ID tags
-Added readers/writers for the database to the song class
-Added the taglyricsinfoprovider to show the lyrics in songinfo
2015-04-10 21:05:07 +02:00
Chocobozzz
071be6bc83 Make format 2015-02-21 16:57:37 +01:00
Chocobozzz
fb5781eee2 Add performer tag support for mpeg 2015-02-21 16:49:00 +01:00
Chocobozzz
c61d866caf Fix album artist for FLAC/OGG files (with vorbis comments) 2015-01-16 18:30:11 +01:00
Arnaud Bienner
f2eecadbd3 Don't write rating if not set
Fixes issue #4128
2014-10-21 21:49:23 +02:00
Chocobozzz
ef6dd38d0d use unique_ptr instead 2014-06-05 17:42:55 +02:00
Chocobozzz
2595df9779 Change the comment for TagLib::MPEG:File 2014-06-05 15:48:20 +02:00
Chocobozzz
357a9ff194 Fix memory leak in tagreader 2014-06-05 15:47:14 +02:00
David Sansome
0bf911aec4 Clean up the stream if ownership isn't taken by a taglib file. 2014-06-05 20:20:57 +10:00
John Maguire
30d1c2f8db Remove Ubuntu One support.
http://blog.canonical.com/2014/04/02/shutting-down-ubuntu-one-file-services/
2014-04-02 16:02:00 +02:00
John Maguire
3323c2d094 Convert all instances of foreach() to a C++11 for
find ext src -name '*.cpp' -exec \
    sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
John Maguire
bebd781fdf Reformat all non-3rd-party C/C++/Objective-C++.
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
 -style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
John Maguire
71893e4847 Use nullptr instead of NULL everywhere. 2014-02-06 17:29:59 +01:00
John Maguire
d309d4ab27 Use c++11 instead of boost where possible. 2014-02-06 16:51:39 +01:00
Martin Brodbeck
b5eb77528b Don't use TPE1 for performer 2013-12-19 14:03:23 +01:00
Martin Brodbeck
a8ae737bce Improved file type detection for Ogg/Opus 2013-12-16 13:45:25 +01:00
Martin Brodbeck
587fa39dad Improved embedded cover handling for Ogg METADATA_BLOCK_PICTURE 2013-12-11 14:30:27 +01:00
Martin Brodbeck
818a028739 Added rudimentary support for METADATA_BLOCK_PICTURE tag 2013-12-10 15:39:43 +01:00
Arnaud Bienner
8ddba1dfb5 Make ConvertPOPMRating works with slightly different POPM rating scheme for 5 stars. Fix issue 3794. 2013-08-02 22:13:29 +02:00
Arnaud Bienner
c32408eded Fix ConvertToPOPMRating 2013-08-02 22:09:46 +02:00
Arnaud Bienner
88918d45c5 Update issue 1175:
Save rating and statistics in two distinct ways, and let users activate them separately in preferences.
2013-03-30 23:42:29 +01:00
John Maguire
a459eff0d3 Support audio/x-flac as a mime type for FLAC files. 2013-03-21 14:03:41 +01:00
Arnaud Bienner
8450a9ded0 Try to fix Windows build 2013-03-18 23:41:01 +01:00
Arnaud Bienner
77c6a22962 Write/Read score to/from files' tags, as "Amarok score" as we use the same algorithm 2013-03-15 22:54:59 +01:00
Uwe Klotz
a6d3b48231 Extend tag support: performer, grouping
The transaction handling while upgrading the database schema had to be revised.
Furthermore some QSqlQuery statements needed to be finished properly.

Fixes issue 2556
2013-03-10 18:16:03 +11:00
Arnaud Bienner
1abadaf8fd Use constants 2013-03-03 00:49:51 +01:00
Arnaud Bienner
0b6e91daea FMPS support for MP4 files 2013-03-03 00:18:59 +01:00
Arnaud Bienner
f04923210d FMPS support for ASF files 2013-03-02 23:54:54 +01:00
Arnaud Bienner
b0d643cbd9 Save/read FMPS tags to/from FLAC using Vorbis comments + some refactoring to parse VorbisComments in a unique place, when possible. 2013-03-02 00:03:51 +01:00
Arnaud Bienner
1386a54d78 Read/Write FMPS tags for Ogg files 2013-02-28 20:55:21 +01:00
Arnaud Bienner
16793744c0 Read and write POPM tags 2013-02-28 02:17:15 +01:00
Arnaud Bienner
08d40f5fca Handle statistics tags apart, and write them to file when they change.
Next step: add a preference to activate this (should be deactivated by default IMO).
2013-02-24 17:45:25 +01:00
Arnaud Bienner
39e1275980 Write FMPS metadata (rating, playcount) to MP3 files in tagreader + corresponding test cases 2013-02-23 20:12:17 +01:00
Arnaud Bienner
3fb041ff03 Ooops... I forgot tagreader files :/ 2013-02-23 00:02:02 +01:00
Arnaud Bienner
47c9153fe2 Move everything about reading/writing tags from tagreaderworker to a new tagreader class.
Re-activate Song tests.
2013-02-22 23:57:31 +01:00
Martin Brodbeck
d05041dfa1 Add support for Opus tags. 2013-01-26 11:18:24 +00:00