faaa75cb61
Few style fixes + avoid unneeded copies
2014-02-12 22:11:28 +01:00
192b60d965
Use nullptr as parent parameter default everywhere
2014-02-10 16:03:54 +01:00
3323c2d094
Convert all instances of foreach() to a C++11 for
...
find ext src -name '*.cpp' -exec \
sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
0ecf1e76a6
Reformat done with clang-3.5 svn200967
2014-02-07 17:08:31 +01:00
bebd781fdf
Reformat all non-3rd-party C/C++/Objective-C++.
...
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
-style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
71893e4847
Use nullptr instead of NULL everywhere.
2014-02-06 17:29:59 +01:00
d309d4ab27
Use c++11 instead of boost where possible.
2014-02-06 16:51:39 +01:00
b96ec7555a
Reformat all Objective-C++ files with clang-format.
...
clang-format -style=Google -i src/*/*.mm
2014-01-30 14:54:51 +01:00
7a9e5b553b
Set a lower minimum column size in the playlist again. Fixes #201
2014-01-20 22:08:43 +11:00
cfb8fc8fbc
Merge pull request #4125 from Fitoschido/patch-1
...
Remove font customizations. Fixes #4082
2014-01-20 02:22:43 -08:00
a700bea095
Revert "Set padding-right correctly instead of moving the clear icon"
...
This reverts commit 5c05745985
2014-01-18 00:23:07 +01:00
b2f16b316e
Revert "Oops"
...
This reverts commit b716f802f3
2014-01-18 00:22:46 +01:00
9642896af6
Remove font customizations
...
* Should respect whatever font the user has set.
(“Respect the user’s settings by always using the system font, sizes, and colors.” http://msdn.microsoft.com/en-us/library/windows/desktop/aa511282.aspx )
* Courier looks odd and thin (a11y issue #4082 ).
2014-01-17 11:44:08 -06:00
bf35df140a
Merge pull request #4094 from Tatsh/playback-counter-font
...
Revert "Update playback counter font."
2014-01-17 05:01:30 -08:00
b716f802f3
Oops
2014-01-12 21:00:41 +01:00
5c05745985
Set padding-right correctly instead of moving the clear icon
2014-01-12 20:50:03 +01:00
3838bd7bd7
Change a bit the LTR logic (move the clear button also when editing/removing the text
2014-01-12 17:40:28 +01:00
7c1dc5d6cf
Merge pull request #4102 from Tatsh/fix-edittagdialog-rtl
...
In the tag editor, make the reset button appear on the left side for RTL
Fixes #2673
2014-01-11 22:39:24 -08:00
773258af99
Both cases move the clear button to the same position
2014-01-11 12:56:39 -08:00
a11270f749
Use isEmpty() instead of length()
2014-01-11 12:48:52 -08:00
f201a9925b
Remove trailing semicolon
2014-01-11 05:13:28 -08:00
59f033a583
Make is_rtl()/set_rtl() methods private
2014-01-11 04:01:08 -08:00
fecdae0be3
Add mp2 to the list of extensions shown in the files tab. Fixes #4103
2014-01-11 22:47:35 +11:00
71aeda07f7
Formatting
2014-01-11 03:46:15 -08:00
d46e0bacc6
Test for string length
2014-01-11 03:45:45 -08:00
509a6af788
In the tag editor, make the reset button appear on the left side for RTL text; #2673
2014-01-11 00:45:13 -08:00
d48ec046a6
Revert "Update playback counter font."
...
This reverts commit 55b0d00e02
2014-01-09 21:16:35 -08:00
55b0d00e02
Update playback counter font.
...
Fixes #4082
2014-01-09 15:41:51 +01:00
b0e6062a4a
Fix comments and reduce translator's burden.
2014-01-07 11:44:19 +01:00
4cb3775366
Show an OSD notification when 'Stop after this track' is toggled
2014-01-06 14:25:04 +01:00
98ad9dbda6
Add possibility to download album covers automatically when playing a track without one. To activate: right click on now playing widget and select "Search automatically".
2013-12-30 23:50:57 +01:00
00fd9b4724
Androids like kittens, too
2013-12-22 15:16:42 +01:00
9bf5690671
Use mouseReleaseEvent instead of mousePressEvent
...
Now, tabbar's mouseReleaseEvent will not be executed if we did something. This prevents middle-click to unstar a playlist, then remove it, with the same click.
Should prevent users to accidentaly loose their playlists.
2013-07-27 19:17:09 +02:00
ff71138079
Change file deletion question dialogs to warnings.
2013-06-01 16:23:37 +10:00
94a70d61b9
Save playlist' id instead of tab's id in favorite widget, so we don't have to update it when tab are moved
2013-05-12 23:36:32 +02:00
5e6821dead
Add a 'favorite' widget to playlist tab, and keep in playlistlist container only favorite playlists, instead of all playlists.
2013-05-11 23:18:03 +02:00
dac22dbd72
Explicitly cast scoped_ptrs to bool. Fixes issue 3570.
2013-04-15 21:41:54 +10:00
bc5aa4055c
Show a tooltip for sidebar tabs: only when needed for large side bar, always in the other cases, as I guess text will be elided most of the time.
...
Update issue 1202
This work around this issue a bit.
2013-04-01 17:54:33 +02:00
2081c30893
Revert "Show tooltips in the sidebar only in Tabs and IconsOnly modes"
...
This reverts commit 2dd2b615ef
2013-04-01 16:48:21 +02:00
a6d3b48231
Extend tag support: performer, grouping
...
The transaction handling while upgrading the database schema had to be revised.
Furthermore some QSqlQuery statements needed to be finished properly.
Fixes issue 2556
2013-03-10 18:16:03 +11:00
7f2c17a0b7
Add track rating/score to OSD.
...
Fixes issue #2586
2013-02-26 16:33:05 +01:00
9e70fdf0c3
Add .mka to file extensions.
...
Fixes issue #2569
2013-02-06 17:27:13 +01:00
ba8d382101
Add .oga to file extensions.
...
Fixes issue #3180
2013-02-06 17:03:11 +01:00
d05041dfa1
Add support for Opus tags.
2013-01-26 11:18:24 +00:00
351a49e2b4
Elide the fancy sidebar text on the right instead of in the middle. Fixes issue 3335.
2012-12-25 13:10:10 +11:00
340e6dabce
Use notification center on OS X when available.
2012-09-13 16:15:28 +02:00
0a4b6aec5c
Fix a crash on exit when gnome accessibility bits are enabled.
2012-07-17 18:52:12 +01:00
df25f6291f
On Windows, don't activate the pretty OSD when it is first shown and
...
don't show it in the taskbar.
2012-07-15 14:46:00 +01:00
ed5b1d787b
Remove the tooltip flag on the pretty OSD on Windows, to remove the
...
drop-shadow that was added to tooltip windows in Qt 4.8
(QTBUG-13276). Fixes issue 3017.
2012-07-15 13:23:14 +01:00
6b87318710
Revert "Typedef QSearchField to old LineEdit on non Mac, and make it compatible with QSearchField"
...
This reverts commit 59517f5b4e
2012-07-12 14:04:29 +02:00
59517f5b4e
Typedef QSearchField to old LineEdit on non Mac, and make it compatible with QSearchField
...
Fixes issue 3047. (for now)
2012-07-10 00:44:05 +02:00
c57f58862f
Forward some events from QSearchField's internal lineEdit to QSearchField, so we can be aware of some events (like getting/losing focus).
...
Implemented for non-mac; something certainly still needs to be done for Mac
2012-07-02 00:49:37 +02:00
124d4e6a59
Always display "did you mean" widget in top of all windows.
...
Also, update its width to the text it should displayed
2012-07-01 23:55:54 +02:00
20d740f385
Port global search & album cover search to QSearchField and remove MacLineEdit.
2012-06-28 11:40:13 +02:00
c62e996607
Fix come compile warnings from Clang 3.1
2012-06-04 17:44:01 +02:00
abdc6d8844
Add moodbar settings to the settings dialog
2012-05-27 23:56:40 +01:00
b03563f317
Make it possible to compile out moodbar support
2012-05-27 21:33:05 +01:00
e3cfd64764
Render the moodbar data in the slider widget, and write .mood files alongside music files.
2012-05-25 22:02:10 +01:00
d34c6e6475
Fix pretty OSD transparency
...
With certain widget styles (such as Bespin), the pretty OSD’s background
would not be fully transparent. Fix this by setting the widget’s
background color to “transparent”.
Fixes issue #2907
2012-05-01 16:56:46 -07:00
eed3a57af8
Show thumbnails of album art in the tray icon tooltip instead of full sized images. Fixes issue 2844
2012-04-13 14:28:09 +01:00
77789aba41
Use 16x16 icons in the file view instead of 22x22. Fixes issue 2852
2012-04-13 14:19:06 +01:00
29cfe20160
Use QPalette::HighlightedText instead QPalette::Text for track slider popup so slider's text color really contrast with slider's background color.
...
Fixes issue 1757.
2012-03-20 23:00:37 +01:00
627ae372d4
Better check resizeEvent' size. Otherwise, the nowplayingwidget isn't always resized (even if it should), particulary at startup, when starting playing
2012-03-19 20:42:19 +01:00
69779374c2
Fix a funny fading bug in the podcast info widget that would occur because a ResizeEvent was being sent with oldSize() == size().
2012-03-12 21:12:01 +00:00
204f7acbfa
Merge branch 'podcasts'. Fixes issue 44
2012-03-12 19:40:31 +00:00
d819c88ff8
Fix crash on exit on Mac.
...
Fixes issue #2661
2012-03-12 18:11:10 +01:00
f16fc8867e
Allow podcasts to be added through the normal SongLoader mechanism (dragging to the playlist, on the commandline, "Add Stream", etc.)
2012-03-11 17:57:15 +00:00
c204dd31fb
Don't crash when double clicking in the Add Podcast dialog
2012-03-10 23:38:54 +00:00
1abf059d16
Add a Podcasts settings page and the start of some gpodder.net syncing
2012-03-09 15:26:38 +00:00
3a88d8fcda
Fade between podcast info screens a bit more nicely
2012-03-06 18:40:17 +00:00
bacef04405
Refactoring: remove a couple of the AlbumCoverLoader instances and instead use a shared CurrentArtLoader.
2012-02-26 14:40:51 +00:00
48f15c9fc7
Refactoring: instead of passing individual pointers to useful core classes (like TaskManager or LibraryBackend) to each class that uses them, pass one singleton-like Application instance everywhere.
2012-02-26 14:40:51 +00:00
04805de5c6
Add %filename% as possible custom OSD variable. Fixes issue 2648
2012-02-02 19:31:15 +00:00
799c341dc5
Add .mka as well
2012-02-01 20:58:44 +00:00
3e65d3d5f0
Add ScopedNSAutoreleasePool from Chromium.
2012-01-31 13:54:03 +01:00
2cb61908a9
Add .ape and .wv files to the file view filter, and use this same list in the Open Music dialog. Fixes issue 2533
2012-01-29 20:10:00 +00:00
281d69581c
Add Edit file information and Show in file browser actions to the files view. Fixes issue 2559
2012-01-29 18:44:00 +00:00
bdf0ff4930
Make the "Loading" song info indicator and playlist queue/stop after indicators look nicer by aligning their QPainters properly
2012-01-07 23:52:31 +00:00
bfd725f2ed
Don't crash when adding new columns to a stretch header view.
...
Fixes issue 2562
2012-01-04 18:45:08 +00:00
1ef03b31f7
Set _NET_WM_WINDOW_TYPE_NOTIFICATION on the Pretty OSD window. Fixes issue 2485
2011-12-27 16:06:48 +00:00
edb9b0b4fe
Add album effective_artist filter that falls back to artist when unavailable (Issue 509)
2011-11-28 11:04:38 +00:00
d0f09d83a1
When a login fails, focus and select all the text in the password field so the user can start typing a new password straight away.
2011-11-27 17:54:36 +00:00
b8ee548eb4
Rename the existing "Shuffle by album" mode to "Shuffle tracks in this album", and add a new "Shuffle albums" mode that plays all the tracks in each album sequentially, but then jumps to a different random album afterwards.
...
Fixes issue 1152
2011-11-27 15:01:10 +00:00
7e5eb1c220
Fix Mac native widgets to at least show up on Qt 4.8.
2011-11-09 14:34:11 +01:00
7c5aaf36aa
Elide hint text in text boxes
2011-11-08 18:22:01 +00:00
1f0c2333d0
Show the di.fm/sky.fm "Expires on" date on a separate line
2011-11-05 21:46:34 +00:00
a2b95b7f54
Group pages in the settings dialog into categories
2011-10-30 16:51:43 +00:00
292610c20b
Allow toggling of individual global search providers.
2011-10-01 21:22:01 +01:00
02257d8b37
Adjust the global search widget's style a bit
2011-09-17 14:04:57 +01:00
13fc24f6c6
Refactor the last.fm, magnatune, spotify and di.fm settings pages - moving the login state display into a separate widget.
2011-08-27 22:01:28 +01:00
143bbb4019
Make the BusyIndicator contain a label too
2011-08-27 15:03:04 +01:00
263f57b47b
Only set the pretty OSD's message in the notifications settings page's constructor - don't show it as well. It would just get hidden again straight away, and for some reason this triggers a (Qt?) bug where the window gets painted in the top-left corner, but reacts to mouse clicks in its actual position.
...
Fixes issue 2110
2011-08-26 23:34:13 +01:00
3ded9f29d2
Fix compiling on ARM.
2011-08-01 22:37:53 +02:00
5c90404915
Sort album covers by image size. Fixes issue 2048
2011-07-26 12:17:28 +01:00
3eb9aee989
Save the state of the playlist column sort marker
...
Fixes issue 2098
2011-07-25 16:55:45 +01:00
f599c0fca7
Remember the playlist column stretch setting when changing it, and update the menu action's checked state properly when opening clementine.
2011-07-25 16:54:42 +01:00
30f68d6981
Store the floating point proportional playlist column widths directly instead of storing the integer pixel widths then recalculating the floating point values on startup, which would lead to floating point errors over time. Fixes a bug where columns would slowly change size the more times you opened and closed clementine.
2011-07-24 12:47:48 +01:00
38100f5e59
Make CoverProviders not a singleton
2011-07-23 19:34:41 +01:00
9fadf57acc
Revert "Move TaskManager::Task and UrlHandler::LoadResult structs out of their parent classes - PythonQt doesn't understand nested structs."
...
This reverts commit 5234798a7f
2011-07-23 15:32:12 +01:00
dd98f8abc8
Make the album cover search results list scroll by pixel instead of item, and re-layout the items when any data changes
2011-06-26 15:06:59 +00:00
Arnaud Bienner
John Maguire
Krzysztof A. Sobiecki
David Sansome
Adolfo Jayme Barrientos
Andrew Udvare
Mattias Andersson
Andreas
Mateusz Kowalczyk
Uwe Klotz
Martin Brodbeck
Martin Herkt
Martin Spacek
Alan Briolat
Angus Gratton
Nobuhiro Iwamatsu
David Sansome