Commit Graph

52 Commits

Author SHA1 Message Date
Mattias Andersson 4569bd9f2f Check for error when getting the number of cd tracks. Build an empty
track list table if this is the case.
2014-05-22 07:51:08 +02:00
Mattias Andersson 0c76ca3c45 Don't start ripping unless the user has selected some tracks. 2014-05-21 18:07:48 +02:00
Mattias Andersson 8bb19f1887 Save tags using async calls. 2014-05-21 16:36:46 +02:00
Mattias Andersson 7d4343a826 Give functions a more verbose name. 2014-05-18 14:39:21 +02:00
Mattias Andersson 2137ac4709 Keep working until tagging is complete. 2014-05-18 14:24:46 +02:00
Mattias Andersson 182c90ccf4 Run RipCD::TagFiles in a background thread. 2014-05-13 15:18:42 +02:00
Mattias Andersson 467a1443e4 Capture log messages from the transcoder. 2014-05-12 23:58:51 +02:00
Mattias Andersson 98fd82a371 Use the TagReaderClient to tag the files in the CD ripper instead of
using Taglib directly.
2014-05-12 23:57:11 +02:00
Mattias Andersson bbd83344b8 Initialise cancel_requested_ to false in the constructor's initialisation list. 2014-05-12 17:40:41 +02:00
Mattias Andersson 08f5af3320 Give the mutex lockers a tighter scope. 2014-05-12 17:24:35 +02:00
Mattias Andersson 919f7cbe94 Add a mutex to protect a variable shared between threads. 2014-05-12 16:14:33 +02:00
Mattias Andersson 6235e69ac4 Run 'make format' 2014-05-12 14:38:46 +02:00
Mattias Andersson be09f6e5c7 Merge branch 'master' into ripcd-cancel
Conflicts:
	src/ui/ripcd.cpp
2014-05-12 13:50:34 +02:00
John Maguire 5fe468456a Merge pull request #4171 from asiviero/master
Addressing #4165 and #4166
2014-05-12 13:20:26 +02:00
asiviero 4b7c3a2f8c Using scoped ptr to ripcd window, removing extra parenthesis again 2014-04-29 23:12:18 -03:00
Andre Siviero af34bf6062 Removing extra parenthesis 2014-04-16 11:07:50 -03:00
Mattias Andersson 773c3475ba Remove unnecessary string conversion. 2014-04-15 14:47:26 +02:00
Mattias Andersson 44025dc588 Add a call to cdio_get_media_changed in RipCD::CheckCDIOIsValid
This prevents an erroneous message that the media has changed the first
time the ripCD dialog is used.
2014-04-13 14:41:04 +02:00
Mattias Andersson 31400f2740 Run 'make format' 2014-04-12 09:20:25 +02:00
Mattias Andersson d66a73bed5 Merge remote-tracking branch 'origin/master' into HEAD
Conflicts:
	src/ui/mainwindow.cpp
	src/ui/ripcd.cpp
2014-04-12 09:08:21 +02:00
John Maguire 3323c2d094 Convert all instances of foreach() to a C++11 for
find ext src -name '*.cpp' -exec \
    sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
John Maguire bebd781fdf Reformat all non-3rd-party C/C++/Objective-C++.
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
 -style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
John Maguire 71893e4847 Use nullptr instead of NULL everywhere. 2014-02-06 17:29:59 +01:00
asiviero 9a0b149877 Removed unnecessary clear and switched to clearContents on cdio not available 2014-02-05 10:25:47 -02:00
asiviero 62d919c1b5 Fixing segfaults, checking for cd change on the fly 2014-02-04 23:29:39 -02:00
Mattias Andersson 1b00e91fdf Add the ability to cancel a running CD rip. 2014-02-04 16:25:58 +01:00
asiviero d88c1fad04 Reset progress bar after cancel is pressed 2014-02-03 23:59:23 -02:00
asiviero 4251fd4331 Checks for CD before opening window (addresses #4165) 2014-02-03 22:40:56 -02:00
Mattias Andersson 3bf44c78d4 Only remove the temporary directory if it has a non-empty name. 2014-02-03 15:14:08 +01:00
Mattias Andersson 4676e2839d Make the CD ripper clean up after itself. 2014-02-03 13:38:38 +01:00
Mattias Andersson c36e073921 Add trailing underscore to class member variable. 2014-01-29 20:35:03 +01:00
Mattias Andersson 333b1636fa Adjust column widths. 2014-01-27 00:13:33 +01:00
Mattias Andersson a31223e45c Group the input options in the rip cd dialog. Disable input and output groups when there is a ripping in progress. 2014-01-26 21:20:36 +01:00
Mattias Andersson 76a91ded88 Remove the 'Alongside the originals' destination in the CD rip dialog since it doesn't make sense in this context. Use the home directory as initial destination instead. 2014-01-26 21:20:19 +01:00
Mattias Andersson 27b1bf7014 Add buttons 'select all', 'select none' and 'invert selection' buttons to the rip cd dialog. 2014-01-26 21:20:19 +01:00
Mattias Andersson 96e6252fca Style the Rip cd dialog
Set a specific tab order in the dialog.
Add a Clementine window icon.
Add a header for the first column in the table widget.
Change the button box to a cancel and a close button and make these behave as in the transcoder dialog.
Move the rip button to the button box.
Hide the progress bar if no cd has been ripped.
2014-01-26 21:19:02 +01:00
asiviero 7cebf23bba Added ripcd to optional features, deleted ui_ripcd on destruction, added a warning in case cdio_open returns NULL 2014-01-22 01:45:55 -02:00
asiviero 2859d826ae Swapped non const reference for pointer, used qdata_stream writeRawData to write to file, removed unnecessary intializers 2014-01-20 23:38:36 -02:00
asiviero 97129ec3c0 Using QDataStream to write numbers to file, removed PutNum, turned pointers into objects, checking cdio_read_audio_sector return code 2014-01-16 03:05:24 -02:00
asiviero 457d240854 Using QByteArray and QFile instead of FILE and int16_t, adapting to code style corrections? 2014-01-15 03:00:41 -02:00
asiviero d2881aad4b Linting the code, using QDir::tempPath instead of "/tmp" 2014-01-13 23:41:41 -02:00
asiviero d014d1549d Minor fix in filename generated 2014-01-13 13:49:39 -02:00
asiviero a3f61bd612 Added format string to customize file names 2014-01-13 13:38:25 -02:00
asiviero a5021e656b UI integration, needs beautification
Incorporates the 'Select Destiny' feature from 062889b, fetches values provided by user to populate file tags, UI adjustments
2014-01-13 03:32:25 -02:00
asiviero d2a3f60c4b Ogg transcoding done, tagging prototyped, need UI integration 2014-01-11 03:02:11 -02:00
asiviero 74256ee5ff Updating file headers 2014-01-11 01:32:08 -02:00
asiviero 1733c412a1 Ogg transcoding working, found a bug on wav2mp3 transcoding, UI integration needed 2014-01-11 01:26:13 -02:00
asiviero 658767daea Started transcoding, troubles with queue system 2014-01-09 02:47:33 -02:00
asiviero ba59add835 Wav ripping working
Needs a proper file management, like including a folder selection widget, tag management (TagLib not doing well on WAV files) and audio converting to Ogg/MP3
2014-01-08 01:39:28 -02:00
asiviero 94715a440e Added a (commented) prototype to wav ripping using cdda and paranoia 2014-01-07 02:05:31 -02:00