Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity
7,499 Commits 23 Branches 533 Tags 239 MiB
Commit Graph

7499 Commits

Author SHA1 Message Date
Jim Broadus dbe67bf32b Fix closure timing hole. 
When a closure involves an ObjectHelper, a connection is made from the
receiver's destroyed signal and the helper object's deleteLater slot. Since
the signal between the sender and the helper object isn't disconnected until
either object is actually destroyed, this leaves a hole where the helper
holds a pointer to an invalid receiver object, but is still able to receive
the signal connected to its Invoke slot.

Instead of connecting the destroyed signal to deleteLater, connect it to a new
TearDown slot that immediately disconnects the signal then calls deleteLater.
 2020-01-11 00:53:35 -08:00
Clementine Buildbot a97080a809 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2020-01-08 10:45:49 +00:00
John Maguire 8cfbc5bad7
Merge pull request #6521 from jbroadus/handle-connect-error-from-dialog 
Properly handle connect errors when initiated from properties dialog.
 2020-01-08 10:42:55 +00:00
Jim Broadus 8a88a0a57e Properly handle connect errors when initiated from properties dialog. 
If connection fails when initiated from the device properties dialog, the
connected page is shown after the update formats worker thread completes.
 2020-01-07 23:20:04 -08:00
Jim Broadus 79b7e3fe13 Fix abort from Mtp loader thread. 
A commit in qt 5.7 changes a qWarning to a qFatal if a QThread is still running
when it's deleted. When we get the LoadFinished signal in MtpDevice, stop
the loader thread's event loop to avoid this situation.

See qtbase commit c8277b6e532
 2020-01-07 22:29:59 +00:00
Pavel Liavonau 3f4c788339 Fixed lastfm workflow with "now playing" and scrobbling feature 
(Maybe Issue #2672)
 2020-01-07 22:29:23 +00:00
Jim Broadus 39e75071bf Remove unhelpful debug message. 
Message contains no context and appears to be a remnant of a debug session.
 2020-01-05 16:51:11 -08:00
John Maguire 008c90ff29
Merge pull request #6516 from jonaski/sizeinbytes 
Use QImage::sizeInBytes() with Qt 5.10 and above
 2020-01-06 00:12:02 +00:00
John Maguire 57841cf947
Merge pull request #6515 from jonaski/child 
Replace QModelIndex::child() with QAbstractItemModel::index()
 2020-01-06 00:11:22 +00:00
John Maguire b45b6bace0
Merge pull request #6514 from jonaski/elapsedtimer 
Replace QTime with QElapsedTimer
 2020-01-05 18:40:36 +00:00
Jonas Kvinge e98c11fe64 Use QImage::sizeInBytes() with Qt 5.10 and above 2020-01-05 19:31:40 +01:00
Jonas Kvinge 6b50d5140d Fix formatting 2020-01-05 19:09:03 +01:00
Jonas Kvinge e63c1edbbf Fix formatting 2020-01-05 19:08:03 +01:00
Jonas Kvinge 341a4d1423 Replace QTime with QElapsedTimer 2020-01-05 19:01:54 +01:00
Jonas Kvinge 959a957a56 Replace QModelIndex::child() with QAbstractItemModel::index() 2020-01-05 18:37:27 +01:00
John Maguire 1bf40fee15
Merge pull request #6513 from clementine-player/revert-6497-gpodder-server 
Revert "Add an option to specify a gpodder server."
 2020-01-05 17:10:32 +00:00
John Maguire 0991209087
Revert "Add an option to specify a gpodder server." 2020-01-05 17:10:00 +00:00
John Maguire 41c103413c
Merge pull request #6497 from jbroadus/gpodder-server 
Add an option to specify a gpodder server.
 2020-01-05 15:27:08 +00:00
John Maguire 19389cace7
Merge pull request #6511 from jonaski/screen 
Use QWidget::screen() to fix compile with Qt 5.14
 2020-01-05 15:22:38 +00:00
John Maguire 400203cfa2
Merge pull request #6510 from jonaski/searchtermwidget 
Fix layouts with duplicate name in SmartPlaylistSearchTermWidget
 2020-01-05 15:22:15 +00:00
Clementine Buildbot 257e1be43d Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2020-01-05 15:16:39 +00:00
John Maguire 10e807dd7d
Merge pull request #6509 from jonaski/tolist 
Replace QSet::toList() with QSet::values()
 2020-01-05 15:13:33 +00:00
Jonas Kvinge 1b23417a93 Use QWidget::screen() to fix compile with Qt 5.14 2020-01-05 02:51:08 +01:00
John Maguire 63cd5d4918
Merge pull request #6508 from jonaski/qocoa 
Replace use of QtMac::toCGImageRef with QImage::toCGImage
 2020-01-05 01:14:57 +00:00
John Maguire 7d2c622d0f
Merge pull request #6507 from jonaski/sprintf 
Replace use of QString::sprintf with QString::asprintf
 2020-01-05 00:40:43 +00:00
John Maguire 2c960f12f7
Merge pull request #6504 from jonaski/seafile 
Initialize QObject in constructor and add explicit
 2020-01-05 00:39:28 +00:00
John Maguire a875c3b91f
Merge pull request #6506 from jonaski/styleoptionframe 
Replace use of QStyleOptionFrameV3
 2020-01-05 00:30:40 +00:00
John Maguire 5123d1dd37
Merge pull request #6505 from jonaski/fallthrough 
Add fallthrough comment where fallthrough is intended
 2020-01-05 00:30:24 +00:00
John Maguire cfa3ea0dca
Merge pull request #6503 from jonaski/darker 
Replace use of QColor::dark and QPalette::background
 2020-01-05 00:30:04 +00:00
John Maguire 94630bd58b
Merge pull request #6502 from jonaski/desktopwidget 
Replace all uses of QDesktopWidget with QScreen
 2020-01-05 00:29:33 +00:00
John Maguire a240818b6c
Merge pull request #6501 from jonaski/compilations 
Fix songs stuck in various artists
 2020-01-05 00:28:15 +00:00
John Maguire b10cc71c76
Merge pull request #6500 from jonaski/pixmapcache 
Remove pixmap cache and pending art when removing parent nodes instead
 2020-01-05 00:27:36 +00:00
John Maguire 98473157d9
Merge pull request #6499 from jonaski/macos-librarywatcher 
Fix macOS filesystem listener (library watcher)
 2020-01-05 00:26:57 +00:00
John Maguire b7dc883a13
Merge pull request #6498 from jonaski/cmake 
Add project to CMakeLists
 2020-01-05 00:26:09 +00:00
Jonas Kvinge 52180a7484 Fix layouts with duplicate name in SmartPlaylistSearchTermWidget 2020-01-05 01:15:58 +01:00
Jonas Kvinge 5eb32b33c1 Replace QSet::toList() with QSet::values() 2020-01-05 00:58:33 +01:00
Jonas Kvinge b4fc6d96bf Fix formatting 2020-01-05 00:48:51 +01:00
Jonas Kvinge 35a0beb8a8 Replace use of QtMac::toCGImageRef with QImage::toCGImage 2020-01-05 00:46:54 +01:00
Jonas Kvinge ddc8a5f010 Initialize QObject in constructor and add explicit 2020-01-05 00:21:04 +01:00
Jonas Kvinge 7f6e7f8b30 Fix formatting 2020-01-05 00:17:18 +01:00
Jonas Kvinge f81a3aa8d8 Replace use of QString::sprintf with QString::asprintf 2020-01-05 00:12:32 +01:00
Jonas Kvinge a70537b83f Replace use of QStyleOptionFrameV3 2020-01-04 23:40:12 +01:00
Jonas Kvinge 39cdb7fc3f Add fallthrough comment where fallthrough is intended 2020-01-04 23:29:19 +01:00
Jonas Kvinge 4c157a95dd Replace use of QPalette::background with QPalette::window 2020-01-04 23:01:02 +01:00
Jonas Kvinge 28bbb74c26 Replace use of QColor::dark with QColor::darker 2020-01-04 23:00:40 +01:00
Jonas Kvinge 9e3461f818 Fix formatting 2020-01-04 21:24:31 +01:00
Jonas Kvinge 6a8f70285f Replace all uses of QDesktopWidget with QScreen 2020-01-04 21:18:12 +01:00
Jonas Kvinge 39934dc302 Fix songs stuck in various artists 2020-01-04 18:27:42 +01:00
Jonas Kvinge 651965b905 Fix formatting 2020-01-04 18:12:44 +01:00
Jonas Kvinge 250b5ca0a6 Remove pixmap cache and pending art when removing parent nodes instead 2020-01-04 18:07:34 +01:00