1a3828e2c1
protobuf: Fix namespace conflict
...
Protobuf 3.15 adds a namespace alias for "pb" that conflicts with
Clementine's. Modify Clementine to use "cpb".
Patch provided by @ahesford
Reference: 5c028d6cf4/src/google/protobuf/port.h (L44)
2021-02-21 14:17:26 +00:00
341dc7326f
Reformat all C++
2020-09-22 14:56:06 +01:00
69b2a832db
Merge branch 'master' into qt5
2017-01-18 15:57:07 +01:00
3485bbe438
Workaround to spotify loading playlist issue ( #5593 )
2017-01-12 18:00:32 +00:00
43c98fd74e
Adapt spotify part to qt5
2015-06-13 23:01:52 +02:00
f34734443b
Remove pending playlist requests in SpotifyClient if sp_session_player_load failed as well.
2015-03-14 15:26:44 +01:00
55e5eab157
Fix Race-Condition in SpotifyClient that caused playback to break.
...
QList.removeAll calls the destructor for the elements in the list. This caused `req` to be initialized in `SpotifyClient::TryPlaybackAgain()`. Therefore, spotify method calls might crash because the pointers are invalid.
This commit moves the `pending_playback_requests_.removeAll` to the end of the method to ensure `req` is accessible all the time.
2015-03-13 14:12:19 +01:00
e1139e731f
run make format
2015-01-14 22:55:20 +01:00
7039c2a2bf
Spotify: add the ability to add/remove tracks to/from Starred playlist
2015-01-14 22:49:36 +01:00
7278e7c4d0
Add ability to get a link to share Spotify playlists
2014-12-27 18:05:04 +01:00
50b7b7d889
Make format after update to avoid conflicts
2014-10-15 21:57:57 +02:00
88a6300509
Completely revert the Spotify seeking stuff - it's hacky and I don't like
...
waiting 4 seconds to have my songs start. I'll reimplement it properly later.
Reverts commits 96387803cd160b151652
2014-10-14 19:33:03 +11:00
f81fa2d119
Add the ability to remove tracks from Spotify playlists
2014-09-28 02:00:32 +02:00
39db4dbefe
Add the ability to add a Spotify track to a Spotify playlist through context menu.
...
TODO: drag and drop (i.e. implement DropMimeData), update special playlist (Favorites), remove from playlist.
2014-09-22 22:40:21 +02:00
bb08a0f416
Fix misleading offset_bytes names
2014-09-22 00:13:00 +10:00
160b151652
Add seek ability to Spotify tracks.
...
This is functional but pretty hacky.
And, as noted in the comments, there is a small delay (depends, but usually several seconds) to have the seek taken into account. But IMHO it's better than nothing.
Fixes #2503
2014-09-14 02:15:58 +02:00
cbc6e5cf4d
Pause spotify track (issue 2503)
...
(patch slightly modified, not sure why it wasn't applied before: it looks good to me)
2014-09-06 19:21:23 +02:00
41e9c15248
Add arraysize macro from Chromium
2014-04-29 14:11:52 +02:00
3323c2d094
Convert all instances of foreach() to a C++11 for
...
find ext src -name '*.cpp' -exec \
sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
bebd781fdf
Reformat all non-3rd-party C/C++/Objective-C++.
...
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
-style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
71893e4847
Use nullptr instead of NULL everywhere.
2014-02-06 17:29:59 +01:00
215595bfdb
Support toplist browsing in spotify blob.
2012-06-12 15:34:23 +02:00
9dd4f31795
Use libspotify 12.1.45.
...
Fixes issue #2972
2012-06-07 12:35:24 +02:00
1c80cfbadb
Use libspotify 11.1.56
2012-03-27 22:01:37 +01:00
694ffe42df
Don't send messages to a handler in the time between its socket closing and its process ending. Fixes a race condition that would result in a tag loading operation never completing. Fixes issue 2616
2012-01-22 18:53:17 +00:00
3e0f252b34
Exit worker processes when their sockets are closed, and make sure the main app closes sockets when exiting - fixes a crash dialog on Windows.
2012-01-08 16:35:01 +00:00
bbf99fdd0b
Change Spotify to use the new MessageHandler, remove SpotifyMessageHandler
2012-01-08 15:10:11 +00:00
67c6dead5a
Rename SpotifyMessage to Message
2012-01-07 23:31:43 +00:00
68a379ef26
Use pb::spotify instead of spotify_pb for the protobuf namespace
2012-01-07 23:26:27 +00:00
9041117867
Move everything around in the source tree - static libraries and external binaries now go in "ext/". Add a generic worker pool.
2012-01-05 23:25:13 +00:00
Jim Broadus
John Maguire
Florian Bigard
Bigard Florian
Andreas
Arnaud Bienner
David Sansome
pie.or.paj
John Maguire