e122898187
unnecessary set_current_row(-1)
2015-05-20 16:50:13 +05:00
5cd39a74b5
Fix next song autoselection
2015-05-19 09:56:12 +05:00
50ff5f5b0e
Spelling
2015-05-18 13:03:44 -04:00
99dffe216c
Fix Last.fm scrobbling after seek
...
Fixes #4836
Last.fm defines a scrobble should be sent if:
-the track is longer than 30 seconds.
-the track has been played for at least half its duration, or for 4 minutes (whichever occurs earlier.)
Clementine has treated this as seconds from the start of the track, and if any seeking occurs, it nullifies the scrobble.
This IMO is incorrect. If I skip the first 10 seconds of a song, but listen to the rest (still meeting the time requirements),
I should still be able to scrobble the play. This change moves the scrobble point with every seek, requiring continuous playback
from any point that satisfies the time criteria.
2015-05-18 12:53:07 -04:00
a32f725c5f
Register QList<int> as a media type. Under windows, the connect doesn't work without it.
2015-04-29 17:14:37 +02:00
bb5a952e25
Re-read FMPS_Rating from file when changed
...
When the FMPS_Rating changes in a file, Clementine will now re-read it
and change the rating in the library database. This lets you modify
song ratings outside of Clementine and then load the new ratings into
Clementine. Previously Clementine would ignore changed ratings in a
file's metadata after a song had been scanned into the library.
2015-04-25 18:32:34 +02:00
11d2702841
Try fixing buildbot.
2015-04-10 22:59:35 +02:00
258ae281d8
IDv3 tag lyrics support.
...
Squashed the following commits:
5c723ad commit: Fix: Includes alpha sort
15ac350 commit: Fix: Updated Database::kSchemaVersion to 49.
767a26a commit: Fixed small code style issue. Added schema-49 to data.qrc instead schema-48
bf6aa64 commit: fixup! Modified async handling of CollapsibleInfoPane as recommended by Andreas. Display of IDv2 tag lyrics works now.
c1f97e9 commit: fixup! Added support to read/display the ID tag lyrics in MP3 files:
c946b1d commit: Added support to read/display the ID tag lyrics in MP3 files:
-Added schema to the database to store it
-Added readers/writers for ID tags
-Added readers/writers for the database to the song class
-Added the taglyricsinfoprovider to show the lyrics in songinfo
2015-04-10 21:05:07 +02:00
8d3fd00956
Amazon Cloud Drive support.
...
Squashed commit of the following:
commit 451a327fabb5f9aba077d93a33d75d8a6a288f5f
Author: John Maguire <john.maguire@gmail.com>
Date: Fri Mar 27 14:55:36 2015 +0100
Revert debug console changes.
commit 52f643c3dc524a837f56268b6da4881187204165
Author: John Maguire <john.maguire@gmail.com>
Date: Fri Mar 27 14:49:28 2015 +0100
Revert extra logging
commit 23645f9fea8153388f19fa9e27925947a405543c748d88d99325ec9c65f427c1a371733594af5be1
2015-03-27 14:56:08 +01:00
5b2e4419ae
Don't check AXAPIEnabled when initializing the shortcuts, fixes media keys not working on OS X.
...
Fixes issue #3958 .
2015-03-15 13:40:27 +01:00
705cdf11fc
Move ScopedNSAutoreleasePool to ext
2015-03-02 17:51:17 +01:00
946c0381d1
Don't set thread priority in LibraryWatcher constructor, as this is executed in the main thread.
...
Do it when thread actually starts (create a new Thread class for this purpose).
Fixes #4523 .
2015-02-28 16:44:32 +01:00
24b6fbf36c
Add ability to parse more of "innovative" datetime formats. close #4760
2015-02-27 02:11:53 +01:00
fb2b91c874
Remove some more obsolete os x version checks.
2015-02-18 18:03:46 +01:00
484db9d92b
Remove obsolete snow leopard check.
2015-02-18 17:29:07 +01:00
ce50cbe09f
Fix compile issue on Yosemite
2015-02-15 16:43:36 +01:00
43768d4af8
Small modifications to previous pull request:
...
- remove reference to iPod, as this is not iPod specific IMO
- make comment clearer
2015-01-19 15:01:33 +01:00
e4df00050d
Includes in alphabetical order, moved Player ReloadSettings() to Player init
2015-01-08 01:10:35 -02:00
1120f97844
Added iPod-like behavior to previous button
2015-01-06 02:36:08 -02:00
c4d150d3e0
Add m4b support, only for non-drm files
2014-12-25 01:12:15 +01:00
fa9ea6ec5f
Fix compilation with moved files in internet/
2014-12-18 23:35:21 +01:00
bf55bc08fb
Cherry pick make format changes
2014-12-14 12:23:04 +01:00
6cc72e2f5d
Fix a date parser for one podcasts
2014-12-14 12:13:05 +01:00
2d2783ab04
Fix copyright notices
2014-12-10 01:25:52 +01:00
970e86aac5
Allows to download multiple podcasts at the same time
...
A new PodcastDeleter, it deletes podcast episodes
2014-12-10 00:47:52 +01:00
dc669eb603
Fix cpplint.py errors, fix copyright notices in src/analyzers, move src/core/fht* to src/analyzers
2014-11-29 20:07:01 +01:00
64c34f58ae
Merge pull request #4608 from sobkas/src_core_fix
...
Fix the copyright info and formatting in src/podcast and src/core
2014-11-27 15:17:16 +01:00
ff91759b71
Fix Ubuntu PPA
...
Adds a missing check for libcdio.
Adds libcdio as a dependency for debian.
Fixes issue #4618
2014-11-19 15:45:05 +09:00
ff172f6ed4
Network remote can now transcode lossless files before sending them to the remote.
...
- It is configurable in the settings.
- Any format can be chosen that is supported by the transcoder.
- The status of the transcoder is send to the remote.
- Transcoder format settings have now a postfix so we can define mutliple transcoder formats and use them separatly. Here one for the normal transcoder and one for the network remote transcode. You can pass the postfix in the constructor.
- Fixed Transcoder crash (was introduced with the gstreamer1.0 merge, decodebin doesn't have a "new-decoded-pad").
- Transcoder emits the output filename as well on "JobComplete" signal
- Transcoder can now convert a file to a temporary file ("AddTemporaryJob")
2014-11-13 22:31:49 +01:00
6efb5d05b7
Fix some problems
2014-11-05 17:48:04 +01:00
130d3c72f0
More copyright info fixes
2014-11-05 17:48:04 +01:00
d775d72345
More copyright info fixes
2014-11-05 17:48:04 +01:00
39a3b46ead
More copyright info fixes
2014-11-05 17:48:04 +01:00
a85728dfb3
Fix some problems
2014-11-05 17:48:03 +01:00
c0614dbe09
Fix copyright notices inside src/core
2014-11-05 17:48:03 +01:00
0af1470cce
Clean up src/core
2014-11-05 17:48:03 +01:00
978a91442c
Connect signal to signal
2014-11-05 17:35:14 +01:00
5045f9b870
Don't use caller in OrganiseDialog
2014-11-05 02:37:44 +01:00
b89c05048a
Move connect out of emitter
2014-11-05 00:42:56 +01:00
578c9ad598
Ability to automatically set podcast as listened after sucesfully sending it to a device
2014-11-05 00:42:55 +01:00
baa0654b03
Try to fix minimal build
...
Maybe one day I will stop breaking it everytime I change something
2014-10-26 17:12:00 +01:00
7ac9e4c6d1
Fix a bug in InsertItems functions that makes Cdda tracks to not be saved/restored correctly when restarting Clementine
2014-10-26 17:08:12 +01:00
dc0d3436c8
Finish CD integration update to Gstreamer 1.0
...
Move everything related to CDDA to a seperate class, so we can more easily reuse it in SongLoader
2014-10-26 03:32:37 +01:00
a8266173c5
Start to reactivate audio CD support
2014-10-26 00:28:03 +02:00
7b651136d8
Use the system's sha2 library if it's available. Fixes #4217
2014-09-25 23:51:46 +10:00
39d99247a2
gstreamer-cdda is in gst-plugins-base in 1.0 and has a different header name.
...
This still doesn't work because the API has changed and track listings are
now delivered via a bus message instead of direct access to the struct's
members.
2014-09-22 22:28:53 +10:00
a2408f7c0e
Merge branch 'master' into gstreamer-1.2
...
Conflicts:
src/moodbar/moodbarloader.cpp
2014-09-21 19:39:27 +10:00
47108a9a68
Add a message in CMake to notify that ccache has been found and will be used (+ some minor, unrelated things).
2014-08-06 20:05:41 +02:00
6bb81328e8
Merge branch 'master' into gstreamer-1.2
...
Conflicts:
ext/clementine-spotifyblob/mediapipeline.cpp
gst/moodbar/gstfftwspectrum.c
src/core/songloader.cpp
src/core/songloader.h
src/engines/gstengine.cpp
src/engines/gstenginepipeline.cpp
src/moodbar/moodbarpipeline.cpp
src/musicbrainz/chromaprinter.cpp
src/transcoder/transcoder.cpp
src/ui/mainwindow.cpp
src/visualisations/projectmvisualisation.cpp
2014-06-09 16:20:24 +10:00
1fc95cb7ed
Add Seafile Support
2014-06-03 14:33:07 +02:00
1f97406171
Revert "Send album artist to Last.fm"
...
This reverts commit d7ec8b9103
2014-05-21 17:47:01 +02:00
d7ec8b9103
Send album artist to Last.fm
2014-05-20 21:20:55 +01:00
f593eb0952
Use arraysize instead of sizeof
2014-05-12 19:00:26 +10:00
41425b3c5c
Remove . from the beginning of filenames when organising files. Fixes #4338
2014-05-11 19:24:21 +10:00
f52e48c956
Send filesize and file count in advance when client wants to download songs.
2014-05-10 14:53:38 +02:00
3e57a85711
Merge pull request #4308 from TheUbuntuGuy/master
...
Fix play bleeding into next track after auto stop
2014-04-26 18:46:26 +10:00
f793d09d8e
Fix play bleeding into next track after auto stop
...
If "fade out on stop" is enabled, the "stop after this track" feature
would stop not stop the on current track, but instead start playing
the next track and fade out on that immediately. This patch disables
fadeout when the engine is stopped by HandleStopAfter().
2014-04-26 00:58:08 -04:00
231443f6d1
Merge pull request #4305 from TheUbuntuGuy/master
...
Fix stop after track. Fixes #3572
2014-04-26 13:10:23 +10:00
c890af6306
More elegant solution to last commit
...
set_current_row now takes optional parameter "is_stopping" for when auto stop
is enabled.
2014-04-25 22:45:25 -04:00
416d06bb06
Fix stop after track
...
Stop after track would cause now playing widget, OSD, and last.fm
scrobbler to change to next track after stopping. This patch prevents
set_current_row() from firing an event which triggers the track change.
2014-04-25 14:30:31 -04:00
42f62be5b6
Fix after review
2014-04-25 08:57:31 +04:00
69b4f9113a
BugFix: clementine cannot delete directories in file tab #858
2014-04-25 00:28:22 +04:00
b9279ca128
Merge pull request #4263 from abika/master
...
Load all songs that require disc-read non-blocking.
2014-04-12 16:03:55 +02:00
66fcaefed9
Documentation update for async song load.
2014-04-07 15:38:26 +02:00
a056a87c8e
Coding style fixes for async song load.
2014-04-07 15:27:47 +02:00
4ed6f94211
Open the right part of the system preferences for global shortcuts on Mavericks.
2014-04-02 16:27:07 +02:00
0d199be5a7
Load all songs that require disc-read non-blocking.
2014-04-02 15:57:01 +02:00
6d1dc56a7c
Get a list of available audio devices from pulseaudio, and let the user choose
...
from those in the settings dialog instead of just giving him a text box.
2014-03-29 19:31:38 +11:00
4ab4bbc23f
Remove Last.fm radio support.
...
Fixes #4259
2014-03-28 14:55:04 +01:00
a7b0accd93
Add Vk.com plugin.
2014-03-08 00:58:50 +07:00
5146bcdebc
Some more NULL -> nullptr conversions.
2014-02-21 17:30:46 +01:00
192b60d965
Use nullptr as parent parameter default everywhere
2014-02-10 16:03:54 +01:00
3323c2d094
Convert all instances of foreach() to a C++11 for
...
find ext src -name '*.cpp' -exec \
sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
2ab8ab8077
Use double click settings as default behaviour for new files added as command line arguments.
2014-02-07 20:28:37 +01:00
0ecf1e76a6
Reformat done with clang-3.5 svn200967
2014-02-07 17:08:31 +01:00
bebd781fdf
Reformat all non-3rd-party C/C++/Objective-C++.
...
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
-style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
3df3a5b645
Add missing header for syscall().
...
This is cunningly not defined in syscall.h
2014-02-06 19:03:10 +01:00
8d1f4612db
Hide use of boost multi-index behind pimpl.
2014-02-06 17:53:33 +01:00
71893e4847
Use nullptr instead of NULL everywhere.
2014-02-06 17:29:59 +01:00
d309d4ab27
Use c++11 instead of boost where possible.
2014-02-06 16:51:39 +01:00
7084697aa3
Prevent Clementine to loop forever when trying to play a song with repeat enabled in a playlist which contains only unavailable songs
2014-02-04 22:08:32 +01:00
ddda13ceb7
u_int8_t is missing on mingw
2014-02-04 14:10:59 +01:00
a349a96f5a
Avoid having similar filenames when organising songs (number them instead)
2014-02-02 19:28:45 +01:00
96075faf88
Namespace clementine's 3rdparty implementation of sha2 to prevent its symbols
...
conflicting with the system's openssl symbols with the same names.
This was causing SSL connections to fail in weird ways on Debian.
Fixes #4130 .
2014-02-02 20:25:11 +11:00
06184cc5fb
Avoid having empty filenames, or filenames with extension only.
...
In this case, keep the original filename.
2014-02-01 03:22:41 +01:00
7ddf3aab45
Merge pull request #4145 from sobkas/master
...
Initial support for "Copy to device" in a podcast section
2014-01-31 04:31:43 -08:00
b96ec7555a
Reformat all Objective-C++ files with clang-format.
...
clang-format -style=Google -i src/*/*.mm
2014-01-30 14:54:51 +01:00
361cca83cb
Cpplint.py fixes
2014-01-29 17:30:58 +01:00
09d68bf415
Scrub the auto usage, use unique_ptr, use correct types instead of QList
2014-01-28 17:01:14 +01:00
b0a97de603
Use more auto in for statements
2014-01-27 23:59:38 +01:00
f7be18b326
Fixed some problems reported by cpplint.py, changed foreach to for in files touched by me
2014-01-27 23:59:38 +01:00
35060d6916
I accidently break this, nothing to see here
2014-01-27 23:59:37 +01:00
4944e99d56
Fix copy functionality, break copy of a directory
2014-01-27 23:59:37 +01:00
f60327b1d1
Initial 'Copy to device' support for podcasts
2014-01-27 23:59:36 +01:00
5ac83bd463
Merge branch 'master' into gstreamer-1.2
2014-01-25 00:24:31 +11:00
f816a47ad9
Make SongLoader add URLs as raw streams if there exists a URL handler
...
for that scheme. This fixes a bug where sky:// URLs couldn't be added
with MPRIS.
2014-01-24 23:54:38 +11:00
dc5670edfb
Encode song URLs when inserting them into the database. This was broken by revision 98dd001a. Fixes issue #4127
2014-01-20 21:39:18 +11:00
7ad1d7abc3
Remote: Use sha1 instead of md5 for file hashing.
2014-01-18 18:33:49 +01:00
1a972e0f36
Fix rendering of source icons in playlist view on retina OS X 10.9
2014-01-10 16:57:32 +01:00
94ccd325d7
- Move sha1 cover hash to utilities
...
- When initializing song check if we have a cover art. If not, check if there is one in the cache and use this.
2013-12-31 15:21:50 +01:00
774027a927
Removed tobytearray macro because it coerces to ASCII.
2013-12-12 15:41:49 +01:00
6be0964258
Make sure that we feed set_url() with a QUrl from an UTF-8 encoded string.
2013-12-12 15:41:49 +01:00
5207af6f93
Create QShortcuts to catch key bindings from global shorcuts and hide them from widgets
...
Fixes issue 722
2013-12-02 21:36:14 +11:00
503b8445ad
Remove debug message
2013-11-22 20:52:14 +01:00
4c23072bef
Link dynamically against sqlite3 but still use a copy of QSqlLiteDriver
2013-11-22 16:31:41 +00:00
2647fe4bbc
Emit MPRIS notification when we add or remove a playlist.
...
Fixes issue 3962.
2013-11-19 00:13:45 +01:00
51d9080a81
Update issue 3962: don't try to activate a playlist which doesn't exist/isn't opened anymore (otherwise we crash on Q_ASSERT)
2013-11-16 19:53:02 +01:00
afae01156d
Merge branch 'portable'
2013-10-26 09:34:07 +02:00
f6ab3a9044
Fix library download in network remote.
2013-10-25 20:31:56 +02:00
98dd001a4f
Further work on portable version.
2013-10-03 17:08:42 +02:00
acb18cdcde
First tries on a portable version.
2013-09-29 10:43:34 +02:00
56c949815b
First pass at Gstreamer 1.0 porting.
...
This at least compiles against gstreamer 1.2.
Things that work:
* Playing audio
* Automatically completing tags
Things that don't work
* Spotify
* Moodbar
Things I haven't tested
* Transcoding
2013-09-26 17:49:24 +02:00
1efd88cc2a
Create a Fatal logging level, and use it when sqlite symbols can't be resolved.
...
(cherry picked from commit f0b9120c43
2013-09-18 01:24:36 +02:00
f0b9120c43
Create a Fatal logging level, and use it when sqlite symbols can't be resolved.
2013-09-18 00:15:46 +10:00
efc5f31d9b
Use short locale format in playlist view.
...
Fixes issue #1451
(cherry picked from commit f8efbd81e4
2013-09-07 19:58:10 +02:00
f8efbd81e4
Use short locale format in playlist view.
...
Fixes issue #1451
2013-08-29 16:31:29 +02:00
53b8f59e6f
Try to fix Windows build.
2013-08-01 19:13:43 +02:00
3a309e9b25
Added message to retrive the library (table songs).
2013-08-01 18:13:14 +02:00
fc1880161c
Add a 'language_without_region' as this is not specific to networkremotesettingpage
2013-07-27 19:23:55 +02:00
1a3f6af1bd
Clean up the network remote settings page, add a "Get it on Google Play" button.
2013-07-27 15:27:08 +10:00
1e4819f2df
Add stop after current track feature to network remote.
2013-07-20 19:38:37 +02:00
f166954495
Add Google cpplint & lint one class
2013-07-19 15:38:22 +02:00
eb20fb5945
Remove all the soruce for WMDM devices. Fixes issue 3748
2013-06-30 08:25:12 +00:00
ecd94cf472
Oops.
2013-06-09 16:41:02 +02:00
a6a8997a2e
Use QDir::toNativeSeparators instead of QString::replace. Add QProcess include for windows build.
2013-06-09 16:29:40 +02:00
d16ac382ef
Highlight the opened file in Windows Explorer. Fixes issue 3695.
2013-06-09 15:52:47 +02:00
9cc7169904
Used kNsecPerSec for milliseconds in a second.
2013-05-30 08:28:21 -04:00
7381f381e6
Added --restart-or-previous option.
...
Fixes bug #3524 .
2013-05-29 15:27:07 -04:00
c6068b16c9
Handle leading spaces when splitting schema update queries.
...
Otherwise the commands aren't splitted correctly, so the queries aren't run correctly, and the root cause might not be obvious.
2013-05-13 23:04:24 +02:00
5e6821dead
Add a 'favorite' widget to playlist tab, and keep in playlistlist container only favorite playlists, instead of all playlists.
2013-05-11 23:18:03 +02:00
fe964b9457
Never start playing a background stream on startup, even if it was enabled last time.
2013-05-04 19:26:24 +10:00
6fa77b8749
RevealFileInFinder for mac "show file in browser"
...
on mac, use QProcess to call "/usr/bin/open -R file", which highlights the file
when you context-menu click "show file in browser", instead of merely opening
the directory
Fixes issue #3634
2013-04-25 15:23:43 -07:00
bb0f7412be
Include any user-agent supplied by client libraries. Fixes issue 3612
2013-04-15 21:41:54 +10:00
18e8d6ca20
- Added basic playlist management (add and remove tracks) in network remote.
2013-04-13 11:57:05 +02:00
264d5ee0fa
Add Radio GFM
2013-04-13 14:28:42 +10:00
88918d45c5
Update issue 1175:
...
Save rating and statistics in two distinct ways, and let users activate them separately in preferences.
2013-03-30 23:42:29 +01:00
db5fbe2059
Update issue 1175:
...
Add an option in preferences to save all ratings/statistics into files, for all songs
2013-03-26 23:56:46 +01:00
dc208962f6
Don't update device_ tables with %allsongstables_fts.
2013-03-15 20:25:38 +11:00
d89954ae31
Fix style, hide the new columns by default, and move the new columns to the end of the enum
2013-03-10 18:16:14 +11:00
a6d3b48231
Extend tag support: performer, grouping
...
The transaction handling while upgrading the database schema had to be revised.
Furthermore some QSqlQuery statements needed to be finished properly.
Fixes issue 2556
2013-03-10 18:16:03 +11:00
7f2c17a0b7
Add track rating/score to OSD.
...
Fixes issue #2586
2013-02-26 16:33:05 +01:00
b5b371ef6f
Use Qt's foreach instead of C++11 foreach, as it doesn't work with older versions of gcc
2013-02-24 19:16:52 +01:00
08d40f5fca
Handle statistics tags apart, and write them to file when they change.
...
Next step: add a preference to activate this (should be deactivated by default IMO).
2013-02-24 17:45:25 +01:00
115964d1b4
Load local tags asynchronously in SongLoader.
2013-02-17 18:19:05 +11:00
4acafb4930
Remove some old code
2013-02-17 18:10:08 +11:00
6904b06cf8
Add --increase-volume-by and --decrease-volume-by commandline options. Fixes issue 3496
2013-02-17 15:13:39 +11:00
d21fa8cc67
Add support for Box.
2013-02-12 17:11:18 +01:00
bb7a1e65f4
Adding spot for a unique album ID and implementing on Spotify
...
To resolve albums with duplicate tracks
Fixes issue 3429
2013-02-07 21:39:10 +01:00
3cb7a76656
Add Engine::TrackChangeFlags as MetaType, so the connect workings.
2013-02-07 19:27:54 +01:00
f779e14df7
Fix connects for Repeat and Shuffle. They were never reached.
2013-02-03 21:09:48 +01:00
kiselev-dv
Mark Furneaux
Andreas
Adam Porter
Martin Babutzka
John Maguire
Arnaud Bienner
Krzysztof Sobiecki
Andre Siviero
Andreas
David Sansome
Chocobozzz
Diogo Pereira
vkrishtal
Alexander Bikadorov
Maltsev Vlad
Martin Brodbeck
Aggelos Biboudis
Glad Olus
Kevin Cox
graehl
pie.or.paj
Uwe Klotz
Mateusz Kowalczyk
Joel Bradshaw