Commit Graph

3269 Commits

Author SHA1 Message Date
David Sansome 1d098a40b8 Revert commit ddfb90a0a1, and always delete files from disk rather than sending them to trash. 2011-08-27 23:54:55 +01:00
David Sansome a8d9f9104a Map playlist indices to the source model when passing them to the future watcher for background saves, fixing a bug where the wrong notification would be sent when editing track information for the currently playing song and the playlist was filtered. Fixes issue 2063 2011-08-27 23:16:57 +01:00
David Sansome 804cbbc14e Save the playlist after editing fields of files in it - affects files that are not in the library. 2011-08-27 23:09:42 +01:00
David Sansome 9312f153b7 Don't show a notification and update the now playing widget when editing a song that isn't currently playing. Fixes issue 1689 2011-08-27 23:08:53 +01:00
David Sansome 5884502389 Fix a bug loading where song metadata wouldn't be loaded from the library when loading a local file containing spaces. Fixes issue 2192 2011-08-27 22:51:30 +01:00
David Sansome 2f63130606 When renumbering tracks, only start from the track number of the first track if it's greater than 0. Fixes issue 2072 2011-08-27 22:43:02 +01:00
David Sansome 7f7451b72a Stop the M3UParser from going into an infinite loop when parsing a file with an invalid #EXTINF line. Fixes issue 2080 2011-08-27 22:35:00 +01:00
David Sansome 7e0e4e48e4 When loading a CUE from disk that isn't in the library, don't overwrite the metadata of its first song with the metadata from the audio file. Fixes issue 2092 2011-08-27 22:29:35 +01:00
David Sansome 13fc24f6c6 Refactor the last.fm, magnatune, spotify and di.fm settings pages - moving the login state display into a separate widget. 2011-08-27 22:01:28 +01:00
David Sansome 143bbb4019 Make the BusyIndicator contain a label too 2011-08-27 15:03:04 +01:00
John Maguire 72198db1ba Make the album cover search dialog window modal so that it acts like a sheet on Mac. 2011-08-27 14:50:11 +01:00
David Sansome 263f57b47b Only set the pretty OSD's message in the notifications settings page's constructor - don't show it as well. It would just get hidden again straight away, and for some reason this triggers a (Qt?) bug where the window gets painted in the top-left corner, but reacts to mouse clicks in its actual position.
Fixes issue 2110
2011-08-26 23:34:13 +01:00
Arnaud Bienner 3dc4e3aa0b Merge branch 'master' of https://code.google.com/p/clementine-player 2011-08-26 00:23:30 +02:00
Arnaud Bienner 21f5345da4 Also work with cdda URLs which doesn't contain device inside URL 2011-08-26 00:11:18 +02:00
David Sansome 73a1052f70 Use a fakesink instead of an appsink in the probe pipeline to fix a memory leak and make it work on Windows where we don't bundle appsink.
Fixes issue 2177
2011-08-22 22:40:33 +01:00
Andrew Gaydenko 41a151840f Split the gstreamer pipeline - one path is converted to 16-bit int samples for the scope. The other is kept at float32 to preserve the bit depth of the audio.
Fixes issue 2114
2011-08-19 22:02:42 +01:00
Arnaud Bienner 5cbb86f247 Use toEncoded instead of toString in SQL query 2011-08-19 22:37:59 +02:00
Arnaud Bienner 5841bb58a7 Correct typo in comment 2011-08-19 22:31:48 +02:00
Arnaud Bienner f319a615d9 Use url when checking if a file is already in DB instead of filename when loading files (this usecase has been missed when we have decide to use urls everywhere) 2011-08-18 22:43:52 +02:00
Arnaud Bienner f33b62a877 Oops... Actually, it's better like this :) 2011-08-18 22:10:09 +02:00
Arnaud Bienner 299f15b7ee Allow GIO to handle CD devices if libcdio isn't installed 2011-08-18 21:41:14 +02:00
Arnaud Bienner 91537777c8 Ignore cdda devices detected via gio ealier, to avoid crash when getting device's filesystem info. This seems to happen because both giolister and cddadevice try to access to the device at the same time 2011-08-18 21:34:45 +02:00
Arnaud Bienner 419447e192 Reset song count during init 2011-08-18 20:23:11 +02:00
David Sansome e194d89857 Fix a crash when choosing "Edit track information" from the library view 2011-08-18 00:38:49 +01:00
John Maguire 8ad150bd6b Don't detect CD devices on Mac when we can't use them and fix an iokit
device leak.
2011-08-15 18:13:05 +02:00
John Maguire 56a4d6b743 Fix double unref on cdda element. 2011-08-15 18:08:09 +02:00
David Sansome 3be95c9462 Always compile the spotify settings page UI file to fix a build failure when spotify was disabled. Fixes issue 2159 2011-08-15 11:36:06 +01:00
David Sansome 4ce5cf03d2 Enforce the correct minimum width on settings dialog pages so they don't appear clipped horizontally 2011-08-14 20:19:54 +01:00
David Sansome 4b1e2f08e9 Put each settings page in a scroll area, and resize the settings dialog to fit on the user's screen if it's too big. Fixes issue 953. 2011-08-14 15:41:47 +01:00
David Sansome dad76b78dd Move all the settings pages to their own widgets and classes 2011-08-14 00:07:10 +01:00
John Maguire 50824cafe9 Make AskForScan() per-device rather than per device lister and fix cddadevice to use the url rather than the unique id. 2011-08-11 22:10:14 +02:00
John Maguire b458c9d24c Merge branch 'master' of https://code.google.com/p/clementine-player
Conflicts:
	src/devices/devicemanager.cpp
2011-08-11 21:46:48 +02:00
John Maguire 75a53d0b36 Detect CD removal on mac. 2011-08-11 21:43:00 +02:00
John Maguire 47a171fca7 Detect cd insertion on mac. 2011-08-11 21:37:09 +02:00
Arnaud Bienner 4509757233 We cannot change CD device's content: return false for those methods. This will display an error message, more explicit than doing nothing without any warning 2011-08-11 01:16:08 +02:00
Arnaud Bienner 3b6af2298d Remove useless return statement which prevents using the 'friendly name' (even if we're supposed to rarely go here) 2011-08-11 01:10:45 +02:00
Arnaud Bienner 1a4aa8f641 Make the 'dont ask on first connect' more generic 2011-08-11 00:59:34 +02:00
Arnaud Bienner f963ae524a Ignore devices that correspond to symlink to avoid duplicate 2011-08-11 00:15:26 +02:00
David Sansome 191e23ed13 Remove old references to libarchive 2011-08-10 16:30:36 +01:00
David Sansome 082716e9c9 Don't try to compile audio CD support if libcdio isn't installed. 2011-08-10 16:30:36 +01:00
John Maguire 369650dbef Fix building without spotify support. 2011-08-10 13:44:55 +02:00
Arnaud Bienner 0b795841d5 Merge branch 'master' of https://code.google.com/p/clementine-player 2011-08-10 00:49:43 +02:00
Arnaud Bienner 07ce755060 Work with multiple CD devices 2011-08-10 00:49:36 +02:00
John Maguire 6ddf9fa41b Only parse the tracks from the first release we find on musicbrainz for a CD. 2011-08-09 21:54:37 +02:00
John Maguire 6d9bc9d3f4 Don't constantly refresh the cd device if it doesn't support checking for media changes.
Filter out irrelevant devices on OS X.
2011-08-09 21:30:28 +02:00
John Maguire 83a21f0576 Add gstreamer cdio plugin to mac bundle. 2011-08-09 21:14:40 +02:00
John Maguire 176efeb4b0 Add debug logging to cdda lister. 2011-08-09 20:28:50 +02:00
John Maguire c307d2e87a Add proper disc icon for non-Linux. 2011-08-09 20:28:49 +02:00
John Maguire 5fcb3d3d7a Merge branch 'master' into resolvers 2011-08-09 19:30:20 +02:00
Arnaud Bienner cb28557a77 Correct typo 2011-08-08 23:44:49 +02:00