Commit Graph

163 Commits

Author SHA1 Message Date
Jonas Kvinge 8c198a99a5 Qt 5 fixes 2018-11-21 10:31:17 +00:00
Jonas Kvinge d4fab4a2ea Merge remote-tracking branch 'upstream/master' into qt5-update 2018-11-11 22:46:07 +01:00
Amish Naidu 107e945872 Convert uses of QtAlgorithms to std:: algorithms 2018-10-09 19:17:54 +01:00
Jonas Kvinge c29c2e95cc Fixed merge conflicts 2018-09-30 15:11:06 +02:00
Kerem Seyhan 4ac2dedefa Added mouse forward and back button actions. 2018-08-14 17:09:55 +01:00
David Guillen Fandos 4a1236f8da Reduce some CPU load by disabling/fixing some UI stuff
- Disabling playlist row glow by default
 - Track slider popup visible by default, add hide()
    to ensure not visible by default (no more repaints)
 - Set kTrackSliderUpdateTimeMs to 500. IMO 40 is too low

This should partially fix issue #1079
2018-08-08 22:39:54 +01:00
Antonio Russo 6a312e7459 Limit both QSettings reads and writes (#6057)
Any access, read or write, via QSettings requires locking
`Clementine.conf`. On some devices, this can be slow. Moreover, it also
increases power use and wear on devices such as SSDs.

To improve the situation, defer QSettings updates until program close
for window resize, current playlist tab, and playlist geometry, i.e.
`PlaylistView::SaveGeometry`.

Also, limit `PlaylistView::LoadGeometry` to once per program run.

Signed-off-by: Antonio Russo <antonio.e.russo@gmail.com>
2018-05-22 11:18:54 +01:00
Chocobozzz 16b4f9a991
Merge remote-tracking branch 'upstream/master' into qt5 2018-05-14 08:25:27 +02:00
Jonas Kvinge e52c7f6475 Fix formatting 2018-03-12 07:55:59 -04:00
Jonas Kvinge d33ac6ef81 Fix background not loading. 2018-03-12 07:55:59 -04:00
Jonas Kvinge c393926be6 Fix background not loading. 2018-03-12 07:55:59 -04:00
Chocobozzz 70f68b1926
Merge remote-tracking branch 'upstream/master' into qt5 2018-02-01 09:50:42 +01:00
droserasprout 08a80a5750 Fix oversized currenttrack icon in playlistview (#5885) 2017-10-18 00:32:25 +01:00
Yan Pashkovsky 7bd0639455 fix up key in playlist (#5768) 2017-06-21 15:11:41 +01:00
Chocobozzz fc517ce7a5 Merge remote-tracking branch 'upstream/master' into qt5 2017-06-05 21:28:05 +02:00
Grace Dolphy bdda50b28f Continuation of "Seek instead of navigation with arrow keys" #5550, now allows up arrow key. (#5721)
* Continuation of "Seek instead of navigation with arrow keys" #5550, now allows up arrow key to not restart the song over when the library is in focus. Works as usuhal when playlist is in focus (song gets started over).

* Update playlistview.cpp

Added in the part that is responsible for seeking properly.
2017-05-30 18:19:08 +01:00
Grace Dolphy 52f1982353 Delete Undo Fix Attempt - Should Solve Issue #5701 Using Clementine to delete a song from disk should not be added to the undo stack (#5702)
* Fix delete functionality. Skips to next song if deleted song is also currently playing.

* Added in a bool to determine if the song being deleted is meant to be deleted from the disk or just from the playlist. Took advantage of the unused variable located in removeRows to distinguish between the two options. No longer adds delete from disk to the undo stack, and deleting from the playlist goes to undo stack as it should.

* Added in a bool to determine if the song being deleted is meant to be deleted from the disk or just from the playlist. Took advantage of the unused variable located in removeRows to distinguish between the two options. No longer adds delete from disk to the undo stack, and deleting from the playlist goes to undo stack as it should.

* Update mainwindow.cpp

* Formatting Changes

* Update playlist.cpp

Simplified condition statement.

* Added in a missed boolean for RemoveSelected

* Update playlistview.cpp
2017-04-18 14:29:25 +01:00
Chocobozzz e6e189967d Merge remote-tracking branch 'upstream/master' into qt5 2016-02-29 18:03:02 +01:00
narunlifescience b6bf54be6c remove magic numbers 2016-02-11 04:41:37 -06:00
Arun Narayanankutty 29b8d308b3 Use icon loader for remaining icons 2016-01-14 06:10:54 -06:00
Mark Furneaux 041be5b4ce Fix incorrect highlight colour in playlist when the window is inactive 2015-12-24 13:42:47 -05:00
Chocobozzz ff7026c9fe Merge remote-tracking branch 'upstream/master' into qt5 2015-12-13 20:05:12 +01:00
narunlifescience b9eca5e323 Lock/Unlock Ratings edit status 2015-10-24 23:05:23 -05:00
John Maguire fad1767f6c Revert "Lock/Unlock Ratings edit status" 2015-10-20 18:39:42 +01:00
narunlifescience bcceae175d Lock/Unlock Ratings edit status
add comment

organize

unclutter

patch to work with other languages

Update playlistheader.cpp
2015-10-18 23:06:35 -05:00
Eduardo Sánchez Muñoz 95dad17f3e Initialize blur_radius_ and opacity_level_ on PlaylistView constructor. 2015-10-04 13:26:35 +02:00
Chocobozzz 631a6cdabd Merge branch 'master' into qt5 2015-09-16 17:40:54 +02:00
Eduardo Sánchez Muñoz 11b61c2a67 Use Player::SeekForward() and Player::SeekBackward() to handle seeking with arrow keys. 2015-07-02 14:59:30 +02:00
Eduardo Sánchez Muñoz acef48df5d Support showing original year tag on the playlist. 2015-06-30 19:25:38 +02:00
Chocobozzz 5aec1c0e24 Merge remote-tracking branch 'upstream/master' into qt5
Update qt version to 5.4.2
2015-06-03 22:57:58 +02:00
Mark Furneaux 87ca578a00 Scroll to last played track when switching playlists
Currently we just scroll to the last viewed index of the last playlist in the new one. This makes no sense and is frustrating when switching between long and short playlists.
This change scrolls to the last played track in each playlist on transition.
2015-05-19 22:23:03 -04:00
Chocobozzz 8b226c2171 Update non optionnals sources to qt5 2015-04-11 23:24:07 +02:00
Chocobozzz 50b7b7d889 Make format after update to avoid conflicts 2014-10-15 21:57:57 +02:00
Chocobozzz 8279f21251 Revert "Make format"
This reverts commit 17b1e9fbe6.
2014-10-15 21:55:03 +02:00
Chocobozzz 17b1e9fbe6 Make format 2014-10-15 20:55:24 +02:00
Arnaud Bienner 37a6c125c0 Consider some more things as text (like numbers) when deciding if we should focus on the search bar 2014-10-04 18:08:53 +02:00
Arnaud Bienner 631c120515 Allow to change rating when "inline" editing is not enabled 2014-09-06 17:54:50 +02:00
Helder Martins cbfd3218f2 Cleaning unnecessary code 2014-07-23 23:47:12 +01:00
Helder Martins 0c2d4e9f1c Fixed a minor issue where the playlist wasnt updating the queue order, when a track was dequeued using the ctrl-d shortcut 2014-07-23 00:15:06 +01:00
Gu1 62ecfe19f7 Add an option to disable inline song metadata editing through click 2014-06-23 18:40:00 +02:00
John Maguire 24a4cff807 Merge pull request #4288 from sundrythoughts/rating-optimization
Increase performance of mass rating changes.
2014-05-20 12:42:39 +01:00
David Sansome 98b6b6f906 Don't use italic text anywhere - Arabic text doesn't have italics. Fixes #4329 2014-05-11 20:42:49 +10:00
Joseph Freeman fe4a80b2d5 Removed commented-out code and ran make format. 2014-04-25 19:41:04 -04:00
Joseph Freeman 156728390d Increase performance of mass rating changes. 2014-04-25 19:37:46 -04:00
Alexander Bikadorov 3adaf5d598 fixed indentation / coding style 2014-02-11 13:18:08 +01:00
Alexander Bikadorov c7ac2012b4 correct selection after removing rows in playlist 2014-02-10 16:51:43 +01:00
John Maguire 3323c2d094 Convert all instances of foreach() to a C++11 for
find ext src -name '*.cpp' -exec \
    sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
John Maguire bebd781fdf Reformat all non-3rd-party C/C++/Objective-C++.
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
 -style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
John Maguire 71893e4847 Use nullptr instead of NULL everywhere. 2014-02-06 17:29:59 +01:00
David Sansome d3749eace9 Select the current item if the selection is empty when using Tab to move from
the playlist filter to the playlist view.  Fixes #4116
2014-01-14 20:07:03 +11:00