732 Commits

Author SHA1 Message Date
ftiede
c01b7bc430 Add option to verify subsonic server certificate. (#6060)
* Add option to verify subsonic server certificate.

Defaults to true, as it is safer to have a server certificate verified,
even more so, if the server is used over an insecure WAN link.
During subsonic configuration the checkbox can be deactivated, so that
no certificate verification will occur when talking to a subsonic
server, allowing for self-signed certificates.

With the proliferation of let's encrypt certificates there's probably
less need for this option but it has been requested and hard-coding
verify-off is IMHO bad security practice.
If a valid certificate has been installed, the configuration file can be
modified manually and after a restart Clementine will perform a proper
server certificate verification.

The patch might need some UI polishing and asks for string translations
but is operational so far.

* Satisfy CLang format checker.

* Use QSettings' default value support.

* Consistently use QSettings' default value method.
2018-05-23 14:23:53 +01:00
ftiede
4619a4c1ab Work around Qt's QUrl parser. (#6059)
Qt's QUrl parser does no longer accept pure numeric hostnames without
trying to make a dotted IPv4 address of them.
Thus current method of storing subsonic's numeric ids in the host part
of a QUrl ("subsonic://<id>") does no longer work.
Instead a query is constructed omitting the host-part entirely and using
"subsonic://?id=<id>" to store and retrieve subsonic titles.
2018-05-23 14:23:21 +01:00
Chocobozzz
16b4f9a991
Merge remote-tracking branch 'upstream/master' into qt5 2018-05-14 08:25:27 +02:00
Chocobozzz
5bd2c77c58 Fix compilation with GCC 8 (#6053) 2018-05-13 18:02:33 +01:00
Pulfer
ddfa5e63f1 Fix channels loading for DI.fm services after API domain changes (#6023) 2018-03-10 18:35:09 +00:00
John Maguire
4273c03132 Merge branch 'master' into qt5 2018-02-19 16:46:42 +00:00
Chocobozzz
a1a892b35e Fix "Invalid key" error in lastfm auth 2018-02-19 09:10:26 +00:00
Benjamin Sproule
595eec7878 Removed filter for audio/folder OneDrive items as OneDrive doesn't count many audio file types as audio (e.g. flac) (#5977) 2018-02-01 11:38:25 +00:00
Chocobozzz
70f68b1926
Merge remote-tracking branch 'upstream/master' into qt5 2018-02-01 09:50:42 +01:00
Chocobozzz
38c1f8777c Fix compilation with crypto++ >= 6.0.0 (#5974) 2018-02-01 08:07:51 +00:00
Stephen Dawkins
d9b12a5599 Added additional check when enclosure type is missing (#5934) 2017-12-23 12:48:38 +00:00
Adrian Garcia
dfa7042ff3 Subsonic: download cover art (#5880) 2017-10-06 14:08:00 +01:00
Allan Nordhøy
c29886d8c9 Spelling: URL (#5836) 2017-08-28 23:03:49 +02:00
Allan Nordhøy
55ef908728 Spelling: Log in, Last.fm (#5835)
As per https://www.last.fm/
2017-08-28 23:03:22 +02:00
John Maguire
a8cb9bbd2a Authenticate Last.fm with "oauth". 2017-08-24 19:32:14 +01:00
David Roeca
49876536a5 Resolve #3693 (#5790)
* bring in playlist updates for potential fix

* define signal to handle organise playlist bugs

* work in progress

* fix wrong signal/slot

* next push forward on handling new song creation

* Reorganize signals/slots; still need to figure out why not all signals are being handled

* Get playlists to work when they're in memory

* more changes to playlist updates

* revert unnecessary changes and finalize fix
2017-07-22 18:57:33 +01:00
Chocobozzz
fc517ce7a5 Merge remote-tracking branch 'upstream/master' into qt5 2017-06-05 21:28:05 +02:00
Rix
8ff7d5750c SoundCloud service simple search limit is set. (#5738)
SoundCloud search limit it set to 100. Pagination may be added soon. (see SoundCloud HTTP api: https://developers.soundcloud.com/docs/api/guide#pagination)
2017-05-30 18:17:40 +01:00
MelissaManley97
a5d12d0d10 Request to merge a fix for a crash during searching under Internet Tab (#5682)
* Changing ClearSearchResults order.

If search_ is null, there is no point in clearing it.

* Update to fix 12 (Crash when searching under Internet tab with Spotify)

* Formatting Fixes
2017-03-28 17:38:55 +01:00
John Maguire
27bf50d702 Do not log sensitive data in OAuthenticator. 2017-02-27 12:41:34 +00:00
John Maguire
1aed6193e7 Fix intergalactic FM URLs. 2017-02-21 14:24:50 +00:00
Florian Bigard
69b2a832db Merge branch 'master' into qt5 2017-01-18 15:57:07 +01:00
Ilya Selyuminov
1a477201ed Use CaseInsensitive file type checking #5499 (#5592)
* Fix Seafile setting page loading

Check access_token instead of QSetting parameters to make
sure that we're logged in.

* Use CaseInsensitive file type checking  (#5499)

CloudFileService and TagReader classes use
QString::endWith() method for checking file type.
This method is CaseSensitive by default.
2017-01-12 15:58:44 +00:00
John Maguire
c7b8aacad8 Remove support for VK
Fixes #5591
2017-01-11 18:08:43 +00:00
John Maguire
bd2de93e3c Add more override specifiers. 2016-12-20 14:16:42 +00:00
John Maguire
df5c53af84 Add "override" to SpotifyService. 2016-12-20 13:02:06 +00:00
Chocobozzz
2ede85bdcd Merge branch 'master' into qt5 2016-12-18 17:04:08 +01:00
Bigard Florian
6901c9b1b6 Fix podcast episodes forgotten (#5560) 2016-12-18 15:48:08 +00:00
Chocobozzz
2096b1f268 Merge branch 'master' into qt5 2016-12-13 20:26:19 +01:00
John Maguire
420601f10a Add support for classicalradio.com 2016-11-07 18:22:06 +00:00
Nicolas Martinelli
650f06f7ad Fix Subsonic endpoint
According to the documentation, the endpoint is `getAlbumList`, not
`GetAlbumList`. This typo makes the complete feature not working at
all.

Source: http://www.subsonic.org/pages/api.jsp#getAlbumList
2016-10-20 22:08:26 +02:00
Chocobozzz
18a89f78a9 Merge remote-tracking branch 'upstream/master' into qt5 2016-10-07 14:30:09 +02:00
John Maguire
13aa0adc84 Migrate to dropbox api v2 2016-06-29 12:16:08 +01:00
John Maguire
0beb6d3c59 Remove support for Amazon Cloud Drive. 2016-05-16 18:00:10 +01:00
Chocobozzz
0aa3405274 Merge remote-tracking branch 'upstream/master' into qt5 2016-05-09 12:46:08 +02:00
Vavooon
d019cb7f80 Initialize user_favorites_ and remove an excessive line
* Add Favorites support to SoundCloud

* Initialize variable and remove an excessive line
2016-04-21 21:03:58 +01:00
Vavooon
7ef095d0cb Add Favorites support to SoundCloud (#5345) 2016-04-20 13:03:48 +01:00
David G. F
f1825629db Qt5
* Fixing a couple of issues with subsonic in the qt5 port

* Forgot to add this fixes as well, otherwise won't play music!
2016-04-19 23:22:23 +01:00
David G. F
182e5c3034 Fixing a couple of issues with subsonic in the qt5 port (#5346) 2016-04-19 21:50:21 +01:00
John Maguire
6693a870ad Reformat intergalacticfm service 2016-04-06 15:45:25 +01:00
John Maguire
9291f09b1b Merge branch 'master' into PanderMusubi-master 2016-04-06 15:43:32 +01:00
John Maguire
b2c506656c Avoid redirects from IntergalacticFM 2016-04-06 15:42:25 +01:00
John Maguire
be958495fe Merge branch 'master' of https://github.com/PanderMusubi/Clementine into PanderMusubi-master 2016-04-06 15:30:28 +01:00
David Sansome
2257dcd278 Merge pull request #5318 from goggle/master
Fixed compile error for the subsonic module.
2016-03-30 10:01:07 +11:00
John Maguire
b20d0d87fd Revert "Adding support for subsonic cover art download" 2016-03-29 21:12:54 +01:00
Alex Seiler
6cc60d0cf8 Fixed compile error for the subsonic module. 2016-03-29 21:23:53 +02:00
David Guillen Fandos
10bac1cd2d Fixing issues in the pull request. 2016-03-12 19:44:32 +00:00
Chocobozzz
e6e189967d Merge remote-tracking branch 'upstream/master' into qt5 2016-02-29 18:03:02 +01:00
David Guillen Fandos
e4efde900a Adding support for subsonic cover art download 2016-02-26 23:29:13 +00:00
Pander
1496d581cd Changed HTTPS to HTTP for Intergalactic FM 2016-02-25 17:37:45 +01:00