* Continuation of "Seek instead of navigation with arrow keys" #5550, now allows up arrow key to not restart the song over when the library is in focus. Works as usuhal when playlist is in focus (song gets started over).
* Update playlistview.cpp
Added in the part that is responsible for seeking properly.
* Fix delete functionality. Skips to next song if deleted song is also currently playing.
* Added in a bool to determine if the song being deleted is meant to be deleted from the disk or just from the playlist. Took advantage of the unused variable located in removeRows to distinguish between the two options. No longer adds delete from disk to the undo stack, and deleting from the playlist goes to undo stack as it should.
* Added in a bool to determine if the song being deleted is meant to be deleted from the disk or just from the playlist. Took advantage of the unused variable located in removeRows to distinguish between the two options. No longer adds delete from disk to the undo stack, and deleting from the playlist goes to undo stack as it should.
* Update mainwindow.cpp
* Formatting Changes
* Update playlist.cpp
Simplified condition statement.
* Added in a missed boolean for RemoveSelected
* Update playlistview.cpp
* Do not restore playback state on application start if overwritten by command line options
This also fixes unwanted pausing if a new instance is started with commandline URL combined with playback restore.
Note that the actual buggy code (MainWindow::ResumePlayback()) is not fixed here.
* Fix for commandline URLs for new instances are always appended to playlist.
Calling InformOfCurrentSongChange before updating the virtual index results in
sending the CanGoNext and CanGoPrevious notifications with the wrong values.
Currently we just scroll to the last viewed index of the last playlist in the new one. This makes no sense and is frustrating when switching between long and short playlists.
This change scrolls to the last played track in each playlist on transition.
Fixes#4836
Last.fm defines a scrobble should be sent if:
-the track is longer than 30 seconds.
-the track has been played for at least half its duration, or for 4 minutes (whichever occurs earlier.)
Clementine has treated this as seconds from the start of the track, and if any seeking occurs, it nullifies the scrobble.
This IMO is incorrect. If I skip the first 10 seconds of a song, but listen to the rest (still meeting the time requirements),
I should still be able to scrobble the play. This change moves the scrobble point with every seek, requiring continuous playback
from any point that satisfies the time criteria.
Otherwise, it was never set to false at startup if no "current_playlist" was saved in the settings, then there was no new value saved for "current_playlist".
Fixes#4011.
vikramambrose
Allan Nordhøy
Yan Pashkovsky
Alex Bikadorov
Grace Dolphy
santigl
Mark Furneaux
Ilya Selyuminov
John Maguire
Ivan Leontiev
Victor Dodon
narunlifescience
Mark Furneaux
Chocobozzz
Eduardo Sánchez Muñoz
Mark Furneaux
Andreas
kiselev-dv
Andreas
Arnaud Bienner