John Maguire
341dc7326f
Reformat all C++
2020-09-22 14:56:06 +01:00
Power Snail
4fe845c2c5
Use reference on a const loop var to avoid copy
...
Clang 10 warns that ``s`` might be copied. Use a reference to avoid copying
2020-03-07 02:39:13 +00:00
Jim Broadus
90cf4988ea
Fix crash when searching playlist.
...
While iterating over expandList in refreshExpanded, calls to setExpanded cause
the list to be appended. Since QList uses an array implementation that must
reallocate when reserved space is exhausted, iterators are unsafe for this case.
Use indexes, which are O(1) in QLists, instead of iterators.
2020-02-24 13:45:42 +00:00
Jonas Kvinge
959a957a56
Replace QModelIndex::child() with QAbstractItemModel::index()
2020-01-05 18:37:27 +01:00
Filip Gawin
be827f4f7f
Simplify some statements
2019-02-22 18:49:48 +01:00
Vikram Ambrose
5e065609b6
Ensure song items are shown on Favorited signal
...
There was an issue where the song items were only being shown
from a fresh start up but not when the playlist was created. This fixes
that issue and refactors the AddPlaylist code
2018-01-14 11:24:45 +02:00
Vikram Ambrose
fefea9de61
Disable drag of track items until this is properly implemented
...
Stop bad things from happening until proper DnD support of track
items has been implemented
2018-01-11 13:49:18 +02:00
Vikram Ambrose
ae71d24f6e
Ensure all nodes are shown when filter is cleared
2018-01-11 13:31:23 +02:00
Vikram Ambrose
3da938eac2
Add search filter to playlist list page
...
This allows power users who keep 100s of playlists to easily
find a playlist either by directory name, playlist name or by
searching for a song artist/title a playlist might contain
2018-01-11 13:11:13 +02:00
narunlifescience
dd953fd86c
check custom icon location, then system theme & then fallback theme
...
icons added & replaced
2015-10-13 22:35:49 -05:00
John Maguire
3323c2d094
Convert all instances of foreach() to a C++11 for
...
find ext src -name '*.cpp' -exec \
sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
John Maguire
bebd781fdf
Reformat all non-3rd-party C/C++/Objective-C++.
...
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
-style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
John Maguire
71893e4847
Use nullptr instead of NULL everywhere.
2014-02-06 17:29:59 +01:00
Mladen Pejaković
033d266fe9
Add contexts to some translation strings
2014-02-03 21:54:02 +01:00
David Sansome
8416188056
Show a message in the Devices pane on Windows to say that most devices won't work. Fixes #4059
2014-01-05 11:32:07 +11:00
Arnaud Bienner
2e18b7eb96
Check playlist exists in manager. Fixes issue 3878
2013-10-03 20:36:46 +02:00
Arnaud Bienner
253a8ffde4
Add save action from playlistlist tab, so we can save favorite playlists without opening them.
...
Remove unnecessary/duplicate actions from playlistlist tab.
2013-05-23 20:09:35 +02:00
Arnaud Bienner
5e6821dead
Add a 'favorite' widget to playlist tab, and keep in playlistlist container only favorite playlists, instead of all playlists.
2013-05-11 23:18:03 +02:00
David Sansome
9fae3881ed
Add a new "Playlists" tab to the sidebar that contains all the playlists created by or imported into Clementine. The tab bar now contains only "open" playlists - closing a tab closes the playlist without deleting it.
...
Update issue 1811
Added a Playlists tree view to the sidebar.
2012-10-30 23:04:22 -07:00