598e660aeb
Unref bus in SongLoader::LoadRemote()
...
See: https://developer.gnome.org/gstreamer/stable/GstPipeline.html#gst-pipeline-get-bus
2021-07-14 10:17:50 +01:00
8c1bdc1a45
Changed to const reference
2021-04-28 21:51:12 +01:00
1646ab2221
Corrected comments + Added reference to Song& + use non-default
...
constructor for QFileInfo.
Forgot to apply clang-format so applied 2nd commit and squashed
both
2021-04-28 21:51:12 +01:00
66a34a906a
Removed unneeded empty arguments already provided by defaults
2021-04-28 21:51:12 +01:00
444f1e2e69
clang-format correction
2021-04-28 21:51:12 +01:00
b7a995d223
Re-added log message for URL and mime-type.
2021-04-28 21:51:12 +01:00
fb391a7fbe
Optimization to avoid save+delete of remote playlists to temporary file
2021-04-28 21:51:12 +01:00
341dc7326f
Reformat all C++
2020-09-22 14:56:06 +01:00
d3d6c1ff3c
Fix UNC paths.
...
The fix-up for URLs for files that that begin with // no longer works since the
QUrl class determines that these modifications are invalid, resulting in an
empty string when converted. Instead of attempting to modify the QUrl, add a
utility function that makes the correction on the encoded byte array at time of
usage.
2020-01-29 00:38:43 -08:00
babff78025
Add error handling path for async song loading.
...
Async song loading can fail without user feedback. This change adds return codes
to these async load functions. It will now produce an error dialog in simple
scenarios (test case is user selecting a file that is not readable). Other cases,
such as directories and playlists, aren't yet covered.
2019-04-10 11:49:09 -07:00
95187ed0a1
Fix encoding of GError messages when logging. ( #6228 )
...
GError messages contain non-ascii characters. This normally just produces some garbage when we use the default QString contructor that assumes ASCII for logging. However, when a message includes the right double quote, UTF-8 sequence 0xE2 0x80 0x9D, the final byte is OSC. VT100 expects a command sequence to follow and stops echoing output until it sees ST or BEL character, which may never come. Thus, the console output is halted.
This change uses QString::fromLocal8Bit instead of depending on the default constructor. About half of the sites in the codebase had already been converted.
One side effect is that log messages are quoted. There are additional options to control this, but those were only introduced in Qt 5.4.
2018-12-02 09:51:19 +00:00
107e945872
Convert uses of QtAlgorithms to std:: algorithms
2018-10-09 19:17:54 +01:00
35e274c497
Refactor SongLoader::LoadRemotePlaylist()
2017-03-21 10:50:12 +00:00
f609bc793f
Fix remote-playlist load
2017-03-21 10:50:12 +00:00
fa9ea6ec5f
Fix compilation with moved files in internet/
2014-12-18 23:35:21 +01:00
64c34f58ae
Merge pull request #4608 from sobkas/src_core_fix
...
Fix the copyright info and formatting in src/podcast and src/core
2014-11-27 15:17:16 +01:00
ff91759b71
Fix Ubuntu PPA
...
Adds a missing check for libcdio.
Adds libcdio as a dependency for debian.
Fixes issue #4618
2014-11-19 15:45:05 +09:00
6efb5d05b7
Fix some problems
2014-11-05 17:48:04 +01:00
39a3b46ead
More copyright info fixes
2014-11-05 17:48:04 +01:00
0af1470cce
Clean up src/core
2014-11-05 17:48:03 +01:00
dc0d3436c8
Finish CD integration update to Gstreamer 1.0
...
Move everything related to CDDA to a seperate class, so we can more easily reuse it in SongLoader
2014-10-26 03:32:37 +01:00
a8266173c5
Start to reactivate audio CD support
2014-10-26 00:28:03 +02:00
39d99247a2
gstreamer-cdda is in gst-plugins-base in 1.0 and has a different header name.
...
This still doesn't work because the API has changed and track listings are
now delivered via a bus message instead of direct access to the struct's
members.
2014-09-22 22:28:53 +10:00
a2408f7c0e
Merge branch 'master' into gstreamer-1.2
...
Conflicts:
src/moodbar/moodbarloader.cpp
2014-09-21 19:39:27 +10:00
47108a9a68
Add a message in CMake to notify that ccache has been found and will be used (+ some minor, unrelated things).
2014-08-06 20:05:41 +02:00
6bb81328e8
Merge branch 'master' into gstreamer-1.2
...
Conflicts:
ext/clementine-spotifyblob/mediapipeline.cpp
gst/moodbar/gstfftwspectrum.c
src/core/songloader.cpp
src/core/songloader.h
src/engines/gstengine.cpp
src/engines/gstenginepipeline.cpp
src/moodbar/moodbarpipeline.cpp
src/musicbrainz/chromaprinter.cpp
src/transcoder/transcoder.cpp
src/ui/mainwindow.cpp
src/visualisations/projectmvisualisation.cpp
2014-06-09 16:20:24 +10:00
a056a87c8e
Coding style fixes for async song load.
2014-04-07 15:27:47 +02:00
0d199be5a7
Load all songs that require disc-read non-blocking.
2014-04-02 15:57:01 +02:00
3323c2d094
Convert all instances of foreach() to a C++11 for
...
find ext src -name '*.cpp' -exec \
sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
bebd781fdf
Reformat all non-3rd-party C/C++/Objective-C++.
...
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
-style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
71893e4847
Use nullptr instead of NULL everywhere.
2014-02-06 17:29:59 +01:00
d309d4ab27
Use c++11 instead of boost where possible.
2014-02-06 16:51:39 +01:00
5ac83bd463
Merge branch 'master' into gstreamer-1.2
2014-01-25 00:24:31 +11:00
f816a47ad9
Make SongLoader add URLs as raw streams if there exists a URL handler
...
for that scheme. This fixes a bug where sky:// URLs couldn't be added
with MPRIS.
2014-01-24 23:54:38 +11:00
56c949815b
First pass at Gstreamer 1.0 porting.
...
This at least compiles against gstreamer 1.2.
Things that work:
* Playing audio
* Automatically completing tags
Things that don't work
* Spotify
* Moodbar
Things I haven't tested
* Transcoding
2013-09-26 17:49:24 +02:00
115964d1b4
Load local tags asynchronously in SongLoader.
2013-02-17 18:19:05 +11:00
4acafb4930
Remove some old code
2013-02-17 18:10:08 +11:00
90803fa0e0
Remove use of deprecated gstreamer functions.
2013-01-29 13:19:26 +01:00
41f89904b6
Compare against the translated message text to determine whether a typefind failed. Fixes radio playlists in non-english languages. Fixes issue 3394
2013-01-04 21:16:26 +11:00
fddce90624
Use boost::bind & boost::function instead of std equivalents for better compatibility.
2012-11-21 17:17:37 +01:00
1fd0515168
Make variadic version of ConcurrentRun::Run()
2012-11-21 16:39:10 +01:00
0e3dc5a8be
Add new ConcurrentRun templates for void functions, and functions with 3 arguments + corresponding test cases.
...
+ SongLoader now has its own QThreadPool to load folders/playlist in background.
Update issue 2598
This should fix slowliness problems reported.
2012-07-16 00:06:55 +02:00
7f89e8832e
When loading songs aync, always load the first song of our list, as it may be played immediately once added to the playlist
...
Fixes issue 2598
2012-07-14 00:53:42 +02:00
cbc650f44b
Use CHECKED_GCONNECT instead of g_signal_connect everywhere.
2012-06-08 15:34:00 +02:00
e9ace3a2cb
Support loading a spotify URL from the command line.
2012-03-22 16:55:05 -07:00
2750877a72
Support iTunes and Zune podcast URL schemes through SongLoader
2012-03-11 18:14:53 +00:00
f16fc8867e
Allow podcasts to be added through the normal SongLoader mechanism (dragging to the playlist, on the commandline, "Add Stream", etc.)
2012-03-11 17:57:15 +00:00
c27b8a5e95
Fix some broken behaviour in SongLoader when loading a playlist that was bigger than one GstBuffer. The pipeline would be stopped early because it was still asynchronously moving to the PLAYING state.
2012-03-11 17:20:12 +00:00
4618651cf4
Merge branch 'master' into external-tagreader
2012-01-07 22:52:18 +00:00
e9c0b4bd69
Musicbrainz tagging improvements:
...
* Fix a bug where the song title would be used for the album field
* Get the album's year as well
* Include all releases for a song in the results list
* Remove duplicate albums
* Sort results
2012-01-07 21:51:02 +00:00
Jonas Kvinge
diracsbracket
John Maguire
Jim Broadus
Amish Naidu
santigl
Krzysztof Sobiecki
John Maguire
Arnaud Bienner
David Sansome
Alexander Bikadorov