281da05325
transcoder: Provide user feedback in options error condition
...
Remove condition that allows no dialog to be displayed when user selects
options for transcoding. Display the dialog with an error message
instead. This also applies to the transcode options dialog in the
ripping and network remote settings.
2021-02-02 09:58:20 +00:00
b735f5d1c3
transcoder: Change TranscoderOptionsDialog constructor
...
Take a reference to a TranscoderPreset object instead of the the type.
This will allow the dialog to provide better information and correct
options.
2021-02-02 09:58:20 +00:00
341dc7326f
Reformat all C++
2020-09-22 14:56:06 +01:00
1a2274bd2b
Merge branch 'master' into qt5-update
2019-07-21 14:20:59 +02:00
be827f4f7f
Simplify some statements
2019-02-22 18:49:48 +01:00
d4fab4a2ea
Merge remote-tracking branch 'upstream/master' into qt5-update
2018-11-11 22:46:07 +01:00
107e945872
Convert uses of QtAlgorithms to std:: algorithms
2018-10-09 19:17:54 +01:00
c29c2e95cc
Fixed merge conflicts
2018-09-30 15:11:06 +02:00
e9a4db0192
Prevent closing of the RipCDDialog if the ripper is running
...
This prevents a segfault when a running dialog is closed and later reopened.
2018-07-07 10:23:49 +01:00
10d4c502fd
Set the parent to avoid a memory leak
2018-07-06 17:09:21 +01:00
3e53e23bb8
Fix formatting
2018-07-06 17:09:21 +01:00
2c084e45b6
Finnish immideately if there are no tracks to rip
2018-07-06 17:09:21 +01:00
059b5ed04f
Add Musicbrainz integration to the cd ripper
2018-07-06 17:09:21 +01:00
ff7026c9fe
Merge remote-tracking branch 'upstream/master' into qt5
2015-12-13 20:05:12 +01:00
dd953fd86c
check custom icon location, then system theme & then fallback theme
...
icons added & replaced
2015-10-13 22:35:49 -05:00
41d7d792ae
Show track durations in the CD ripper dialog.
...
The duration in seconds is computed using integer division which should be close enough.
2015-10-11 12:18:15 +02:00
631a6cdabd
Merge branch 'master' into qt5
2015-09-16 17:40:54 +02:00
aad6401cec
Use consistent string replacment scheme
...
Make the CD ripper dialog use the same naming scheme for replacement
strings as the organise dialog.
2015-06-16 16:47:20 +02:00
e986ab5a4b
Merge master branch and adapt it to qt5
2015-04-16 17:16:34 +02:00
8ad0e93381
Construct file paths correctly on all platforms
2015-02-20 19:19:45 +01:00
666faa5b37
Simplify some things. Use iterators instead of non-const references in
...
two loops.
2015-02-19 13:31:53 +01:00
f7185101ce
Update the target file name after transcoding
...
After a transcoding job is complete, we need to update the corresponding
filename since the transcoder, rather than overwriting an existing file,
changes the filename of the output file. This ensures that the right
file is tagged later on.
2015-02-19 11:07:06 +01:00
7d0d7be568
Some ui changes to the ripcd dialog.
...
- Move the Rip audio CD menu item to the Tools menu.
- Hide the progress bar if the CD ripper isn't working when the CD ripping
dialog is shown.
2015-02-18 20:08:02 +01:00
eed0c0d45f
Assorted edits to the ripper class.
...
- The constructor of the AlbumInformation struct now takes no arguments.
- Only add tracks to the rip list if their track numbers are valid.
- Only call cdio_get_media_changed if we have a valid cdio_ object.
- Add a description of the ripper class.
2015-02-18 20:08:02 +01:00
fc2e4db229
Split the CD ripper into two classes
...
Separate the cd ripper dialog from the ripper itself.
2015-02-18 20:08:02 +01:00
eb8a618197
Move the CD ripper into its own directory.
2015-02-18 20:08:02 +01:00
Jim Broadus
John Maguire
Jonas Kvinge
Filip Gawin
Amish Naidu
Mattias Andersson
Chocobozzz
narunlifescience