Commit Graph

433 Commits

Author SHA1 Message Date
David Sansome 4e9a7ca7f3 Load all the metadata for the first song, so the duration will appear properly when it starts playing. 2014-05-11 17:35:23 +10:00
Mark Furneaux d0ca2cef6c Comment remove 2014-04-25 23:02:42 -04:00
Mark Furneaux ce8b7303c0 Formatting 2014-04-25 22:50:52 -04:00
Mark Furneaux c890af6306 More elegant solution to last commit
set_current_row now takes optional parameter "is_stopping" for when auto stop
is enabled.
2014-04-25 22:45:25 -04:00
Mark Furneaux 416d06bb06 Fix stop after track
Stop after track would cause now playing widget, OSD, and last.fm
scrobbler to change to next track after stopping. This patch prevents
set_current_row() from firing an event which triggers the track change.
2014-04-25 14:30:31 -04:00
Alexander Bikadorov a056a87c8e Coding style fixes for async song load. 2014-04-07 15:27:47 +02:00
Alexander Bikadorov 0d199be5a7 Load all songs that require disc-read non-blocking. 2014-04-02 15:57:01 +02:00
Alexander Bikadorov 27e1c16e8a Debug logging when saving a playlist. 2014-03-18 16:14:12 +01:00
Alexander Bikadorov d023b56cea Avoid saving the playlist multiple times. 2014-03-18 16:13:38 +01:00
John Maguire 5146bcdebc Some more NULL -> nullptr conversions. 2014-02-21 17:30:46 +01:00
Alexander Bikadorov 3adaf5d598 fixed indentation / coding style 2014-02-11 13:18:08 +01:00
Alexander Bikadorov c7ac2012b4 correct selection after removing rows in playlist 2014-02-10 16:51:43 +01:00
John Maguire 192b60d965 Use nullptr as parent parameter default everywhere 2014-02-10 16:03:54 +01:00
John Maguire 3323c2d094 Convert all instances of foreach() to a C++11 for
find ext src -name '*.cpp' -exec \
    sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
Dave Sansome 89369029ab Merge branch 'skip_track' of https://github.com/asiviero/Clementine into asiviero-skip_track
Conflicts:
	src/playlist/playlist.cpp
	src/playlist/playlistitem.h
	src/ui/mainwindow.cpp
2014-02-08 13:19:23 +11:00
John Maguire bebd781fdf Reformat all non-3rd-party C/C++/Objective-C++.
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
 -style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
John Maguire 71893e4847 Use nullptr instead of NULL everywhere. 2014-02-06 17:29:59 +01:00
John Maguire d309d4ab27 Use c++11 instead of boost where possible. 2014-02-06 16:51:39 +01:00
Mladen Pejaković 657bbcf00f Fix for pull request #4170 2014-02-04 15:04:19 +01:00
Mladen Pejaković 033d266fe9 Add contexts to some translation strings 2014-02-03 21:54:02 +01:00
asiviero c0132b2ed3 Renaming skip properties, strike out track when it is to be skipped 2014-01-27 00:26:51 -02:00
David Sansome f816a47ad9 Make SongLoader add URLs as raw streams if there exists a URL handler
for that scheme.  This fixes a bug where sky:// URLs couldn't be added
with MPRIS.
2014-01-24 23:54:38 +11:00
asiviero c817431593 Greying out song and added verification to next on album mode 2014-01-20 22:35:01 -02:00
asiviero 5c21768760 Minor fixes and label adjustments 2014-01-20 22:10:23 -02:00
asiviero 1c0a221563 Added skip track feature 2014-01-20 22:10:16 -02:00
asiviero 048c2d9b9c Modified queue to store tracks to skip 2014-01-20 22:10:08 -02:00
David Sansome d3749eace9 Select the current item if the selection is empty when using Tab to move from
the playlist filter to the playlist view.  Fixes #4116
2014-01-14 20:07:03 +11:00
John Maguire 1a972e0f36 Fix rendering of source icons in playlist view on retina OS X 10.9 2014-01-10 16:57:32 +01:00
David Sansome 8416188056 Show a message in the Devices pane on Windows to say that most devices won't work. Fixes #4059 2014-01-05 11:32:07 +11:00
Arnaud Bienner 2a0f1266ce Revert "Disable inline editing with 'SelectedClicked'. Still available using F2. Fixes 3251 (once again)."
This reverts commit 4a1d3e2de6.
2013-11-30 18:10:20 +01:00
Arnaud Bienner 4a1d3e2de6 Disable inline editing with 'SelectedClicked'. Still available using F2. Fixes 3251 (once again). 2013-11-22 21:55:46 +01:00
Arnaud Bienner 3715e5f15e Revert revision 316b5d7db4 and revision e7a5c482fe (aka re-enable inline editing) 2013-11-22 20:59:31 +01:00
Arnaud Bienner 316b5d7db4 (Add a comment to explain why I removed this) 2013-11-17 19:42:06 +01:00
Arnaud Bienner e7a5c482fe Don't allow tag inline editing anymore.
This was a pretty good idea, but now we have a dedicated tag dialog editor, I'm not sure it is very useful. It was probably faster to edit tags this way, but I'm afraid lot of people may inadvertently modify their tags because of this. Still allow inline editing of score and comment, because they sound less critical to me.
Fixes issue 3251.
2013-11-17 19:00:44 +01:00
Arnaud Bienner 2e18b7eb96 Check playlist exists in manager. Fixes issue 3878 2013-10-03 20:36:46 +02:00
Arnaud Bienner fb78321c16 Don't ignore Folder (so we don't ignore playlists they contain and we don't end up with dangling pointers in playlists_by_id_) 2013-10-02 22:58:47 +02:00
Mateusz Kowalczyk aa347d0a57 Don't ask about closing the playlist if it's empty
Fixes issue 3827.
2013-08-28 21:38:17 +02:00
Andreas 2c0b505b7b Append playlist id to new playlists. 2013-08-17 15:54:39 +02:00
Arnaud Bienner 379b8743f9 Force the position of the checkbox for the confirmation prompt (looked bad on Windows) + update an old, not up to date comment 2013-08-11 16:36:28 +02:00
Arnaud Bienner 9f38f14fbf Don't really need the QObject:: here 2013-08-10 21:46:17 +02:00
Arnaud Bienner e3c5f3398c Add a "don't prompt me again" checkbox to the "warn_close_playlist" message box 2013-08-10 20:18:29 +02:00
Andreas 4fe293b6d0 The insert and remove signal for a playlist was not correct. 2013-07-31 19:06:29 +02:00
Arnaud Bienner 00a0e990fd Correct typo 2013-07-28 15:37:02 +02:00
Arnaud Bienner f75c0a2b97 Add an option for not being asked before closing a playlist 2013-07-27 19:59:15 +02:00
Andreas 1e4819f2df Add stop after current track feature to network remote. 2013-07-20 19:38:37 +02:00
Arnaud Bienner b53e58d407 Ask user for confirmation before closing a non-favorite playlist, as it will be deleted. Don't ask if middle-clicked 2013-07-18 00:37:31 +02:00
Arnaud Bienner f245f7ed82 Add a playlistlist view with a helper text 2013-06-29 18:05:03 +02:00
Arnaud Bienner 77d80fc60b Add a playlistlist view with a helper text 2013-06-29 18:05:00 +02:00
Arnaud Bienner a5e6c3273c Delete a playlist when unstaring it from the left 'Playlists' panel and when it's not opened 2013-06-29 16:16:52 +02:00
Arnaud Bienner cee18eebb2 Add a tooltip to the favorite widget 2013-06-29 16:12:53 +02:00