Commit Graph

906 Commits

Author SHA1 Message Date
David Sansome 5f05353939 Change Name to Action in the Configure Shortcuts settings page. Fixes #4310 2014-05-24 13:29:46 +10:00
Mattias Andersson 4569bd9f2f Check for error when getting the number of cd tracks. Build an empty
track list table if this is the case.
2014-05-22 07:51:08 +02:00
Mattias Andersson 0c76ca3c45 Don't start ripping unless the user has selected some tracks. 2014-05-21 18:07:48 +02:00
John Maguire 7702271fe6 Merge pull request #4344 from paperbagcorner/fix-tagging
Improve the tagging and the track information handling in the CD ripper
2014-05-21 15:46:00 +01:00
Mattias Andersson 8bb19f1887 Save tags using async calls. 2014-05-21 16:36:46 +02:00
Mark Furneaux 805d8f85b0 Add icons to extras: hypnotoad, kittens, enterprise
Fixes totally critical bug #1601
2014-05-21 07:26:16 -04:00
Mark Furneaux bd87230301 Change constant format 2014-05-20 07:44:30 -04:00
Mark Furneaux 7fb30f2596 Add constants to track progress timers 2014-05-20 07:29:59 -04:00
Mark Furneaux b76af5f792 Increase update rate of track slider
Increases the refresh rate of the track progress bar to 25fps.
This looks much better with moodbars than the previous 1fps.
All the common code that use to run at 1fps still retains that
rate so the overhead due to this is negligible.
2014-05-19 11:51:40 -04:00
Mattias Andersson 7d4343a826 Give functions a more verbose name. 2014-05-18 14:39:21 +02:00
Mattias Andersson 2137ac4709 Keep working until tagging is complete. 2014-05-18 14:24:46 +02:00
Mattias Andersson 182c90ccf4 Run RipCD::TagFiles in a background thread. 2014-05-13 15:18:42 +02:00
Mattias Andersson 467a1443e4 Capture log messages from the transcoder. 2014-05-12 23:58:51 +02:00
Mattias Andersson 98fd82a371 Use the TagReaderClient to tag the files in the CD ripper instead of
using Taglib directly.
2014-05-12 23:57:11 +02:00
Mattias Andersson bbd83344b8 Initialise cancel_requested_ to false in the constructor's initialisation list. 2014-05-12 17:40:41 +02:00
Mattias Andersson 08f5af3320 Give the mutex lockers a tighter scope. 2014-05-12 17:24:35 +02:00
Mattias Andersson 919f7cbe94 Add a mutex to protect a variable shared between threads. 2014-05-12 16:14:33 +02:00
Mattias Andersson 6235e69ac4 Run 'make format' 2014-05-12 14:38:46 +02:00
Mattias Andersson be09f6e5c7 Merge branch 'master' into ripcd-cancel
Conflicts:
	src/ui/ripcd.cpp
2014-05-12 13:50:34 +02:00
John Maguire 5fe468456a Merge pull request #4171 from asiviero/master
Addressing #4165 and #4166
2014-05-12 13:20:26 +02:00
David Sansome 18f72f3ada Capture this lambda argument by value, since it's a local variable and won't be valid when the outer function exits. 2014-05-11 19:24:22 +10:00
asiviero d448ac1179 Replaced scoped_ptr by unique_ptr 2014-05-10 00:41:32 -03:00
Mark Furneaux 394d8e7b51 Add support for monitors in portrait mode
Album covers bound to width or height, whichever is smaller
2014-05-03 09:54:19 -04:00
Mark Furneaux 9156f8f389 Fix oversized album cover art
When viewing the "Full Size" album covers, if the cover was higher in
resolution than that of the monitor, it would get cut off. Also,
the window was resizable however the image was not. This patch makes
the dialog a fixed size and resizes the cover only if it is too large to
fit on the screen. It also now displays the dimentions of the original
artwork in the title bar.
2014-05-01 12:26:48 -04:00
asiviero 4b7c3a2f8c Using scoped ptr to ripcd window, removing extra parenthesis again 2014-04-29 23:12:18 -03:00
John Maguire b3ef8b0fe0 Try out actually using lambdas for something useful. 2014-04-23 18:05:59 +02:00
David Sansome c7459b1b28 Load songs in a background thread while initialising the Organise dialog 2014-04-23 21:46:05 +10:00
David Sansome 98a328cf97 Switch from foreach to for 2014-04-23 21:13:58 +10:00
David Sansome 25ee987ec7 Recursively add songs in subdirectories to the organise dialog. Broken in revision 35060d6. 2014-04-23 21:06:23 +10:00
Andre Siviero af34bf6062 Removing extra parenthesis 2014-04-16 11:07:50 -03:00
Mattias Andersson 773c3475ba Remove unnecessary string conversion. 2014-04-15 14:47:26 +02:00
Mattias Andersson 44025dc588 Add a call to cdio_get_media_changed in RipCD::CheckCDIOIsValid
This prevents an erroneous message that the media has changed the first
time the ripCD dialog is used.
2014-04-13 14:41:04 +02:00
Mattias Andersson 31400f2740 Run 'make format' 2014-04-12 09:20:25 +02:00
Mattias Andersson d66a73bed5 Merge remote-tracking branch 'origin/master' into HEAD
Conflicts:
	src/ui/mainwindow.cpp
	src/ui/ripcd.cpp
2014-04-12 09:08:21 +02:00
SATOH Fumiyasu 9add1ad708 Update Transifex URL 2014-04-11 16:30:57 +09:00
David Sansome 24404b4357 Make the "buffer low fill" string a bit more understandable 2014-04-05 22:03:36 +11:00
John Maguire 51385cc801 Add a different label for the mavericks shortcut settings.
Fixes issue #4002
2014-04-02 16:27:07 +02:00
John Maguire 30d1c2f8db Remove Ubuntu One support.
http://blog.canonical.com/2014/04/02/shutting-down-ubuntu-one-file-services/
2014-04-02 16:02:00 +02:00
Marcus Fritzsch 22c0a79924 gstenginepipeline: Do not use QString::sprintf() 2014-04-02 12:39:19 +02:00
Marcus Fritzsch e3bea84bea gstenginepipeline: make buffer min fill configurable 2014-04-02 11:54:14 +02:00
David Sansome 25544cb672 Sort the list of Internet Providers in the settings dialog and internet tab 2014-03-30 17:11:19 +11:00
David Sansome 9c66528c0f Add a settings page for OneDrive 2014-03-30 16:35:27 +11:00
David Sansome 2d7be1502f Get audio device names on OS X too. 2014-03-29 22:44:08 +11:00
David Sansome 6d1dc56a7c Get a list of available audio devices from pulseaudio, and let the user choose
from those in the settings dialog instead of just giving him a text box.
2014-03-29 19:31:38 +11:00
John Maguire 4ab4bbc23f Remove Last.fm radio support.
Fixes #4259
2014-03-28 14:55:04 +01:00
Arnaud Bienner 1b7f99127d Add login to SoundCloud + get user tracks and activties (stream)
Still need to handle playlists and to clean up things (e.g. to check why refresh_token doesn't work and if we can do something about this)
2014-03-26 21:33:27 +01:00
Maltsev Vlad a7b0accd93 Add Vk.com plugin. 2014-03-08 00:58:50 +07:00
John Maguire 5146bcdebc Some more NULL -> nullptr conversions. 2014-02-21 17:30:46 +01:00
John Maguire b46e9ff55c Seems this should be the other way around. 2014-02-14 15:51:08 +01:00
John Maguire c162a9316d Fix clang warning. 2014-02-14 14:36:47 +01:00
Arnaud Bienner faaa75cb61 Few style fixes + avoid unneeded copies 2014-02-12 22:11:28 +01:00
John Maguire 192b60d965 Use nullptr as parent parameter default everywhere 2014-02-10 16:03:54 +01:00
John Maguire 3323c2d094 Convert all instances of foreach() to a C++11 for
find ext src -name '*.cpp' -exec \
    sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
David Sansome 67f6560c04 Merge pull request #4194 from abika/master
Use double click settings as default behaviour for new files added as command line arguments.  Fixes #4183
2014-02-09 16:51:10 +11:00
Mladen Pejaković f09a0c00a8 More disabmiguations 2014-02-08 16:09:27 +01:00
Mladen Pejaković da535d6429 More disambiguations 2014-02-08 15:11:06 +01:00
Dave Sansome 89369029ab Merge branch 'skip_track' of https://github.com/asiviero/Clementine into asiviero-skip_track
Conflicts:
	src/playlist/playlist.cpp
	src/playlist/playlistitem.h
	src/ui/mainwindow.cpp
2014-02-08 13:19:23 +11:00
Alexander Bikadorov 2ab8ab8077 Use double click settings as default behaviour for new files added as command line arguments. 2014-02-07 20:28:37 +01:00
John Maguire 5469c0469e Merge pull request #4192 from pejakm/trfixes
[EditTag Dialog] Fix not displaying translated string
2014-02-07 17:21:55 +01:00
Mladen Pejaković 4c534e54ec [EdiTag Dialog] Fix not displaying translated string 2014-02-07 17:10:53 +01:00
Krzysztof A. Sobiecki 0ecf1e76a6 Reformat done with clang-3.5 svn200967 2014-02-07 17:08:31 +01:00
John Maguire bebd781fdf Reformat all non-3rd-party C/C++/Objective-C++.
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
 -style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
Mattias Andersson eb622b7e00 Do not translate ip address. 2014-02-07 13:00:24 +01:00
John Maguire 71893e4847 Use nullptr instead of NULL everywhere. 2014-02-06 17:29:59 +01:00
John Maguire d309d4ab27 Use c++11 instead of boost where possible. 2014-02-06 16:51:39 +01:00
asiviero 9a0b149877 Removed unnecessary clear and switched to clearContents on cdio not available 2014-02-05 10:25:47 -02:00
asiviero 62d919c1b5 Fixing segfaults, checking for cd change on the fly 2014-02-04 23:29:39 -02:00
Mattias Andersson 1b00e91fdf Add the ability to cancel a running CD rip. 2014-02-04 16:25:58 +01:00
Mladen Pejaković 657bbcf00f Fix for pull request #4170 2014-02-04 15:04:19 +01:00
asiviero d88c1fad04 Reset progress bar after cancel is pressed 2014-02-03 23:59:23 -02:00
asiviero 4251fd4331 Checks for CD before opening window (addresses #4165) 2014-02-03 22:40:56 -02:00
Mladen Pejaković 033d266fe9 Add contexts to some translation strings 2014-02-03 21:54:02 +01:00
Mattias Andersson 3bf44c78d4 Only remove the temporary directory if it has a non-empty name. 2014-02-03 15:14:08 +01:00
Mattias Andersson 4676e2839d Make the CD ripper clean up after itself. 2014-02-03 13:38:38 +01:00
Arnaud Bienner a349a96f5a Avoid having similar filenames when organising songs (number them instead) 2014-02-02 19:28:45 +01:00
Arnaud Bienner ee20103510 Set overwrite to false by default in organise dialog.
Too dangerous to be activated by default IMO.
2014-02-01 03:35:34 +01:00
John Maguire 7ddf3aab45 Merge pull request #4145 from sobkas/master
Initial support for "Copy to device" in a podcast section
2014-01-31 04:31:43 -08:00
Krzysztof A. Sobiecki e244c9cfb2 My fault, was testing something and forgoten to replace song.basefilename() 2014-01-30 15:08:53 +01:00
John Maguire b96ec7555a Reformat all Objective-C++ files with clang-format.
clang-format -style=Google -i src/*/*.mm
2014-01-30 14:54:51 +01:00
John Maguire 0a778e2901 Do not log IP address from network remote settings. 2014-01-30 11:50:52 +01:00
Mattias Andersson c36e073921 Add trailing underscore to class member variable. 2014-01-29 20:35:03 +01:00
Krzysztof A. Sobiecki 09d68bf415 Scrub the auto usage, use unique_ptr, use correct types instead of QList 2014-01-28 17:01:14 +01:00
Krzysztof A. Sobiecki b0a97de603 Use more auto in for statements 2014-01-27 23:59:38 +01:00
Krzysztof A. Sobiecki f7be18b326 Fixed some problems reported by cpplint.py, changed foreach to for in files touched by me 2014-01-27 23:59:38 +01:00
Krzysztof A. Sobiecki 4944e99d56 Fix copy functionality, break copy of a directory 2014-01-27 23:59:37 +01:00
Krzysztof A. Sobiecki b6c59bd4ca Fix whitespaces, Fix whitespaces, Fix whitespaces 2014-01-27 23:59:37 +01:00
Krzysztof A. Sobiecki 750354d8ca Clementine, don't lie to me 2014-01-27 23:59:37 +01:00
asiviero c0132b2ed3 Renaming skip properties, strike out track when it is to be skipped 2014-01-27 00:26:51 -02:00
Mattias Andersson 333b1636fa Adjust column widths. 2014-01-27 00:13:33 +01:00
Mattias Andersson a31223e45c Group the input options in the rip cd dialog. Disable input and output groups when there is a ripping in progress. 2014-01-26 21:20:36 +01:00
Mattias Andersson 76a91ded88 Remove the 'Alongside the originals' destination in the CD rip dialog since it doesn't make sense in this context. Use the home directory as initial destination instead. 2014-01-26 21:20:19 +01:00
Mattias Andersson 27b1bf7014 Add buttons 'select all', 'select none' and 'invert selection' buttons to the rip cd dialog. 2014-01-26 21:20:19 +01:00
Mattias Andersson 96e6252fca Style the Rip cd dialog
Set a specific tab order in the dialog.
Add a Clementine window icon.
Add a header for the first column in the table widget.
Change the button box to a cancel and a close button and make these behave as in the transcoder dialog.
Move the rip button to the button box.
Hide the progress bar if no cd has been ripped.
2014-01-26 21:19:02 +01:00
David Sansome 5ac83bd463 Merge branch 'master' into gstreamer-1.2 2014-01-25 00:24:31 +11:00
John Maguire 556fb62cd2 Mark cd rip output filename format string as not for translation. 2014-01-24 11:47:19 +01:00
John Maguire b594f44c64 Merge branch 'cdrip' of https://github.com/asiviero/Clementine
Fixes #3490
Closes #4113
2014-01-23 16:33:28 +01:00
Andre Siviero a827d71f4a Moving ifdef inside the function 2014-01-23 13:18:35 -02:00
Andre Siviero 8500dce6b3 Removing conditional from function definition 2014-01-23 13:17:48 -02:00
Andre Siviero 4f79898e2d Including the pointer rip_cd_ in a conditional 2014-01-23 11:47:51 -02:00
Andre Siviero fe45462034 Including the method definition in a conditional 2014-01-23 11:17:38 -02:00