3323c2d094
Convert all instances of foreach() to a C++11 for
...
find ext src -name '*.cpp' -exec \
sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
bebd781fdf
Reformat all non-3rd-party C/C++/Objective-C++.
...
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
-style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
71893e4847
Use nullptr instead of NULL everywhere.
2014-02-06 17:29:59 +01:00
d309d4ab27
Use c++11 instead of boost where possible.
2014-02-06 16:51:39 +01:00
10fb96341c
Resolved empty song name when searching through Grooveshark.
2014-01-04 16:55:41 +01:00
4d6406524f
Grooveshark now returns a different error code when session id is invalid
2013-12-16 23:01:12 +01:00
d8e2fa5b1c
Increase GS album search limit from 5 to 10. Also, use a constant instead.
2013-08-28 22:20:58 +02:00
b41a2b5308
Revert "Try out C++11 strongly typed enums."
...
This reverts commit 4e74c7af2b
2012-12-05 09:36:22 +00:00
4e74c7af2b
Try out C++11 strongly typed enums.
2012-12-04 16:22:09 +00:00
95ce26a556
Remove now obsolete connect in GS service
2012-10-15 22:06:16 +02:00
b9606d8a06
Ignore GS search's result if it's not the last one
2012-10-14 23:27:45 +02:00
16fe238d98
Port remaining calls in GroovesharkService to closures.
2012-10-12 13:43:55 +02:00
bb710ed2ef
Remove some excessive debug messages for Grooveshark.
2012-09-27 13:51:16 +02:00
606bf71208
Disable automatic conversions to QUrl from strings.
2012-09-26 17:09:13 +02:00
1cb0869970
Clean GS pending requests when removing items, and don't try to modify non-existing items when receiving obsolete replies. Fix a crash when user tries to refresh GS items before every reply has been received
2012-08-09 00:51:00 +02:00
c8b145c8b6
Remove useless code in groovesharkservice
2012-08-04 00:38:18 +02:00
b08172138a
Add a new PlayBehaviour (MultiplesItems) for loading playlits' songs by drag'n'drop for Internet services.
...
Use it for Spotify and Grooveshark.
2012-07-29 01:35:05 +02:00
13daaf7106
Don't show the search box for GS and Spotify if user isn't logged in
2012-07-21 20:15:36 +02:00
63c42503c6
Fix non-ending task in GS which may happen if the user log out (or is logged out because session became invalid)
2012-07-21 19:39:37 +02:00
07c7bd9bb2
Sort GS MyMusic songs by names, like other playlists
2012-07-21 18:47:18 +02:00
9a392692dd
Add missing const
2012-07-21 18:31:08 +02:00
77c6199dd9
Add GS 'My Music' support.
...
Fixes issue 2609
Retrieving and removing songs works well :)
Adding songs doesn't work :(
2012-07-21 18:09:16 +02:00
16fde37bac
Remove Grooveshark and Spotify search playlist: we don't use them anymore since we can search on these services through the Internet tab
2012-07-16 00:27:43 +02:00
c7aca6335d
Factorize some code for creating song item in Grooveshark and Spotify
2012-06-27 21:19:30 +02:00
3c5e91ce84
Remove action for opening GS search playlist
2012-06-27 21:19:04 +02:00
a57e2be7ec
Don't sort GS popular songs by name as they are already sorted by popularity
2012-06-27 18:44:17 +02:00
91930d470e
Correct bad indentation
2012-06-27 02:04:05 +02:00
b49c3db6e0
Sort retrieved GS songs only in some cases.
...
Indeed, even it makes sense sometimes (e.g. for playlists) it doesn't make sense at all for search results...
Make the sorting function part of Song.
2012-06-27 01:55:51 +02:00
ac936c5374
Search on Grooveshark on the left/Internet tab directly, instead of Grooveshark magic playlist.
...
Next steps:
- add GS albums search on the left tab
- do the same for Spotify if it's convincing enough
- clean-up magic search playlists
2012-06-27 01:21:57 +02:00
150d5a124a
Fix a crash and a never-ending task when expanding the Grooveshark item for the first time with an invalid or expired session.
2012-06-02 13:21:56 +01:00
d2f5a7f811
Use QString::localeAwareCompare instead of compare when sorting GS songs
2012-05-17 01:56:11 +02:00
2a661ec017
Fix Linux CLang Build
2012-05-17 01:52:05 +02:00
cd7d967271
Update issue 2398
...
Also sort GS songs by names
2012-05-16 01:37:06 +02:00
aaef0de224
Sort GS playlist by name. Fixes issue 2398.
2012-05-16 01:30:18 +02:00
ed11075930
Do the same for favorites
2012-05-11 21:46:07 +02:00
3356fd9b58
Add the ability to remove mulitple GS songs at once. Fixes issue 2933
2012-05-11 21:28:28 +02:00
e0d61eb66c
Check that popular_month_, popular_today_ and stations_ still exist (i.e. aren't NULL) when we receive replies.
...
Indeed, we do not need to be logged in to get results for popular songs and get stations tags. But if the user has been automatically logged out (e.g. session_id not valid anymore) these items have been deleted.
2012-04-04 19:21:18 +02:00
f98616b60b
Correct typo
2012-03-27 00:46:06 +02:00
bee99b7554
Ability to get a URL to share GS playlists
2012-03-27 00:43:47 +02:00
ce75c2827a
Add the ability to get a GS URL to share a song from Internet view
2012-03-26 23:57:26 +02:00
3d350b35e9
Add an icon to Grooveshark song URL message box
2012-03-26 23:32:42 +02:00
57e41af461
Use large covers for Grooveshark songs.
...
As now, there is possiblity to set cover as playlist background, it's nicer, with larger images.
2012-03-13 22:53:55 +01:00
204f7acbfa
Merge branch 'podcasts'. Fixes issue 44
2012-03-12 19:40:31 +00:00
75a897e92d
Don't require each InternetService to keep track of its own current index - do it in the model instead
2012-03-11 14:44:43 +00:00
d538b71809
Add buttons and menu items to open the Podcast settings page. Also route these requests through Application rather than InternetModel
2012-03-10 22:39:24 +00:00
3338174a1f
Do not set cover for Grooveshark songs if we don't have one.
...
This wrongly gives the impression that these songs have a cover
2012-03-08 23:44:35 +01:00
c2a4ca2cf8
Fix some missing reply->deleteLater() in grooveshark service
2012-03-08 21:26:27 +01:00
0969432820
emit GS albums songs results as long as we get them, instead of waiting to have all the results available.
2012-03-05 00:54:24 +01:00
0c1eca5ac1
Extract few other metadata info from GS results when initialising song.
...
However, currently these fields are filled only when calling getAlbumSongs(), unfortunately.
2012-02-28 23:22:09 +01:00
747e0f510f
When (global) searching GS albums, retrieve albums' songs at the same time (instead of album load time).
...
Albums search is slower, but we can display songs in search results, which is IMHO really nicer.
2012-02-26 16:51:11 +01:00
John Maguire
Antonio Nicolás Pina
Arnaud Bienner
David Sansome