Commit Graph

1006 Commits

Author SHA1 Message Date
vikramambrose 2e4a67b8da Add appearance option to hide playlist filter toolbar (#5942)
Gives the user the option of a cleaner looking interface if the
filter toolbar isn't used.
2018-01-03 15:24:56 +00:00
Mattias Andersson b724291ef9 Ensure that the correct playlist is played (#5929)
When the playlist doubleclick behavior is set to add songs to the queue,
the playback of the queue also starts if no song is currently
playing. To play the queue from the current playlist, we must set the
active playlist to the current one before starting the playback.

Fixes #5714.
2017-12-14 21:48:03 +00:00
Victor Parmar eab875c46d Add support for deleting the currently playing track via the commandline (#5899) 2017-11-21 10:02:36 +00:00
Adrian Garcia 27fc915921 Add settings option to stop playback if song fails to play (#5905) 2017-11-21 10:00:36 +00:00
Allan Nordhøy b581f2454a Spelling: Hip Hop (#5843)
https://en.wikipedia.org/wiki/Hip_hop Though inconsistent, this never uses "HipHop". While that could be perceived as the name of the equalizer, "Hip Hop" is at least consistent with the other EQs.
2017-08-29 02:09:05 +02:00
Krzysztof Sobiecki dad0c8f314 [win32] Fix build in src/ui/ (#5784)
It looks like there is a problem with build of src/ui/appearancesettingspage.cpp
It might fix it.
2017-08-16 15:09:55 +01:00
Jacob Henner 203ec76973 Add contextual searches to playlists, library and global search. (#5649)
* Closes #5567: Contextual album/artist search in library search, global search, and playlists.

* Change artist/album search to 'search for this' in globalsearch

* Change artist/album search to 'search for this' in library

* Applying patch from @Fat-Zer to allow search incl year

* Re-adding missing schema definition
2017-08-09 14:12:36 +01:00
David Roeca 49876536a5 Resolve #3693 (#5790)
* bring in playlist updates for potential fix

* define signal to handle organise playlist bugs

* work in progress

* fix wrong signal/slot

* next push forward on handling new song creation

* Reorganize signals/slots; still need to figure out why not all signals are being handled

* Get playlists to work when they're in memory

* more changes to playlist updates

* revert unnecessary changes and finalize fix
2017-07-22 18:57:33 +01:00
Alex Bikadorov 8953227c65 New shortcut: remove current playing song from playlist (#5723) 2017-05-31 17:59:36 +01:00
Yan Pashkovsky 583eb25cfc Gtkicons (#5742)
* sys icons tick in settings

* system icons loading support

* system icons loading, style fixes
2017-05-30 21:25:24 +01:00
Elias Lattash f854bc5deb Simpler iconloader::Load() logic (#5706)
This fixes a bug when clementine uses an icon from the system, even though it exists in it the *data* folder.

For example: the icons at the top of *playlistlistview.ui*, and at the top of *fileview.ui*
2017-05-08 12:07:59 +01:00
Grace Dolphy 52f1982353 Delete Undo Fix Attempt - Should Solve Issue #5701 Using Clementine to delete a song from disk should not be added to the undo stack (#5702)
* Fix delete functionality. Skips to next song if deleted song is also currently playing.

* Added in a bool to determine if the song being deleted is meant to be deleted from the disk or just from the playlist. Took advantage of the unused variable located in removeRows to distinguish between the two options. No longer adds delete from disk to the undo stack, and deleting from the playlist goes to undo stack as it should.

* Added in a bool to determine if the song being deleted is meant to be deleted from the disk or just from the playlist. Took advantage of the unused variable located in removeRows to distinguish between the two options. No longer adds delete from disk to the undo stack, and deleting from the playlist goes to undo stack as it should.

* Update mainwindow.cpp

* Formatting Changes

* Update playlist.cpp

Simplified condition statement.

* Added in a missed boolean for RemoveSelected

* Update playlistview.cpp
2017-04-18 14:29:25 +01:00
Grace Dolphy 672d00be05 Fixes the issue "Seek instead of navigation with arrow keys #5550". Now allows the leaf to be closed by arrow left at any point of the leaf, not only the parent, and if the library is focused and arrow keys are pressed and there is nothing to open or close, the request is ignored (no seek) (#5684) 2017-03-30 18:02:49 +01:00
Santiago Gil 0b34586e52 Fix some warnings shown on start-up (#5679)
* Fix 'RGB parameters out of range' with psychedelic colors

* Fix 'edit-find' icon name

* BlockAnalyzer::drawBackground(): do not attempt to paint on a null background

* Use qBound()
2017-03-27 12:57:24 +01:00
Santiago Gil 62bc647cbc Roll back to the cache naming conventions for covers (#5651) 2017-03-07 11:46:54 +00:00
santigl 99ad5dcd2d Refactor EffectiveAlbumArtistName() 2017-03-06 18:47:34 +00:00
santigl f5bd7ef5c0 ItemHasCover(): Replace pointer with reference 2017-03-06 18:21:27 +00:00
santigl 82f0d261fa Use the 'effective_album' title when searching for a track's cover 2017-03-06 18:21:27 +00:00
santigl 2c643513e2 Refactor icon handling. Make empty-cover filtering work again. 2017-03-06 18:21:27 +00:00
santigl deb7c33c64 Add support for 'album artist' field in the LibraryBackendInterface 2017-03-06 18:21:27 +00:00
santigl 58b7c62f25 Make Cover Manager aware of 'album artist' field 2017-03-06 18:21:27 +00:00
santigl 62cec8cf28 Prioritize album artist in cover search and manager 2017-03-06 18:21:27 +00:00
Domenico Iezzi 3b51f80fa3 Small improvements to Cover Manager (#5645)
* nocover icon was previously loaded and used with the default size
(24x24), causing the list item without a cover in the QListWidget to be
shorter in height with respect to the others. Now the icon is
initialized to 120x120, which is the default size of the list elements.
* Added some padding between "Fetch Missing Cover" and "Export
Covers" buttons.
2017-03-03 11:49:47 +00:00
John Maguire becb0b3d7f Remove some stray vkontakte code 2017-01-11 18:51:12 +00:00
John Maguire c7b8aacad8 Remove support for VK
Fixes #5591
2017-01-11 18:08:43 +00:00
Marko Hauptvogel 57d00394ee Bugfix for resume playback on start
This fixes issue #5365.

Because of the asynchronous loading of playlists introduced by
09e83935, the resume playback on startup logic finds the active
playlist as empty, because it is not restored yet. By attaching
the playback resume to the RestoreFinish signal, the playback
will be triggered as soon as the playlist is restored. It may be
possible (but unlikely) that the playlist will already be restored
before we wait for the signal, and playback won't be resumed.

Signed-off-by: Marko Hauptvogel <marko.hauptvogel@googlemail.com>
2017-01-05 17:09:57 +00:00
Santiago Gil d3898d2f47 Add dialog to display streams' audio details (#5547)
* Add Stream Details window

* Fix capitalization in StreamDiscoverer::Discover()

* StreamDiscoverer::Discover(): get URL by const reference

* Refactor StreamDiscoverer::Discover

* Rename StreamDiscoverer callbacks

* StreamDiscoverer::OnDiscovered: fix nullptr comparison

* StreamDiscoverer: rename DiscoverFinished signal

* StreamDiscoverer::DataReady: receive const reference

* StreamDiscoverer: Remove unsigned types

* StreamDetailsDialog: rename Close slot

* StreamDetailsDialog: rename ui pointer to ui_

* MainWindow::ShowStreamDetails: receive a const reference

* StreamDetailsDialog: use unique_ptr, remove unsigned types
2016-12-21 16:57:04 +00:00
Santiago Gil 8da53abcfa Add option to show/hide sidebar (#5459) 2016-09-06 07:28:25 -05:00
Ilya Selyuminov 09b0fab87c Add new command line option for creating a new one playlist #5373 (#5468) 2016-08-26 08:59:11 -05:00
Santiago Gil 3d399cec8c Restructure edittagdialog layout (corrects #5437) (#5450) 2016-07-25 11:45:57 +01:00
Mattias Andersson 0b6d531bd3 Focus the library tab when using the 'Show in library' feature 2016-07-01 11:37:04 +02:00
Yan Pashkovsky a879b8c7fd make format 2016-06-01 21:58:35 +03:00
Yan Pashkovsky a9a616863d Scrolling over tray icon support 2016-05-30 02:12:03 +03:00
John Maguire 0beb6d3c59 Remove support for Amazon Cloud Drive. 2016-05-16 18:00:10 +01:00
Alex 11670e1760 Fix playlist behaviour (#5330)
* Do not restore playback state on application start if overwritten by command line options

This also fixes unwanted pausing if a new instance is started with commandline URL combined with playback restore.
Note that the actual buggy code (MainWindow::ResumePlayback()) is not fixed here.

* Fix for commandline URLs for new instances are always appended to playlist.
2016-04-12 15:53:43 +01:00
Ivan Leontiev 75d4731534 Move global search settings loading later in "MainWindow" initialisation
Fixes #5312.
2016-03-30 04:58:47 +03:00
René Tronsgaard Rasmussen 8e70046e4b Add -q,--stop-after-current commandline flag 2016-03-18 20:21:34 +01:00
John Maguire dcdd81d69f Moar Lazy migrations 2016-02-12 16:10:56 +00:00
John Maguire b99b090adc Refactor simple dialogs to use Lazy 2016-02-12 16:01:35 +00:00
John Maguire 74e6a1744f Convert edit tag & settings dialog to Lazy. 2016-02-12 15:56:08 +00:00
John Maguire 589f2ff62e Lazy initialise organise dialog 2016-02-12 12:25:35 +00:00
John Maguire 729dc8e281 Merge pull request #5182 from abika/fix-fetch_edit_dialog
Fix bug in edit tag dialog when fetching (2)
2016-02-11 15:30:51 +00:00
John Maguire f2daa772c1 Lazy initialise everything in Application. 2016-02-11 15:15:38 +00:00
Alexander Bikadorov 56e95839f0 Revert to iterator usage in edit tag dialog 2016-02-11 16:09:38 +01:00
John Maguire 6844dcc140 Remove unused variable 2016-02-11 14:19:01 +00:00
narunlifescience b6bf54be6c remove magic numbers 2016-02-11 04:41:37 -06:00
Alexander Bikadorov 9d413ad01d Edit tag dialog: merged duplicate code 2016-02-09 21:56:22 +01:00
Arun Narayanankutty 29b8d308b3 Use icon loader for remaining icons 2016-01-14 06:10:54 -06:00
John Maguire c9b0bb2044 Revert "Add an option to inhibit suspend while playing" 2016-01-08 15:09:07 +00:00
John Maguire a9b5947fb0 Merge pull request #5150 from narunlifescience/master
Add an option to inhibit suspend while playing
2016-01-07 18:32:29 +00:00