Jonas Kvinge
320a1b81c9
Fix incorrect use of QFutureWatcher
...
To avoid a race condition, it is important to call setFuture() after doing the connections.
See: https://doc.qt.io/qt-6/qfuturewatcher.html
2021-07-14 10:18:15 +01:00
Jim Broadus
e7364263b2
build: Move minimum cmake version to 3.0.0
...
Compatibility with versions prior to 2.8.12 is being deprecated,
resulting in build warning messages. The minimum for the official
supported distros is 3.7.2 (Stretch), so the version could be moved
forward when newer features are required.
Reference: https://cmake.org/cmake/help/v3.19/release/3.19.html#deprecated-and-removed-features
2021-04-17 16:24:46 +01:00
Jim Broadus
1a3828e2c1
protobuf: Fix namespace conflict
...
Protobuf 3.15 adds a namespace alias for "pb" that conflicts with
Clementine's. Modify Clementine to use "cpb".
Patch provided by @ahesford
Reference: 5c028d6cf4/src/google/protobuf/port.h (L44)
2021-02-21 14:17:26 +00:00
Robert-André Mauchin
cfcd0a956e
Drop -std=c++0x and -U__STRICT_ANSI__
...
This was causing compilation failures, static assertion failed, with GCC 11.
Fix #6865
Signed-off-by: Robert-André Mauchin <zebob.m@gmail.com>
2020-12-17 11:28:09 +00:00
Pierre Langlois
6285c11bc3
Fix tranlations test.
...
"Library" is translated to "Fonoteca" since
1504d8be1c
2020-04-17 11:42:03 +01:00
John Maguire
cb6cd7c485
Merge remote-tracking branch 'origin/master' into qt5
2019-10-04 16:51:43 +01:00
luz.paz
fb93ae4b02
Fix misc. source comment typos
...
Typos found via `codespell`
2019-08-21 23:43:16 -04:00
Jonas Kvinge
8c198a99a5
Qt 5 fixes
2018-11-21 10:31:17 +00:00
Andreas Sturmlechner
a4e362b9f7
Fix cmake with Qt 5.11_beta3 (dropping qt5_use_modules)
...
One usage of the macro remains in the bundled libmygpo-qt5. This should
be updated once the pending upstream fix was merged. qtsingleapplication
is already fixed upstream.
2018-04-16 01:33:15 +02:00
Florian Bigard
69b2a832db
Merge branch 'master' into qt5
2017-01-18 15:57:07 +01:00
Golubev Alexander
789c4924f4
Fix a typo in a header guard ( #5570 )
2016-12-27 00:12:54 +00:00
Chocobozzz
0aa3405274
Merge remote-tracking branch 'upstream/master' into qt5
2016-05-09 12:46:08 +02:00
Arnaud Bienner
f2228de5c9
Add some tests for MergeUserSetData
2016-04-17 19:33:52 -07:00
Chocobozzz
ff7026c9fe
Merge remote-tracking branch 'upstream/master' into qt5
2015-12-13 20:05:12 +01:00
John Maguire
84cc26f8b3
Support trackNum elements in XSPF.
...
Fixes #5093
2015-10-28 16:17:52 +00:00
Chocobozzz
631a6cdabd
Merge branch 'master' into qt5
2015-09-16 17:40:54 +02:00
Chocobozzz
e816131bf3
Fix compilation error when we don't have qt4 include directories for
...
lastm/echonest
2015-06-16 15:36:14 +02:00
Mattias Andersson
32b2afbb97
Parse the year of a disc from musicbrainz.
...
Run make format
2015-06-14 08:56:50 +02:00
Chocobozzz
369ff1be23
Update cmakelists min version to 2.8.11
2015-06-11 12:10:07 +02:00
Chocobozzz
32fe732f64
Adapt clementine tests to qt5
2015-04-16 18:54:42 +02:00
Chocobozzz
e986ab5a4b
Merge master branch and adapt it to qt5
2015-04-16 17:16:34 +02:00
Chocobozzz
42aafd247a
Update optional components to qt5
2015-04-15 18:26:09 +02:00
Chocobozzz
8b226c2171
Update non optionnals sources to qt5
2015-04-11 23:24:07 +02:00
Chocobozzz
ded70d6555
Update internals CMakeLits to qt5
2015-04-11 23:24:06 +02:00
Krzysztof Sobiecki
24b6fbf36c
Add ability to parse more of "innovative" datetime formats. close #4760
2015-02-27 02:11:53 +01:00
Chocobozzz
b96c1f060f
Add tests to check the tag edition of FLAC/OGG files and make format
2015-01-17 12:11:33 +01:00
Krzysztof Sobiecki
54f4e4e9e9
Fix tests
2014-12-23 22:39:54 +01:00
Arnaud Bienner
9f4aaee50e
Try to fix minimal build
2014-10-21 22:04:34 +02:00
Arnaud Bienner
f2eecadbd3
Don't write rating if not set
...
Fixes issue #4128
2014-10-21 21:49:23 +02:00
John Maguire
b3481a9839
Fix musicbrainz tests.
2014-08-11 15:38:55 +02:00
Mattias Andersson
ac162c3477
Move qRegisterMetaType back to SetUpTestCase(). Add comment
...
regarding ownership of the optional argument to MusicBrainzClient().
2014-06-02 16:34:03 +02:00
Mattias Andersson
9a06e7822c
Make mock_network_ a std::unique_ptr and create it in SetUp() instead of SetUpTestCase().
2014-05-30 21:56:33 +02:00
Mattias Andersson
e14c59948f
Add test for MusicBrainzClient.
2014-05-24 13:54:07 +02:00
John Maguire
8429e92b52
Remove obsolete configure #defines
2014-04-10 18:03:15 +02:00
John Maguire
5146bcdebc
Some more NULL -> nullptr conversions.
2014-02-21 17:30:46 +01:00
John Maguire
4902e8e2c7
Remove boost from tests.
2014-02-06 18:24:46 +01:00
Arnaud Bienner
a349a96f5a
Avoid having similar filenames when organising songs (number them instead)
2014-02-02 19:28:45 +01:00
David Sansome
f816a47ad9
Make SongLoader add URLs as raw streams if there exists a URL handler
...
for that scheme. This fixes a bug where sky:// URLs couldn't be added
with MPRIS.
2014-01-24 23:54:38 +11:00
John Maguire
35f7760014
Add test for sqlite FTS3 support.
2013-11-27 14:53:00 +01:00
John Maguire
5b19c520d0
Use gtest's builtin tuple type again for 10.9
2013-11-22 16:31:56 +00:00
John Maguire
331d471b51
Avoid tr1 for 10.9
2013-11-22 16:05:38 +00:00
John Maguire
cc43e339c1
Use boost function for compatibility
2013-11-22 11:53:47 +00:00
Arnaud Bienner
88918d45c5
Update issue 1175:
...
Save rating and statistics in two distinct ways, and let users activate them separately in preferences.
2013-03-30 23:42:29 +01:00
Arnaud Bienner
69d291c621
Change a test value to avoid rounding error.
...
IMHO it's fine as it doesn't matter if the value is changed a bit after being saved, as the difference is negligible.
2013-03-18 22:46:11 +01:00
John Maguire
21d96a2f10
Use integer comparison for integer song ratings.
2013-03-18 18:02:36 +01:00
Arnaud Bienner
77c6a22962
Write/Read score to/from files' tags, as "Amarok score" as we use the same algorithm
2013-03-15 22:54:59 +01:00
Uwe Klotz
a6d3b48231
Extend tag support: performer, grouping
...
The transaction handling while upgrading the database schema had to be revised.
Furthermore some QSqlQuery statements needed to be finished properly.
Fixes issue 2556
2013-03-10 18:16:03 +11:00
Arnaud Bienner
0b6e91daea
FMPS support for MP4 files
2013-03-03 00:18:59 +01:00
Arnaud Bienner
f04923210d
FMPS support for ASF files
2013-03-02 23:54:54 +01:00
Arnaud Bienner
b0d643cbd9
Save/read FMPS tags to/from FLAC using Vorbis comments + some refactoring to parse VorbisComments in a unique place, when possible.
2013-03-02 00:03:51 +01:00
