e5ab3e786f
Network Remote: Check bytesAvailable >= 4 before reading length integer
...
This caused Clementine Remote to stop working on Android N. writeInt()
splits the 4 bytes across multiple tcp frames. Clementine would read
a wrong length and thus fail to read any protocol buffer data.
2016-09-12 12:07:28 +02:00
aba0517b4c
Fix memory leak in networkremote.
2015-03-24 09:22:02 +00:00
0f1b29a523
Make sure SongSender is deleted when client disconnects.
2014-12-07 13:54:18 +01:00
ff172f6ed4
Network remote can now transcode lossless files before sending them to the remote.
...
- It is configurable in the settings.
- Any format can be chosen that is supported by the transcoder.
- The status of the transcoder is send to the remote.
- Transcoder format settings have now a postfix so we can define mutliple transcoder formats and use them separatly. Here one for the normal transcoder and one for the network remote transcode. You can pass the postfix in the constructor.
- Fixed Transcoder crash (was introduced with the gstreamer1.0 merge, decodebin doesn't have a "new-decoded-pad").
- Transcoder emits the output filename as well on "JobComplete" signal
- Transcoder can now convert a file to a temporary file ("AddTemporaryJob")
2014-11-13 22:31:49 +01:00
bebd781fdf
Reformat all non-3rd-party C/C++/Objective-C++.
...
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
-style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
acb18cdcde
First tries on a portable version.
2013-09-29 10:43:34 +02:00
fc78a78afc
- Send songrating to client.
...
- Receive songrating as float (like saved in Song).
- On RemoteClient destructor check if socket is still connected before calling waitForDisconnect()
(cherry picked from commit 9237356e33
2013-09-22 12:10:18 +02:00
3210d016d6
Wait until socket is closed before destroying RemoteClient object. Otherwise the disconnect message is not sent.
...
(cherry picked from commit 6a61f8598d
2013-08-24 21:29:04 +02:00
662b635d96
- Do not send cover arts on file download chunks.
...
- Set the version in the send function, not in each function that creates a protocol buffer message.
2013-08-01 10:52:01 +02:00
4406992554
Oops.
2013-07-16 22:17:25 +02:00
01084de461
Fix memory leak when a client downloads tracks.
2013-07-16 22:16:05 +02:00
6c19acdf48
Memory optimization in network remote.
2013-07-16 17:47:49 +02:00
25b3dc8b09
Remove unnecessary parameter and comment.
2013-07-12 12:41:45 +02:00
c09d77f413
Network remote can now send songs to clients.
2013-07-12 12:31:27 +02:00
87ea891755
Fix issue: The wrong auth code disconnect message was not sent.
2013-03-30 19:09:58 +01:00
3f2aae602e
- Send data to clients only if they are authenticated.
...
- Send songs of the active playlist if the active playlist changes.
2013-03-23 17:02:00 +01:00
be68c9f702
If use auth code is enabled, check if the client has sent the correct auth code before processing any messages.
2013-03-21 10:57:52 +01:00
3e01d32a89
Fix issue 3545. Disconnect a client when the expected protocol buffer length is more than 128MB to prevent a crash.
2013-03-12 12:12:04 +01:00
e4ac2e6d82
Add debug output to pin down issue 3545.
2013-03-11 22:22:22 +01:00
28632cdb37
Fix version set.
2013-02-08 19:42:46 +01:00
0c7354dba6
Send the version when disconnecting because of an invalid auth code.
2013-02-08 19:27:56 +01:00
a4d26bc249
- Actually fix the SIGPIPE (Broken Pipe) Error. It was caused by the QTcpSocket::flush().
...
- Revert previous SIGPIPE fixes.
- Rename method in RemoteClient to match its function.
2013-01-28 22:45:26 +01:00
a2c07527bf
Included signal header file in main.cpp.
2013-01-28 15:40:00 +01:00
fcc0da554b
Moved signal(SIGPIPE, SIG_IGN) to main.
2013-01-28 14:39:31 +01:00
a40aa6fb8d
Added security methods to prevent SIGPIPE termination.
2013-01-28 14:21:04 +01:00
9472c5ace2
- Fixed a bug where clementine crashed when restarting the server (e.g. changed setting). Cause by wrong connect statement.
...
- Added set track position feature in proto
- Added authentication method
- Clementine sends now a disconnect message when closed
2013-01-23 20:02:12 +01:00
04ccdbbf08
added version to protocol buffer message
...
changed client handling
only non public ips can connect (can change that in options)
2013-01-10 21:21:55 +01:00
Andreas Muttscheller
Ivan Leontiev
Andreas
John Maguire