Commit Graph

63 Commits

Author SHA1 Message Date
John Maguire 192b60d965 Use nullptr as parent parameter default everywhere 2014-02-10 16:03:54 +01:00
John Maguire 3323c2d094 Convert all instances of foreach() to a C++11 for
find ext src -name '*.cpp' -exec \
    sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
John Maguire bebd781fdf Reformat all non-3rd-party C/C++/Objective-C++.
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
 -style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
John Maguire d309d4ab27 Use c++11 instead of boost where possible. 2014-02-06 16:51:39 +01:00
John Maguire 59cb17c08d Change some API URLs to use https. 2014-01-28 12:57:27 +01:00
David Sansome 2c55688601 Make the GPL spotify code non-optional 2013-09-18 00:49:29 +10:00
Arnaud Bienner 02e51dad2f Update Flickr API Key for Kittens 2013-09-11 23:54:41 +02:00
Andreas 4e2ded9178 - Finished album cover exporter from keirangtp's branch "export-covers".
- Updated export dialog layout.
- Added option to export downloaded and/or embedded covers.

- Auto. cover fetcher and exporter is now cancelable.
- Minor covermanager layout improvements.
- Covermanager shows count of total and missing covers.

Fixed issue 520.
2013-05-06 21:22:05 +02:00
David Sansome 4fff9c3ca5 Use a new Amazon access key 2012-12-31 21:46:06 +11:00
John Maguire f6d2564bf5 Use std::mem_fun instead of boost::bind where it makes sense. 2012-10-25 16:32:19 +02:00
John Maguire f8b08616e8 remove obsolete connect 2012-10-16 12:22:42 +02:00
John Maguire e8f4496fea Port last.fm cover provider to closures. 2012-10-12 13:49:09 +02:00
John Maguire d6b2fc79f5 Port a few more things to closures. 2012-10-12 12:38:12 +02:00
John Maguire e5760815a1 Generate sensible names for covers returned from Musicbrainz. 2012-10-11 12:24:41 +02:00
John Maguire 4d9e102bbd Add missing include. 2012-10-10 14:59:39 +02:00
John Maguire a56947e356 Add support for new musicbrainz cover art archive.
See: http://blog.musicbrainz.org/?p=1616
2012-10-10 14:45:13 +02:00
John Maguire 606bf71208 Disable automatic conversions to QUrl from strings. 2012-09-26 17:09:13 +02:00
David Sansome abe8d10b9c Add a compatibility header so liblastfm and liblastfm1 can both be used with the same source. 2012-06-28 18:40:20 +01:00
Harald Sitter 769baa5c16 Use liblastfm1 2012-06-28 18:40:20 +01:00
David Sansome 63f13b19f2 Fix a possible crash when an album cover search times out at the same time that it's cancelled or finishes normally. Fixes issue 2752 2012-02-26 15:35:15 +00:00
David Sansome 23724b667f Start album cover request IDs at 1, so 0 can be invalid 2012-02-26 15:12:39 +00:00
David Sansome ab5ccf69da Refactoring: remove BackgroundThread 2012-02-26 15:05:46 +00:00
David Sansome bacef04405 Refactoring: remove a couple of the AlbumCoverLoader instances and instead use a shared CurrentArtLoader. 2012-02-26 14:40:51 +00:00
Arnaud Bienner b32444dce7 Try to fix Debian and Fedora builds 2012-02-19 17:43:23 +01:00
Martin Björklund 00545a4059 Get better discogs results by using the master image before general releases, and also make fewer requests to the server to fetch images. 2012-02-07 13:05:26 +00:00
Martin Björklund 8d63ddd3eb Add a Discogs cover provider
Fixes issue 1794
2012-01-29 14:27:07 +00:00
David Sansome 9be641ee87 The external tagreader mostly works now:
* Make TagReaderClient a singleton until it's easier to pass dependencies around
 * Add a WaitForSignal() that uses a local event loop to wait for a signal to be emitted
 * Add a WaitForFinished() to _MessageReplyBase that blocks using a semaphore
 * Add blocking versions of all TagReaderClient methods
 * Use the TagReaderClient everywhere that Song::InitFromFile and friends were used before
2012-01-07 00:26:07 +00:00
John Maguire 7585236e20 Use Closure in Amazon cover provider. 2011-12-12 17:36:51 +01:00
John Maguire 5a9bd3e8cf Add an associate tag to Amazon cover requests. 2011-12-12 17:25:58 +01:00
David Sansome 8d5ef62256 Do spotify image requests with string IDs instead of spotify://image/ urls. For some reason this seems to fix occasional crashes when image results arrive. Fixes issue 2411. 2011-11-29 10:21:40 +00:00
David Sansome b873209d39 Remove the <xiphcomment.h> include from song.h so that windows headers don't infect everything else. Also move other bits of song.h into song.cpp, and reduce the number of includes in song.h. 2011-11-28 13:56:55 +00:00
David Sansome e9253af931 Load cover art for the library in a background thread. Fixes issue 2243 2011-11-13 00:31:27 +00:00
David Sansome a6f4a76618 Hide an occasional crash when playing a spotify track and loading spotify art at the same time - for some reason printing this URL triggers it... 2011-09-24 18:16:35 +01:00
David Sansome b1fe146966 Maybe fix the mac build 2011-07-23 23:40:24 +01:00
David Sansome 1f8263d329 Add a C++ implementation of the Amazon cover provider 2011-07-23 19:34:54 +01:00
David Sansome 38100f5e59 Make CoverProviders not a singleton 2011-07-23 19:34:41 +01:00
Tyler Rhodes ded8e5f6f0 Refactor "Radio" files into "Internet" files. 2011-07-15 13:27:50 +00:00
David Sansome 7773e98ebf Keep track of some statistics while searching for album covers, and show a statistics dialog at the end. Fixes issue 1921 2011-06-26 15:07:48 +00:00
David Sansome 42801a967b Cancel album cover loads properly 2011-06-26 15:07:29 +00:00
David Sansome f8045af720 Various album cover search changes:
- Download several covers and use some heuristics to decide which cover is the best, rather than just taking the first one.
 - Timeout album cover downloads after 2.5s
 - Show covers properly in the album cover manager if they were manually unset, and then Clementine was restarted.
2011-06-26 15:07:19 +00:00
David Sansome bac414a630 Allow the artist and album to be specified separately when searching for album covers 2011-06-22 19:07:15 +00:00
David Sansome 2e9ec3e9d4 Don't crash on exit when unregistering cover providers 2011-06-22 19:06:57 +00:00
David Sansome 9023aafdef Try fixing the build again 2011-06-20 10:24:31 +00:00
David Sansome 62bd3694ec Remove cover provider factories and refactor everything else to use cover providers directly instead. 2011-06-19 23:15:51 +00:00
David Sansome c6e2981860 Group album cover search results by category 2011-06-19 23:15:29 +00:00
David Sansome 7de618beff Fix registration of metatypes for list handlers on Qt 4.7 2011-05-29 14:08:55 +00:00
David Sansome 9e6fea9d27 Refactor AlbumCoverFetcherSearch to not delete replies while they might still be used, and to remove unnecessary mutex locking 2011-05-28 16:00:46 +00:00
David Sansome 3ac2ae6a83 Fix a segfault that occurred when an album cover search finished - seen more often with Python providers. 2011-05-28 16:00:38 +00:00
David Sansome e1620385d5 Fix the Amazon covers script to work with PythonQt, and some minor style fixes 2011-05-22 14:11:02 +00:00
Paweł Bara 46a411844a some more corrections of the python API for cover providers; still not working ;) 2011-05-21 12:19:35 +00:00