Commit Graph

289 Commits

Author SHA1 Message Date
Arnaud Bienner 39e1275980 Write FMPS metadata (rating, playcount) to MP3 files in tagreader + corresponding test cases 2013-02-23 20:12:17 +01:00
Arnaud Bienner 47c9153fe2 Move everything about reading/writing tags from tagreaderworker to a new tagreader class.
Re-activate Song tests.
2013-02-22 23:57:31 +01:00
John Maguire def697c31a Add truncation support to Zeroconf with test. 2013-02-22 14:53:54 +01:00
John Maguire 195e1cb2ad Support arbitrary return type in closure for member function pointer. 2012-12-13 16:55:23 +01:00
John Maguire 020f08438f Support member function pointers in Closure.
Bonus: type-safe slots
2012-12-13 16:27:55 +01:00
John Maguire 94f76a9d08 Support function pointers and std functions with arguments in Closure. 2012-12-13 16:13:38 +01:00
John Maguire 1cc0bc0d14 Remove encoding tests. 2012-11-29 13:45:14 +01:00
John Maguire 875b297278 Check for lambda support before using it. 2012-11-26 15:36:05 +01:00
John Maguire c294098aef Use tr1 for mac compatibility 2012-11-26 10:10:20 +01:00
John Maguire 11f664083a Add support for standard function callbacks in NewClosure (including C++11 lambdas). 2012-11-26 09:41:26 +01:00
John Maguire 8171192df5 Port Closure to variadic templates. 2012-11-22 17:19:04 +01:00
John Maguire fd4c34c38b Build tests as permissive C++0x 2012-11-21 17:12:57 +01:00
Tony Motakis 207225d620 HasCompilations() implementation local to the LibraryModel
Instead of relying on the backend to provide us with the information
of whether there are compilations in the whole of the library, we instead
look into the query we are currently working with for compilations. This
way we can be as granular as we want in the future.

This also means we now have to add the Various artists node at the time we
do the query with RunQuery() instead at BeginReset().
2012-10-27 16:30:08 -07:00
Arnaud Bienner 0e3dc5a8be Add new ConcurrentRun templates for void functions, and functions with 3 arguments + corresponding test cases.
+ SongLoader now has its own QThreadPool to load folders/playlist in background.
Update issue 2598
This should fix slowliness problems reported.
2012-07-16 00:06:55 +02:00
David Sansome abe8d10b9c Add a compatibility header so liblastfm and liblastfm1 can both be used with the same source. 2012-06-28 18:40:20 +01:00
Harald Sitter 769baa5c16 Use liblastfm1 2012-06-28 18:40:20 +01:00
John Maguire b237d436d1 Remove obsolete code for unicode sqlite LIKE. 2012-06-11 12:05:31 +02:00
Arnaud Bienner 579d775894 Remove useless include 2012-04-25 01:20:52 +02:00
Arnaud Bienner 01daea7090 Commit missing modifications/change ConcurrentRun description a bit 2012-04-25 00:29:19 +02:00
Arnaud Bienner 76b98000fe Add ConcurrentRun functions, and us one of them in gstenginepipeline with gstenginepipeline's own threadpool.
So now we can (finally!) play/pause/stop music while fingerprinting lot of songs or whatever else
2012-04-25 00:21:01 +02:00
John Maguire 3f3945ead8 Use TEST instead of TEST_F where appropriate. 2012-04-18 14:37:40 +02:00
John Maguire a09165c392 Make it more obviously wrong to use the Closure internals. 2012-03-20 15:14:44 +01:00
John Maguire e1d77e0124 Add support for QSharedPointer in Closure. 2012-03-19 19:37:57 +01:00
John Maguire 1a4bfd3ebe Add small unit test for closure. 2012-03-19 19:37:57 +01:00
John Maguire d1cc3afb96 Remove python tests. 2012-02-28 15:22:30 +01:00
David Sansome 48f15c9fc7 Refactoring: instead of passing individual pointers to useful core classes (like TaskManager or LibraryBackend) to each class that uses them, pass one singleton-like Application instance everywhere. 2012-02-26 14:40:51 +00:00
David Sansome 12daf6bf43 Disable any tests that use Song::InitFromFile for now 2012-01-08 20:09:44 +00:00
David Sansome b873209d39 Remove the <xiphcomment.h> include from song.h so that windows headers don't infect everything else. Also move other bits of song.h into song.cpp, and reduce the number of includes in song.h. 2011-11-28 13:56:55 +00:00
David Sansome dc49c098df Fix unit tests 2011-11-27 15:29:48 +00:00
David Sansome 6d45415b00 Consistently use "Various artists" with a lower case "a" 2011-10-30 16:53:39 +00:00
Arnaud Bienner 399829291d Merge branch 'master' of https://code.google.com/p/clementine-player into grooveshark
Conflicts:
	data/data.qrc
2011-09-20 00:37:20 +02:00
John Maguire ecdd0ed6b0 Fix compile warning in test. 2011-09-19 12:31:13 +02:00
Arnaud Bienner 99fdba877e Merge branch 'master' into grooveshark 2011-09-02 00:35:40 +02:00
Arnaud Bienner d65e32d53a Add test for Hmac functions 2011-09-01 23:46:56 +02:00
David Sansome c11623002e Fix a test from a while ago 2011-09-01 22:11:13 +01:00
David Sansome 9fd387cfab Fix AlbumCoverManagerTest 2011-07-23 19:39:53 +01:00
Tyler Rhodes 05ac1e1afc Fix the playlistmanager test error. For serious this time. 2011-07-15 14:47:48 +00:00
Tyler Rhodes 2d4615caa3 Fix error in tests due to r3471. 2011-07-15 14:41:51 +00:00
Tyler Rhodes ded8e5f6f0 Refactor "Radio" files into "Internet" files. 2011-07-15 13:27:50 +00:00
David Sansome e6b2e5bcae Make the DeleteSongs function actually delete songs again, and make a new MarkUnavailable function that is called when songs are deleted from disk (and stop it from removing the song from the search index). 2011-07-06 20:07:56 +00:00
David Sansome 57d7989623 Fix the library backend test after r3339 broke it 2011-05-30 18:56:42 +00:00
David Sansome 033918ff79 Remember any signals that are connected to Python objects and disconnect them when the script is unloaded so the references to those objects can be dropped 2011-05-30 14:53:59 +00:00
David Sansome fb25a3d4f4 Rename script to __script__ 2011-05-30 14:53:28 +00:00
David Sansome f8593f2b83 Oops, fix the tests 2011-05-29 13:50:55 +00:00
John Maguire 516c9a8da5 Fix MPRIS test. 2011-05-26 16:52:18 +00:00
David Sansome e61a8c84cb Re-enable and fix the python tests, add regression tests for the weird PythonQt bugs 2011-05-22 15:23:12 +00:00
John Maguire 4ec89102c8 Fix DeleteSongs test. 2011-05-18 15:05:19 +00:00
David Sansome 368c637ce7 Fix compilation in release mode and disable the python test for now 2011-05-15 15:46:42 +00:00
David Sansome 705bbce1e5 Fix unit tests 2011-04-29 11:27:48 +00:00
David Sansome 6820a366d7 Fix the unit test mocks from before 2011-04-28 17:51:09 +00:00
David Sansome 044a97720c Initialise logging in unit tests 2011-04-28 12:28:50 +00:00
David Sansome ccb9f8cf94 Use URLs everywhere instead of filenames. Move the URL parsing and song loading code out of individual playlist parsers and into the base class. Fix the playlist parser unit tests. 2011-04-28 12:27:53 +00:00
Paweł Bara fdda938c53 now that we have more cover providers, we're bringing the cover manager and the cover searcher goodness to our last.fm-less users 2011-04-27 19:10:37 +00:00
David Sansome d28e5ae09a Add a test for shared pointers in python 2011-04-22 18:53:33 +00:00
Paweł Bara 880579ee24 fixing test 2011-04-21 22:12:57 +00:00
Arnaud Bienner 65ef047c38 Loading file in async way, in two times: fast loading files and insert them in playlist view, while loading info (tags, ...) in background thread 2011-04-16 14:04:15 +00:00
David Sansome e69502dfd3 Use system gtest and gmock if available. Fixes issue 1653 2011-03-29 19:05:13 +00:00
David Sansome 32e03ad8a3 Fix the mpris1 when last.fm is disabled. Thanks Nikoli 2011-03-25 19:59:09 +00:00
John Maguire 4fda021d16 Fix compile error in test when lastfm disabled.
Fixes issue #1617
2011-03-25 15:48:54 +00:00
David Sansome b3db5d699e Remove CanDecode from GstEngine - it was only used by a test, and the test was disabled on buildbot because it was unreliable. 2011-03-20 19:36:50 +00:00
Paweł Bara bfb068a6d1 conditionally hide some context menu actions in library view and playlist view
Song.is_stream()
2011-03-20 12:43:10 +00:00
Paweł Bara 41f659ff4b fixing tests 2011-03-19 10:43:50 +00:00
John Maguire 0a54c5135b Ignore empty lines in m3u files.
Fixes issue #1403
2011-03-17 16:05:08 +00:00
David Sansome 7086d7bf03 Fix tests when build some options are disabled 2011-03-13 20:01:24 +00:00
David Sansome b271c714b8 Fix this test on Windows 2011-03-13 19:22:41 +00:00
David Sansome 3ba97ead0b Fix a couple of tests 2011-03-13 18:50:32 +00:00
Paweł Bara 47f5de6176 fixing tests 2011-03-10 22:05:56 +00:00
David Sansome 4c2a2bb0fe Don't build the python test if python is disabled 2011-03-04 22:27:59 +00:00
David Sansome 2b08d27a88 Show loading indicators in the library model and the status bar when asynchronously loading songs during initialisation. 2011-02-26 14:27:57 +00:00
David Sansome 62b6d052de Fix the library model test 2011-02-26 13:34:31 +00:00
Paweł Bara 7f3f4f4107 more accurate parsing of indices in CUEs (we now respect the FRAMES part)
+ incorporating arnaud's code comment in fileviewlist
2011-02-15 22:26:56 +00:00
David Sansome aeb2ab9625 Only run the MPRIS1 test on Linux 2011-02-14 19:34:54 +00:00
David Sansome 8c691d2b3e Use constants instead of "1eN" literals for converting between time units. 2011-02-14 19:34:37 +00:00
David Sansome f801252e3d Refactor Player and PlaylistManagers to have interfaces and add more MPRIS1 tests 2011-02-13 18:37:45 +00:00
David Sansome 12da941885 Add a really basic unit test for MPRIS1 2011-02-13 18:37:21 +00:00
David Sansome 3a1853a681 Use nanoseconds in playlist parsers, and fix the tests 2011-02-13 18:35:26 +00:00
John Maguire df0f3e1589 Fix building tests on mac. 2011-02-04 15:00:27 +00:00
John Maguire 01915cc351 Remove taglib prefix from #includes in tests. 2011-02-04 13:29:49 +00:00
Paweł Bara 7bdac8fba6 when loading playlist, take only it's valid songs (+ force validity of CUE and PLS related songs) 2011-02-03 17:47:32 +00:00
David Sansome bcc35ec29c Add a test for stuff in the module's global dict 2011-01-28 21:43:10 +00:00
David Sansome 9ca237bfa2 Add a unit test for some basic python scripting functionality 2011-01-28 20:52:38 +00:00
Paweł Bara ddd3f119d3 CUE songs are now properly updated in library - you can delete a CUE sheet, add it, you can change section markers in it etc. and everything should work as expected
Song now knows it's cue path (if any)
2011-01-15 18:46:23 +00:00
David Sansome 1344103515 Add a workaround for broken XML entities in ASX playlists 2011-01-15 13:58:35 +00:00
Paweł Bara 4f7e804638 library: watcher now updates CUE associated songs + ignores the not-CUE-associated songs in a CUE sheet
CueParser: properly update length for the last song from every FILE in multifile CUE sheet
new 'playlist_path' argument in the 'Load' part of PlaylistParser's API
2011-01-11 23:09:59 +00:00
Paweł Bara d4d7f19fab better .cue spec conformity (allow many files in one sheet, use the SONGWRITER field as song's composer, ignore data files) 2011-01-05 20:23:53 +00:00
Paweł Bara 59378166b4 finalized the support for loading .cue based media using 'files' tab or drag and drop from the system's file browser
use FILE's PERFORMER as albumartist
2011-01-03 23:36:10 +00:00
David Sansome 37c0876686 Fix the m3u parser test 2010-12-25 15:46:20 +00:00
Paweł Bara d7fe4600b8 an initial version of .cue sheets parser
initial support for multipart media files in Song ('beginning' and 'end' fields)
2010-12-23 21:13:43 +00:00
Paweł Bara 712782d40c corrections to tests after yesterday's current_index -> current_row renaming 2010-12-17 16:41:19 +00:00
David Sansome a739ff2714 Fix playlist parser tests 2010-12-11 11:07:00 +00:00
David Sansome 6f889947c8 Fix the playlist test 2010-11-20 20:10:51 +00:00
David Sansome ed1a25693c Add missing licenses to debian/copyright, and add copyright information to each source file 2010-11-20 13:27:10 +00:00
David Sansome eb9660edad Parse FMPS ratings and played counts from mp3 id3v2 tags 2010-10-17 16:03:49 +00:00
David Sansome 47004d0ac3 Fix album cover manager test 2010-10-16 18:21:28 +00:00
David Sansome b97b2138fa Play last.fm tag radio or similar artists radio when clicking on a tag in the song/artist info pane. 2010-10-16 15:22:14 +00:00
John Maguire 0c281bb837 Add cmake options for more libraries.
Fixes issue #738
Thanks to Nickollai for the patch.
2010-09-22 13:05:51 +00:00
John Maguire 214d77bc0e Fix test and fix song loader infinite loop. 2010-08-31 21:24:57 +00:00
David Sansome dedb9621e8 Fix the songloader test by making it wait for the gstreamer engine to finish initialisation 2010-08-28 19:22:58 +00:00
John Maguire 36264e0b2b Separate out UniversalEncodingHandler. 2010-08-03 19:29:49 +00:00
John Maguire 9d253fdf37 Fix playlist loading tests. 2010-08-03 16:00:51 +00:00