Commit Graph

906 Commits

Author SHA1 Message Date
Alex 11670e1760 Fix playlist behaviour (#5330)
* Do not restore playback state on application start if overwritten by command line options

This also fixes unwanted pausing if a new instance is started with commandline URL combined with playback restore.
Note that the actual buggy code (MainWindow::ResumePlayback()) is not fixed here.

* Fix for commandline URLs for new instances are always appended to playlist.
2016-04-12 15:53:43 +01:00
John Maguire 6693a870ad Reformat intergalacticfm service 2016-04-06 15:45:25 +01:00
John Maguire 9291f09b1b Merge branch 'master' into PanderMusubi-master 2016-04-06 15:43:32 +01:00
John Maguire ed13d02231 Remove support for mpris1 2016-03-30 17:14:58 +01:00
John Maguire 9c33369fcc Merge pull request #5292 from printesoi/fix-mpris-signals
Fix mpris dbus notifications
2016-03-30 15:36:04 +01:00
Victor Dodon 3dd55e1c86 mpris2: fix format
Minor code refactoring:
- Use ternary operator in Mpri2::CanSeek
- Run make format
2016-03-29 21:29:47 -07:00
René Tronsgaard Rasmussen 8e70046e4b Add -q,--stop-after-current commandline flag 2016-03-18 20:21:34 +01:00
Victor Dodon 91c144478b mpris2: emit CanSeek notification in EngineStateChanged
When the engine status is Playing must emit the notification CanSeek
2016-03-10 21:29:09 +00:00
Victor Dodon 5f14e887a7 mpris2: more notifications in RepeatModeChanged
Emit CanGoNext, CanGoPrevious notifications in RepeatModeChanged
2016-03-10 21:20:17 +00:00
Victor Dodon 3cf6cdb925 mpris2: more notifications in CurrentSongChanged
Emit CanGoNext, CanGoPrevious, CanSeek notifications in CurrentSongChanged
2016-03-10 21:14:31 +00:00
Victor Dodon c973c446e3 mpris2: add support for CanGoNext, CanGoPrevious, CanSeek 2016-03-10 21:11:05 +00:00
John Maguire b0322e7e7d Cleanup ApplicationImpl 2016-02-15 17:41:39 +00:00
John Maguire 20bfade965 Hide Application classes behind pimpl.
This should also fix the build on windows where gcc gets confused as
libmygpo declares DELETE as part of an enum and mingw #defines DELETE in
winnt.h
2016-02-15 17:39:50 +00:00
John Maguire affb215a52 Move cover providers initialisation later in startup. 2016-02-12 16:25:01 +00:00
John Maguire 0cf83b19ee Eagerly initialise TagReaderClient 2016-02-12 12:07:26 +00:00
John Maguire d06f337ade Remove special deletion of objects in threads.
Fixes #5250
2016-02-11 16:31:08 +00:00
John Maguire f2daa772c1 Lazy initialise everything in Application. 2016-02-11 15:15:38 +00:00
Pander dc534bbcef Added support for Intergalactic FM 2016-02-05 19:29:43 +01:00
Chocobozzz dfdb21cd61 Reload playcount from tagreader only if it is set 2015-12-19 19:42:52 +01:00
John Maguire d256763dcb Update link to point to github
Fixes #5147
2015-12-07 14:37:44 +00:00
John Maguire f300946c81 Remove most usages of QFutureWatcher 2015-11-27 14:28:12 +00:00
John Maguire 3cc9c1e446 Remove ModelFutureWatcher 2015-11-26 19:02:08 +00:00
John Maguire 33494dcddc Remove BoundFutureWatcher 2015-11-26 18:53:42 +00:00
Mattias Andersson bbe7a48c27 Add missing calls to base class constructor. 2015-11-24 13:46:17 +01:00
narunlifescience dd953fd86c check custom icon location, then system theme & then fallback theme
icons added & replaced
2015-10-13 22:35:49 -05:00
electric-indigo 2d2b037460 Revert "Workaround for malfunctioning "Show in file browser" feature in Linux" 2015-10-11 22:56:42 +02:00
Tomasz Papież d3387f8ef8 Workaround for malfunctioning "Show in file browser" feature in Linux
(issue #4877).
2015-08-08 01:18:41 +02:00
Ivan Leontiev eb8fad766f Removed default value for the parameter original_url in the UrlHandler::LoadResult() constructor and updated internet services according to this. 2015-08-05 19:45:56 +00:00
Ivan Leontiev ae99716d9f Fixed check for the original url in the Player::HandleLoadResult() 2015-08-05 19:45:56 +00:00
Eduardo Sánchez Muñoz f6fc7035ac mpris: Fix track not restarting when playing the first track on the playlist and menu_previousmode setting is PreviousBehaviour_Restart. 2015-07-17 20:01:02 +02:00
Eduardo Sánchez Muñoz c051506fdd Fix "menu_previousmode" setting not loading when opening the settings window. 2015-07-15 18:46:18 +02:00
Eduardo Sánchez Muñoz 75e94a64d1 Add option to change the time step when seeking using the keyboard. 2015-07-03 20:54:17 +02:00
Diogo Pereira 68e7add076 Send album artist to Last.fm
Older versions of liblastfm do not support this, so it is only enabled
when compiling with liblastfm >= 1.0.0.
2015-07-03 15:17:12 +01:00
John Maguire 745212d967 Revert "Send album artist to Last.fm" 2015-07-03 14:59:54 +01:00
Diogo Pereira d6ed1492b4 Send album artist to Last.fm 2015-07-02 18:04:10 +01:00
Eduardo Sánchez Muñoz 999af101e6 Rename constant and put it inside an anonymous namespace. 2015-07-02 15:09:55 +02:00
Eduardo Sánchez Muñoz 11b61c2a67 Use Player::SeekForward() and Player::SeekBackward() to handle seeking with arrow keys. 2015-07-02 14:59:30 +02:00
Eduardo Sánchez Muñoz 622cf23798 Add missing set_originalyear() on Song::ToProtobuf(). 2015-07-02 00:53:31 +02:00
Eduardo Sánchez Muñoz e0816800b1 Add support for original year tags. 2015-06-30 18:34:34 +02:00
John Maguire 1323af5025 Merge pull request #4910 from Chocobozzz/global_shortcut
Add love/ban (lastfm) global shortcuts
2015-06-17 09:49:19 -04:00
Chocobozzz 7b8552ab6d Add love/ban (lastfm) global shortcuts 2015-06-17 14:21:24 +02:00
Mark Furneaux f4b7c22bc2 Revert "Revert "Add track intro mode""
This reverts commit ece262f7f4.
2015-06-15 16:27:40 -04:00
John Maguire ece262f7f4 Revert "Add track intro mode" 2015-06-15 15:49:08 -04:00
Mark Furneaux b57cebbf2d Add track intro mode
This repeat mode plays the beginning of each track, good for quickly getting a feel for a new album for example.
2015-06-14 13:32:58 -04:00
Mark Furneaux 7a3830335f Fix playlist not deselecting playing track when stopping
Regression from #4866
2015-05-22 22:08:02 -04:00
kiselev-dv f7ebeb53da Stop after each track 2015-05-22 18:11:58 +05:00
John Maguire e899598967 Revert "Add stop after each song repeat mode" 2015-05-22 11:33:59 +01:00
John Maguire 06f053e5a6 Merge pull request #4850 from kiselev-dv/master
Add stop after each song repeat mode
2015-05-22 11:29:48 +01:00
kiselev-dv e122898187 unnecessary set_current_row(-1) 2015-05-20 16:50:13 +05:00
kiselev-dv 5cd39a74b5 Fix next song autoselection 2015-05-19 09:56:12 +05:00
Mark Furneaux 50ff5f5b0e Spelling 2015-05-18 13:03:44 -04:00
Mark Furneaux 99dffe216c Fix Last.fm scrobbling after seek
Fixes #4836
Last.fm defines a scrobble should be sent if:
-the track is longer than 30 seconds.
-the track has been played for at least half its duration, or for 4 minutes (whichever occurs earlier.)

Clementine has treated this as seconds from the start of the track, and if any seeking occurs, it nullifies the scrobble.
This IMO is incorrect. If I skip the first 10 seconds of a song, but listen to the rest (still meeting the time requirements),
I should still be able to scrobble the play. This change moves the scrobble point with every seek, requiring continuous playback
from any point that satisfies the time criteria.
2015-05-18 12:53:07 -04:00
Andreas a32f725c5f Register QList<int> as a media type. Under windows, the connect doesn't work without it. 2015-04-29 17:14:37 +02:00
Adam Porter bb5a952e25 Re-read FMPS_Rating from file when changed
When the FMPS_Rating changes in a file, Clementine will now re-read it
and change the rating in the library database.  This lets you modify
song ratings outside of Clementine and then load the new ratings into
Clementine.  Previously Clementine would ignore changed ratings in a
file's metadata after a song had been scanned into the library.
2015-04-25 18:32:34 +02:00
Andreas 11d2702841 Try fixing buildbot. 2015-04-10 22:59:35 +02:00
Martin Babutzka 258ae281d8 IDv3 tag lyrics support.
Squashed the following commits:

5c723ad commit: Fix: Includes alpha sort
15ac350 commit: Fix: Updated Database::kSchemaVersion to 49.
767a26a commit: Fixed small code style issue. Added schema-49 to data.qrc instead schema-48
bf6aa64 commit: fixup! Modified async handling of CollapsibleInfoPane as recommended by Andreas. Display of IDv2 tag lyrics works now.
c1f97e9 commit: fixup! Added support to read/display the ID tag lyrics in MP3 files:
c946b1d commit: Added support to read/display the ID tag lyrics in MP3 files:

-Added schema to the database to store it
-Added readers/writers for ID tags
-Added readers/writers for the database to the song class
-Added the taglyricsinfoprovider to show the lyrics in songinfo
2015-04-10 21:05:07 +02:00
John Maguire 8d3fd00956 Amazon Cloud Drive support.
Squashed commit of the following:

commit 451a327fabb5f9aba077d93a33d75d8a6a288f5f
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:55:36 2015 +0100

    Revert debug console changes.

commit 52f643c3dc524a837f56268b6da4881187204165
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:49:28 2015 +0100

    Revert extra logging

commit 23645f9fea
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:47:55 2015 +0100

    How did you get there

commit 8153388f19
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:45:12 2015 +0100

    Update copyright headers.

commit fa9e279259
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:43:27 2015 +0100

    Remove logging

commit 47a405543c
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:42:05 2015 +0100

    Show login state correctly for Amazon.

commit 748d88d993
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:28:55 2015 +0100

    Ensure Amazon is connected before serving URLs.

commit 25ec9c65f4
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:22:28 2015 +0100

    Refresh Amazon authorisation & follow changes.

commit 27c1a37173
Author: John Maguire <john.maguire@gmail.com>
Date:   Thu Mar 26 18:27:27 2015 +0100

    Revert unneeded OAuthenticator change.

commit 3594af5be1
Author: John Maguire <john.maguire@gmail.com>
Date:   Thu Mar 26 16:52:19 2015 +0100

    Initial support for Amazon Cloud Drive.
2015-03-27 14:56:08 +01:00
Arnaud Bienner 5b2e4419ae Don't check AXAPIEnabled when initializing the shortcuts, fixes media keys not working on OS X.
Fixes issue #3958.
2015-03-15 13:40:27 +01:00
John Maguire 705cdf11fc Move ScopedNSAutoreleasePool to ext 2015-03-02 17:51:17 +01:00
Arnaud Bienner 946c0381d1 Don't set thread priority in LibraryWatcher constructor, as this is executed in the main thread.
Do it when thread actually starts (create a new Thread class for this purpose).
Fixes #4523.
2015-02-28 16:44:32 +01:00
Krzysztof Sobiecki 24b6fbf36c Add ability to parse more of "innovative" datetime formats. close #4760 2015-02-27 02:11:53 +01:00
John Maguire fb2b91c874 Remove some more obsolete os x version checks. 2015-02-18 18:03:46 +01:00
John Maguire 484db9d92b Remove obsolete snow leopard check. 2015-02-18 17:29:07 +01:00
Arnaud Bienner ce50cbe09f Fix compile issue on Yosemite 2015-02-15 16:43:36 +01:00
Arnaud Bienner 43768d4af8 Small modifications to previous pull request:
- remove reference to iPod, as this is not iPod specific IMO
- make comment clearer
2015-01-19 15:01:33 +01:00
Andre Siviero e4df00050d Includes in alphabetical order, moved Player ReloadSettings() to Player init 2015-01-08 01:10:35 -02:00
Andre Siviero 1120f97844 Added iPod-like behavior to previous button 2015-01-06 02:36:08 -02:00
Krzysztof Sobiecki c4d150d3e0 Add m4b support, only for non-drm files 2014-12-25 01:12:15 +01:00
Krzysztof Sobiecki fa9ea6ec5f Fix compilation with moved files in internet/ 2014-12-18 23:35:21 +01:00
Krzysztof Sobiecki bf55bc08fb Cherry pick make format changes 2014-12-14 12:23:04 +01:00
Krzysztof Sobiecki 6cc72e2f5d Fix a date parser for one podcasts 2014-12-14 12:13:05 +01:00
Krzysztof Sobiecki 2d2783ab04 Fix copyright notices 2014-12-10 01:25:52 +01:00
Krzysztof Sobiecki 970e86aac5 Allows to download multiple podcasts at the same time
A new PodcastDeleter, it deletes podcast episodes
2014-12-10 00:47:52 +01:00
Krzysztof Sobiecki dc669eb603 Fix cpplint.py errors, fix copyright notices in src/analyzers, move src/core/fht* to src/analyzers 2014-11-29 20:07:01 +01:00
John Maguire 64c34f58ae Merge pull request #4608 from sobkas/src_core_fix
Fix the copyright info and formatting in src/podcast and src/core
2014-11-27 15:17:16 +01:00
John Maguire ff91759b71 Fix Ubuntu PPA
Adds a missing check for libcdio.
Adds libcdio as a dependency for debian.
Fixes issue #4618
2014-11-19 15:45:05 +09:00
Andreas ff172f6ed4 Network remote can now transcode lossless files before sending them to the remote.
- It is configurable in the settings.
- Any format can be chosen that is supported by the transcoder.
- The status of the transcoder is send to the remote.

- Transcoder format settings have now a postfix so we can define mutliple transcoder formats and use them separatly. Here one for the normal transcoder and one for the network remote transcode. You can pass the postfix in the constructor.
- Fixed Transcoder crash (was introduced with the gstreamer1.0 merge, decodebin doesn't have a "new-decoded-pad").
- Transcoder emits the output filename as well on "JobComplete" signal
- Transcoder can now convert a file to a temporary file ("AddTemporaryJob")
2014-11-13 22:31:49 +01:00
Krzysztof Sobiecki 6efb5d05b7 Fix some problems 2014-11-05 17:48:04 +01:00
Krzysztof Sobiecki 130d3c72f0 More copyright info fixes 2014-11-05 17:48:04 +01:00
Krzysztof Sobiecki d775d72345 More copyright info fixes 2014-11-05 17:48:04 +01:00
Krzysztof Sobiecki 39a3b46ead More copyright info fixes 2014-11-05 17:48:04 +01:00
Krzysztof Sobiecki a85728dfb3 Fix some problems 2014-11-05 17:48:03 +01:00
Krzysztof Sobiecki c0614dbe09 Fix copyright notices inside src/core 2014-11-05 17:48:03 +01:00
Krzysztof Sobiecki 0af1470cce Clean up src/core 2014-11-05 17:48:03 +01:00
Krzysztof Sobiecki 978a91442c Connect signal to signal 2014-11-05 17:35:14 +01:00
Krzysztof Sobiecki 5045f9b870 Don't use caller in OrganiseDialog 2014-11-05 02:37:44 +01:00
Krzysztof Sobiecki b89c05048a Move connect out of emitter 2014-11-05 00:42:56 +01:00
Krzysztof Sobiecki 578c9ad598 Ability to automatically set podcast as listened after sucesfully sending it to a device 2014-11-05 00:42:55 +01:00
Arnaud Bienner baa0654b03 Try to fix minimal build
Maybe one day I will stop breaking it everytime I change something
2014-10-26 17:12:00 +01:00
Arnaud Bienner 7ac9e4c6d1 Fix a bug in InsertItems functions that makes Cdda tracks to not be saved/restored correctly when restarting Clementine 2014-10-26 17:08:12 +01:00
Arnaud Bienner dc0d3436c8 Finish CD integration update to Gstreamer 1.0
Move everything related to CDDA to a seperate class, so we can more easily reuse it in SongLoader
2014-10-26 03:32:37 +01:00
Arnaud Bienner a8266173c5 Start to reactivate audio CD support 2014-10-26 00:28:03 +02:00
David Sansome 7b651136d8 Use the system's sha2 library if it's available. Fixes #4217 2014-09-25 23:51:46 +10:00
David Sansome 39d99247a2 gstreamer-cdda is in gst-plugins-base in 1.0 and has a different header name.
This still doesn't work because the API has changed and track listings are
now delivered via a bus message instead of direct access to the struct's
members.
2014-09-22 22:28:53 +10:00
David Sansome a2408f7c0e Merge branch 'master' into gstreamer-1.2
Conflicts:
	src/moodbar/moodbarloader.cpp
2014-09-21 19:39:27 +10:00
Arnaud Bienner 47108a9a68 Add a message in CMake to notify that ccache has been found and will be used (+ some minor, unrelated things). 2014-08-06 20:05:41 +02:00
David Sansome 6bb81328e8 Merge branch 'master' into gstreamer-1.2
Conflicts:
	ext/clementine-spotifyblob/mediapipeline.cpp
	gst/moodbar/gstfftwspectrum.c
	src/core/songloader.cpp
	src/core/songloader.h
	src/engines/gstengine.cpp
	src/engines/gstenginepipeline.cpp
	src/moodbar/moodbarpipeline.cpp
	src/musicbrainz/chromaprinter.cpp
	src/transcoder/transcoder.cpp
	src/ui/mainwindow.cpp
	src/visualisations/projectmvisualisation.cpp
2014-06-09 16:20:24 +10:00
Chocobozzz 1fc95cb7ed Add Seafile Support 2014-06-03 14:33:07 +02:00
John Maguire 1f97406171 Revert "Send album artist to Last.fm"
This reverts commit d7ec8b9103.
AlbumArtist seems unsupported by newer liblastfm.
2014-05-21 17:47:01 +02:00
Diogo Pereira d7ec8b9103 Send album artist to Last.fm 2014-05-20 21:20:55 +01:00