1
0
mirror of https://github.com/clementine-player/Clementine synced 2024-12-23 16:28:19 +01:00
Commit Graph

96 Commits

Author SHA1 Message Date
Jim Broadus
09723d516c Use a template for CreateLogger to allow different QDebug derivatives. 2020-03-07 02:41:56 +00:00
Jim Broadus
79ac16afeb Move unneeded declarations and macros from logging header.
Some functions and macros aren't used outside of logging.cpp and don't need be
declared in header. Functions can be static.
2020-03-06 11:09:20 +00:00
Jim Broadus
52fd6ffadc Add a logging category to log all network requests.
New logging class NetworkRequests disabled by default, but can be enabled with
the command line option.
2020-02-13 11:09:51 +00:00
Jim Broadus
d45a9f5c53 Enable debug logging for GstEnginePipeline by default.
Use qLogCat to put verbose GStreamer callback messages into a new
GstEnginePipelineCallbacks category. Filter that category instead of
the entire class by default.
2020-01-31 10:24:53 +00:00
Jim Broadus
4b37e0c577 Use qLogCat for GLog handler.
Provide the domain string from the GLog callback as the category.
2020-01-30 11:20:03 -08:00
Jim Broadus
a2d2850884 Add a new qLogCat macro to specify category.
In some cases, such as message handling callback functions, the line and function
macros don't provide a lot of useful information. In other cases, we may want more
granularity of control withing a class. For these cases, add a qLogCat that takes
a category string. Print this string in the message and use it as the filter
category.
2020-01-30 11:19:58 -08:00
Jim Broadus
203d6425fd Fix nomenclature in logging functions.
The qLog macro passes the result of the __PRETTY_FUNCTION__ macro to the
CreateLogger* functions, but these all take an argument called class_name.
2020-01-30 08:50:06 -08:00
Jim Broadus
dbe67bf32b Fix closure timing hole.
When a closure involves an ObjectHelper, a connection is made from the
receiver's destroyed signal and the helper object's deleteLater slot. Since
the signal between the sender and the helper object isn't disconnected until
either object is actually destroyed, this leaves a hole where the helper
holds a pointer to an invalid receiver object, but is still able to receive
the signal connected to its Invoke slot.

Instead of connecting the destroyed signal to deleteLater, connect it to a new
TearDown slot that immediately disconnects the signal then calls deleteLater.
2020-01-11 00:53:35 -08:00
Jonas Kvinge
1a2274bd2b Merge branch 'master' into qt5-update 2019-07-21 14:20:59 +02:00
Jonas Kvinge
5bb35bf08a Fix crash in messagereply (#6372)
* Fix crash in messagereply

* Fix formatting
2019-07-20 18:52:37 +01:00
Jonas Kvinge
1d17bee44a Merge with master and fix conflicts 2019-01-18 01:38:12 +01:00
Jonas Kvinge
2d1f6cd239 Replace Q_OS_MACOS with Q_OS_MAC (#6223) 2018-11-29 22:11:55 +00:00
Jonas Kvinge
9f946a2898 Improvements to makefiles and make components optional (#6221) 2018-11-29 21:32:12 +00:00
Jonas Kvinge
8c198a99a5 Qt 5 fixes 2018-11-21 10:31:17 +00:00
Chocobozzz
18a89f78a9 Merge remote-tracking branch 'upstream/master' into qt5 2016-10-07 14:30:09 +02:00
John Maguire
7750d5015e Cope with empty biography responses. 2016-06-28 18:22:15 +01:00
John Maguire
55af2b1d3b Add image fetching from wikipedia
#5416
2016-06-28 15:34:14 +01:00
Chocobozzz
e6e189967d Merge remote-tracking branch 'upstream/master' into qt5 2016-02-29 18:03:02 +01:00
John Maguire
b99b090adc Refactor simple dialogs to use Lazy 2016-02-12 16:01:35 +00:00
John Maguire
f2daa772c1 Lazy initialise everything in Application. 2016-02-11 15:15:38 +00:00
John Maguire
a7ca007e24 Tidy up lazy implementation. 2016-02-11 14:09:36 +00:00
John Maguire
4c8b1d8143 Add lazy initialisation helper. 2016-02-11 13:46:23 +00:00
John Maguire
ac660dcf3d Use a simpler arraysize() implementation. 2016-01-14 16:14:13 +00:00
Chocobozzz
ff7026c9fe Merge remote-tracking branch 'upstream/master' into qt5 2015-12-13 20:05:12 +01:00
John Maguire
f300946c81 Remove most usages of QFutureWatcher 2015-11-27 14:28:12 +00:00
John Maguire
2d61fe6c87 Changed my mind about automatically passing QFutures. 2015-11-27 12:04:14 +00:00
Arnaud Bienner
ec98a68c3d Update SLOT signatures.
There weren't update as part of commit 33494dcddc: this prevented the slider to be updated, among other things.
2015-11-27 11:44:59 +01:00
John Maguire
3cc9c1e446 Remove ModelFutureWatcher 2015-11-26 19:02:08 +00:00
John Maguire
689858026e Actually pass the finished QFuture back. 2015-11-26 18:42:12 +00:00
John Maguire
2cd15ff430 Add NewClosure overload for QFuture 2015-11-26 18:35:17 +00:00
Chocobozzz
631a6cdabd Merge branch 'master' into qt5 2015-09-16 17:40:54 +02:00
Chocobozzz
7a866ac46b Fix compilation with Qt5.5 2015-07-26 09:54:19 +02:00
John Maguire
b2a532be62 Experiment with typesafe time units 2015-07-20 14:35:13 +01:00
Chocobozzz
149e870ab4 Fix log messages (lines and classname) 2015-06-16 19:58:36 +02:00
Chocobozzz
98a450ad77 Fix compilation error (logging macros) 2015-06-13 20:51:18 +02:00
Chocobozzz
d755d5b602 Use functions instead of macros for logs 2015-06-11 18:11:19 +02:00
Chocobozzz
4943bca877 Fix release compilation error because of qt_no_debug_output flag 2015-06-11 11:35:30 +02:00
Chocobozzz
afda8f7505 Update again from master 2015-04-17 16:06:57 +02:00
John Maguire
aa22a43f44 Add exponential back-off to Amazon requests. 2015-04-17 12:10:40 +01:00
Chocobozzz
7bfe32c7df Avoid warning message when the level exceeds the threshold 2015-04-16 23:22:53 +02:00
Chocobozzz
e986ab5a4b Merge master branch and adapt it to qt5 2015-04-16 17:16:34 +02:00
Chocobozzz
8b226c2171 Update non optionnals sources to qt5 2015-04-11 23:24:07 +02:00
John Maguire
705cdf11fc Move ScopedNSAutoreleasePool to ext 2015-03-02 17:51:17 +01:00
John Maguire
41e9c15248 Add arraysize macro from Chromium 2014-04-29 14:11:52 +02:00
John Maguire
192b60d965 Use nullptr as parent parameter default everywhere 2014-02-10 16:03:54 +01:00
John Maguire
3323c2d094 Convert all instances of foreach() to a C++11 for
find ext src -name '*.cpp' -exec \
    sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
John Maguire
bebd781fdf Reformat all non-3rd-party C/C++/Objective-C++.
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
 -style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
John Maguire
71893e4847 Use nullptr instead of NULL everywhere. 2014-02-06 17:29:59 +01:00
John Maguire
d309d4ab27 Use c++11 instead of boost where possible. 2014-02-06 16:51:39 +01:00
John Maguire
cc43e339c1 Use boost function for compatibility 2013-11-22 11:53:47 +00:00