Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity
8,263 Commits 23 Branches 533 Tags 239 MiB
Commit Graph

150 Commits

Author SHA1 Message Date
Marcus Müller 2a14ec9d4d Lyrics Providers: Remove unreachable ones 
This was determined programmatically by means of trying to do a simple
HTTP request to / of any of the URLs given:

```python
from lxml import etree
from urllib import parse
import requests
doc = etree.parse("ultimate_providers.xml")
root = doc.getroot()
for provider in root:
    parsed_url = parse.urlparse(provider.get("url"))
    url = f"{parsed_url.scheme}://{parsed_url.netloc}/"
    try:
        requests.head(url, timeout=5)
    except Exception as e:
        print(parsed_url.netloc)
```

Note that these were also removed from songinfoview as present, and from
outgoingdatacreator. The two lists there were found to be inconsistent,
but this isn't subject of this PR.

Signed-off-by: Marcus Müller <marcus_clementine@baseband.digital>
 2023-09-12 13:33:01 +01:00
John Maguire 341dc7326f Reformat all C++ 2020-09-22 14:56:06 +01:00
Jim Broadus 0fc0dcdb79 lyrics: Add 30s timeout for lyrics provider requests 2020-05-24 15:54:49 +01:00
Jim Broadus 6675b1b63e lyrics: Add debug info for lyric server replies 2020-05-24 15:54:49 +01:00
Jim Broadus 02a1fc9a07 lyrics: Use lambda for UltimateLyricsProvider requests 
Remove map of requests to ids and pass info directly to reply handler.
 2020-05-24 15:54:49 +01:00
Jim Broadus 941e139a18 Replace closures with connect variant. 
Qt5 introduced new connect variants that allow calling a functor. A lambda can
replace the user of the Closure class in this case.
 2020-02-13 19:20:01 +00:00
Jim Broadus b3ec030ae4 Fix songkicks queries. 
- When parsing a response, use fromJson instead of fromBinaryData.
  fromBinaryData expects a serialized binary format.
- Calling toString on a non-string JSON value will return an empty
  string. Call toVariant().toString() to do the conversion.
- Add checks for network reply errors.
 2020-02-13 19:20:01 +00:00
Jim Broadus 61de3c6e93 Convert remaining QJsonValue::isUndefined usage. 
Noted previously, using the [] operator on a non-const QJsonObject causes the
creation of the key and does not work for checking existence. Convert the
remaining isUndefined call sites to use QJsonObect::contains.
 2020-02-13 11:12:52 +00:00
John Maguire b7c3173001
Merge pull request #6439 from jonaski/signalmapper 
Replace all uses of QSignalMapper with C++11 lambda expressions
 2019-11-10 19:13:31 +00:00
Jonas Kvinge 344023e6dd Fix formatting 2019-11-10 15:16:39 +01:00
Jonas Kvinge ba31c755ef Replace all uses of QSignalMapper with C++11 lambda expressions 2019-11-10 15:07:12 +01:00
John Maguire 21da802630
Merge pull request #6438 from jonaski/remove-extra-semicolon 
Remove extra ';'
 2019-11-10 00:53:37 +00:00
Jonas Kvinge d09c27f719 Remove extra ';' 2019-11-10 00:30:18 +01:00
Jonas Kvinge 0da490a5e1 Replace QString::null with QString() 2019-11-09 23:45:28 +01:00
John Maguire cb6cd7c485 Merge remote-tracking branch 'origin/master' into qt5 2019-10-04 16:51:43 +01:00
luz.paz fb93ae4b02 Fix misc. source comment typos 
Typos found via `codespell`
 2019-08-21 23:43:16 -04:00
Jonas Kvinge 647279a000 Move spotifyimages out of spotify support 2018-11-21 10:31:17 +00:00
Jonas Kvinge 8c198a99a5 Qt 5 fixes 2018-11-21 10:31:17 +00:00
Jonas Kvinge d4fab4a2ea Merge remote-tracking branch 'upstream/master' into qt5-update 2018-11-11 22:46:07 +01:00
Amish Naidu 107e945872 Convert uses of QtAlgorithms to std:: algorithms 2018-10-09 19:17:54 +01:00
Chocobozzz fc517ce7a5 Merge remote-tracking branch 'upstream/master' into qt5 2017-06-05 21:28:05 +02:00
John Maguire 5d0cf343d5 Use new clementine images API. 2017-03-06 18:15:59 +00:00
Florian Bigard 69b2a832db Merge branch 'master' into qt5 2017-01-18 15:57:07 +01:00
Santiago Gil d3898d2f47 Add dialog to display streams' audio details (#5547) 
* Add Stream Details window

* Fix capitalization in StreamDiscoverer::Discover()

* StreamDiscoverer::Discover(): get URL by const reference

* Refactor StreamDiscoverer::Discover

* Rename StreamDiscoverer callbacks

* StreamDiscoverer::OnDiscovered: fix nullptr comparison

* StreamDiscoverer: rename DiscoverFinished signal

* StreamDiscoverer::DataReady: receive const reference

* StreamDiscoverer: Remove unsigned types

* StreamDetailsDialog: rename Close slot

* StreamDetailsDialog: rename ui pointer to ui_

* MainWindow::ShowStreamDetails: receive a const reference

* StreamDetailsDialog: use unique_ptr, remove unsigned types
 2016-12-21 16:57:04 +00:00
Chocobozzz 18a89f78a9 Merge remote-tracking branch 'upstream/master' into qt5 2016-10-07 14:30:09 +02:00
Jan Suchomel 622a3e478a Add support for displaying lyrics from a Vorbis comment (#5495) 
* Added support for displaying lyrics from Vorbis Comments.

* Fixed style issues
 2016-09-18 13:23:39 +01:00
John Maguire afb7e1db36 Add attribution to wikipedia artist biographies 2016-09-05 15:17:14 +01:00
Mattias Andersson deb1c638cc Cope with empty spotify image responses 2016-07-07 19:04:24 +02:00
John Maguire de046cdf40 Fetch whole wikipedia article (as extract). 
Fixes #1112
 2016-07-05 15:09:12 +01:00
John Maguire 678ea4c6d1 Fix fetching wikipedia images for unicode artists. 
#5416
 2016-06-29 14:58:03 +01:00
John Maguire f0406ba86b Fix parsing of URLs from wikipedia. 
#5416
 2016-06-29 13:34:59 +01:00
John Maguire 7750d5015e Cope with empty biography responses. 2016-06-28 18:22:15 +01:00
John Maguire a9ba0f3bf2 Filter out bad wikipedia images better and support other locales better. 
#5416
 2016-06-28 16:28:20 +01:00
John Maguire 55af2b1d3b Add image fetching from wikipedia 
#5416
 2016-06-28 15:34:14 +01:00
John Maguire 7c0ef13bb7 Add artist biography from Google KG. 
#5416
 2016-06-28 14:16:23 +01:00
John Maguire a8a0f2e4fd Remove echonest and update songkick concert fetcher. 
#5416
 2016-06-27 14:47:42 +01:00
John Maguire aeb493c016 Replace echonest artist images with spotify #5416 2016-06-22 14:54:57 +01:00
Chocobozzz 0605dd83a5 Fix compilation (wrong echonest include) 2016-03-30 19:29:30 +02:00
Chocobozzz e6e189967d Merge remote-tracking branch 'upstream/master' into qt5 2016-02-29 18:03:02 +01:00
John Maguire 4cd20ffdaa Cope with receiving no images from spotify 2016-02-17 18:06:30 +00:00
John Maguire 52c72f95ba Too clever for old GCC versions. 2016-02-17 16:42:03 +00:00
John Maguire 1304f8898e Fetch artist images from spotify. 2016-02-17 15:55:37 +00:00
John Maguire 5b4c0c920c Blacklist artist images from echonest using dead last.fm server. 2016-02-17 15:55:37 +00:00
John Maguire ce3ba02749 Fix songkick concert fetching 2016-02-11 16:59:40 +00:00
Chocobozzz ff7026c9fe Merge remote-tracking branch 'upstream/master' into qt5 2015-12-13 20:05:12 +01:00
John Maguire f300946c81 Remove most usages of QFutureWatcher 2015-11-27 14:28:12 +00:00
narunlifescience dd953fd86c check custom icon location, then system theme & then fallback theme 
icons added & replaced
 2015-10-13 22:35:49 -05:00
Eduard Braun 2e35e09c96 Songinfo/lyrics: Fix index error in "UltimateLyricsProvider::Extract" 
(second argument to "QString,mid()" is number of characters, not end index)
 2015-10-10 22:35:11 +02:00
Eduard Braun b25101c1be Songinfo/lyrics: Improve generation of paragraphs 
(generate new paragraph for two or more newlines, generate line break for single newlines)
 2015-10-10 22:04:37 +02:00
Chocobozzz 53af2bd75c Fix echonest qt5 compilation issues with different GNU/Linux distributions 2015-07-08 19:00:14 +02:00