Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity
8,266 Commits 23 Branches 533 Tags 239 MiB
Commit Graph

23 Commits

Author SHA1 Message Date
Lukas Prediger 83b6bf28f3 No exceptions for error handling! ConnectedDevice::Init now returns bool, indicating success or failure. 
As decreed by @hatstand.
 2021-06-21 12:51:44 +01:00
John Maguire 341dc7326f Reformat all C++ 2020-09-22 14:56:06 +01:00
Jim Broadus 79b7e3fe13 Fix abort from Mtp loader thread. 
A commit in qt 5.7 changes a qWarning to a qFatal if a QThread is still running
when it's deleted. When we get the LoadFinished signal in MtpDevice, stop
the loader thread's event loop to avoid this situation.

See qtbase commit c8277b6e532
 2020-01-07 22:29:59 +00:00
Jim Broadus 6c159481ed Handle MTP connection failures more gracefully. (#6256) 
Currently, the failure to connect to an MTP device results in the UI displaying
an open device that appears empty. This change introduces a method
ConnectedDevice::ConnectAsync() that is expected to handle any connecting tasks
that could block asynchronously. Upon completion, this emits a ConnectFinished
signal that indicates success or failure. The row in the UI is only updated
after the successful response is received. Upon failure, DeviceManager will
clean up and the row in UI is left in the pre-connect state.

Currently, only the MtpDevice utilizes this mechanism. All other devices use a
default implementation that immediately reports success.
 2019-01-15 21:10:05 +00:00
Jim Broadus 122d28eab9 Fix device loader error messages. (#6215) 
GPodLoader and MtpLoader Error signals were connected to Error signals in their repective device classes, but the actual signal definition in ConnectedDevice was removed in a refactor several years ago. This change adds LoaderError slots to these device classes and reports the error in the manner of the refactored code.
 2018-11-28 10:23:31 +00:00
John Maguire bebd781fdf Reformat all non-3rd-party C/C++/Objective-C++. 
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
 -style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
 2014-02-07 16:34:20 +01:00
John Maguire 71893e4847 Use nullptr instead of NULL everywhere. 2014-02-06 17:29:59 +01:00
David Sansome bacef04405 Refactoring: remove a couple of the AlbumCoverLoader instances and instead use a shared CurrentArtLoader. 2012-02-26 14:40:51 +00:00
David Sansome 48f15c9fc7 Refactoring: instead of passing individual pointers to useful core classes (like TaskManager or LibraryBackend) to each class that uses them, pass one singleton-like Application instance everywhere. 2012-02-26 14:40:51 +00:00
David Sansome ccb9f8cf94 Use URLs everywhere instead of filenames. Move the URL parsing and song loading code out of individual playlist parsers and into the base class. Fix the playlist parser unit tests. 2011-04-28 12:27:53 +00:00
David Sansome 3eedc916ad Add a new logging system 2011-04-22 16:50:29 +00:00
David Sansome ed1a25693c Add missing licenses to debian/copyright, and add copyright information to each source file 2010-11-20 13:27:10 +00:00
John Maguire 902e4906e2 Some more Mac MTP work. 
Reminder: Ship libusb-compat, not legacy libusb as it is fucked.
 2010-09-02 22:35:00 +00:00
John Maguire 75a576a5c2 MTP support for Mac... Currently crashes the entire USB bus so I wouldn't use it. 2010-09-02 21:20:27 +00:00
David Sansome 0ed30857db Fix free space reporting for WMDM and MTP 2010-08-30 12:28:03 +00:00
David Sansome e4f5e97b17 Allow GetSupportedFiletypes to return an error, and make it possible to request a list of supported filetypes at the same time as opening the device for copying - making things much faster on MTP devices. 2010-08-30 12:22:15 +00:00
David Sansome 4b381e00fd Transcode files when copying them to devices 2010-08-29 19:22:21 +00:00
David Sansome 2f505aeb02 Lock access to MTP devices - if two threads try to connect at once it causes a crash 2010-08-29 13:49:24 +00:00
David Sansome 5001a5b3d1 Get a list of file formats supported by an MTP device 2010-08-29 00:08:39 +00:00
David Sansome 04e7e26088 Allow devices to report progress information about individual songs back to the Organise object. Implement this for MTP 2010-08-28 21:55:30 +00:00
David Sansome ff19d31403 Support removing files from MTP devices 2010-08-14 17:06:38 +00:00
David Sansome 9fda03aa60 Support copying files to MTP devices 2010-08-14 16:39:45 +00:00
David Sansome 3f5e188045 Initial support for MTP devices 2010-08-14 15:57:05 +00:00