Commit Graph

800 Commits

Author SHA1 Message Date
Mark Furneaux c890af6306 More elegant solution to last commit
set_current_row now takes optional parameter "is_stopping" for when auto stop
is enabled.
2014-04-25 22:45:25 -04:00
Mark Furneaux 416d06bb06 Fix stop after track
Stop after track would cause now playing widget, OSD, and last.fm
scrobbler to change to next track after stopping. This patch prevents
set_current_row() from firing an event which triggers the track change.
2014-04-25 14:30:31 -04:00
vkrishtal 42f62be5b6 Fix after review 2014-04-25 08:57:31 +04:00
vkrishtal 69b4f9113a BugFix: clementine cannot delete directories in file tab #858 2014-04-25 00:28:22 +04:00
David Sansome b9279ca128 Merge pull request #4263 from abika/master
Load all songs that require disc-read non-blocking.
2014-04-12 16:03:55 +02:00
Alexander Bikadorov 66fcaefed9 Documentation update for async song load. 2014-04-07 15:38:26 +02:00
Alexander Bikadorov a056a87c8e Coding style fixes for async song load. 2014-04-07 15:27:47 +02:00
John Maguire 4ed6f94211 Open the right part of the system preferences for global shortcuts on Mavericks. 2014-04-02 16:27:07 +02:00
Alexander Bikadorov 0d199be5a7 Load all songs that require disc-read non-blocking. 2014-04-02 15:57:01 +02:00
David Sansome 6d1dc56a7c Get a list of available audio devices from pulseaudio, and let the user choose
from those in the settings dialog instead of just giving him a text box.
2014-03-29 19:31:38 +11:00
John Maguire 4ab4bbc23f Remove Last.fm radio support.
Fixes #4259
2014-03-28 14:55:04 +01:00
Maltsev Vlad a7b0accd93 Add Vk.com plugin. 2014-03-08 00:58:50 +07:00
John Maguire 5146bcdebc Some more NULL -> nullptr conversions. 2014-02-21 17:30:46 +01:00
John Maguire 192b60d965 Use nullptr as parent parameter default everywhere 2014-02-10 16:03:54 +01:00
John Maguire 3323c2d094 Convert all instances of foreach() to a C++11 for
find ext src -name '*.cpp' -exec \
    sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
Alexander Bikadorov 2ab8ab8077 Use double click settings as default behaviour for new files added as command line arguments. 2014-02-07 20:28:37 +01:00
Krzysztof A. Sobiecki 0ecf1e76a6 Reformat done with clang-3.5 svn200967 2014-02-07 17:08:31 +01:00
John Maguire bebd781fdf Reformat all non-3rd-party C/C++/Objective-C++.
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
 -style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
John Maguire 3df3a5b645 Add missing header for syscall().
This is cunningly not defined in syscall.h
2014-02-06 19:03:10 +01:00
John Maguire 8d1f4612db Hide use of boost multi-index behind pimpl. 2014-02-06 17:53:33 +01:00
John Maguire 71893e4847 Use nullptr instead of NULL everywhere. 2014-02-06 17:29:59 +01:00
John Maguire d309d4ab27 Use c++11 instead of boost where possible. 2014-02-06 16:51:39 +01:00
Arnaud Bienner 7084697aa3 Prevent Clementine to loop forever when trying to play a song with repeat enabled in a playlist which contains only unavailable songs 2014-02-04 22:08:32 +01:00
John Maguire ddda13ceb7 u_int8_t is missing on mingw 2014-02-04 14:10:59 +01:00
Arnaud Bienner a349a96f5a Avoid having similar filenames when organising songs (number them instead) 2014-02-02 19:28:45 +01:00
David Sansome 96075faf88 Namespace clementine's 3rdparty implementation of sha2 to prevent its symbols
conflicting with the system's openssl symbols with the same names.

This was causing SSL connections to fail in weird ways on Debian.

Fixes #4130.
2014-02-02 20:25:11 +11:00
Arnaud Bienner 06184cc5fb Avoid having empty filenames, or filenames with extension only.
In this case, keep the original filename.
2014-02-01 03:22:41 +01:00
John Maguire 7ddf3aab45 Merge pull request #4145 from sobkas/master
Initial support for "Copy to device" in a podcast section
2014-01-31 04:31:43 -08:00
John Maguire b96ec7555a Reformat all Objective-C++ files with clang-format.
clang-format -style=Google -i src/*/*.mm
2014-01-30 14:54:51 +01:00
Krzysztof A. Sobiecki 361cca83cb Cpplint.py fixes 2014-01-29 17:30:58 +01:00
Krzysztof A. Sobiecki 09d68bf415 Scrub the auto usage, use unique_ptr, use correct types instead of QList 2014-01-28 17:01:14 +01:00
Krzysztof A. Sobiecki b0a97de603 Use more auto in for statements 2014-01-27 23:59:38 +01:00
Krzysztof A. Sobiecki f7be18b326 Fixed some problems reported by cpplint.py, changed foreach to for in files touched by me 2014-01-27 23:59:38 +01:00
Krzysztof A. Sobiecki 35060d6916 I accidently break this, nothing to see here 2014-01-27 23:59:37 +01:00
Krzysztof A. Sobiecki 4944e99d56 Fix copy functionality, break copy of a directory 2014-01-27 23:59:37 +01:00
Krzysztof A. Sobiecki f60327b1d1 Initial 'Copy to device' support for podcasts 2014-01-27 23:59:36 +01:00
David Sansome 5ac83bd463 Merge branch 'master' into gstreamer-1.2 2014-01-25 00:24:31 +11:00
David Sansome f816a47ad9 Make SongLoader add URLs as raw streams if there exists a URL handler
for that scheme.  This fixes a bug where sky:// URLs couldn't be added
with MPRIS.
2014-01-24 23:54:38 +11:00
David Sansome dc5670edfb Encode song URLs when inserting them into the database. This was broken by revision 98dd001a. Fixes issue #4127 2014-01-20 21:39:18 +11:00
Andreas 7ad1d7abc3 Remote: Use sha1 instead of md5 for file hashing. 2014-01-18 18:33:49 +01:00
John Maguire 1a972e0f36 Fix rendering of source icons in playlist view on retina OS X 10.9 2014-01-10 16:57:32 +01:00
Andreas 94ccd325d7 - Move sha1 cover hash to utilities
- When initializing song check if we have a cover art. If not, check if there is one in the cache and use this.
2013-12-31 15:21:50 +01:00
Martin Brodbeck 774027a927 Removed tobytearray macro because it coerces to ASCII. 2013-12-12 15:41:49 +01:00
Martin Brodbeck 6be0964258 Make sure that we feed set_url() with a QUrl from an UTF-8 encoded string. 2013-12-12 15:41:49 +01:00
Alexander Bikadorov 5207af6f93 Create QShortcuts to catch key bindings from global shorcuts and hide them from widgets
Fixes issue 722
2013-12-02 21:36:14 +11:00
Arnaud Bienner 503b8445ad Remove debug message 2013-11-22 20:52:14 +01:00
John Maguire 4c23072bef Link dynamically against sqlite3 but still use a copy of QSqlLiteDriver 2013-11-22 16:31:41 +00:00
Aggelos Biboudis 2647fe4bbc Emit MPRIS notification when we add or remove a playlist.
Fixes issue 3962.
2013-11-19 00:13:45 +01:00
Arnaud Bienner 51d9080a81 Update issue 3962: don't try to activate a playlist which doesn't exist/isn't opened anymore (otherwise we crash on Q_ASSERT) 2013-11-16 19:53:02 +01:00
Andreas afae01156d Merge branch 'portable' 2013-10-26 09:34:07 +02:00
Andreas f6ab3a9044 Fix library download in network remote. 2013-10-25 20:31:56 +02:00
Andreas 98dd001a4f Further work on portable version. 2013-10-03 17:08:42 +02:00
Andreas acb18cdcde First tries on a portable version. 2013-09-29 10:43:34 +02:00
John Maguire 56c949815b First pass at Gstreamer 1.0 porting.
This at least compiles against gstreamer 1.2.
Things that work:
* Playing audio
* Automatically completing tags

Things that don't work
* Spotify
* Moodbar

Things I haven't tested
* Transcoding
2013-09-26 17:49:24 +02:00
David Sansome 1efd88cc2a Create a Fatal logging level, and use it when sqlite symbols can't be resolved.
(cherry picked from commit f0b9120c43)
2013-09-18 01:24:36 +02:00
David Sansome f0b9120c43 Create a Fatal logging level, and use it when sqlite symbols can't be resolved. 2013-09-18 00:15:46 +10:00
Glad Olus efc5f31d9b Use short locale format in playlist view.
Fixes issue #1451
(cherry picked from commit f8efbd81e4)
2013-09-07 19:58:10 +02:00
Glad Olus f8efbd81e4 Use short locale format in playlist view.
Fixes issue #1451
2013-08-29 16:31:29 +02:00
Andreas 53b8f59e6f Try to fix Windows build. 2013-08-01 19:13:43 +02:00
Andreas 3a309e9b25 Added message to retrive the library (table songs). 2013-08-01 18:13:14 +02:00
Arnaud Bienner fc1880161c Add a 'language_without_region' as this is not specific to networkremotesettingpage 2013-07-27 19:23:55 +02:00
David Sansome 1a3f6af1bd Clean up the network remote settings page, add a "Get it on Google Play" button. 2013-07-27 15:27:08 +10:00
Andreas 1e4819f2df Add stop after current track feature to network remote. 2013-07-20 19:38:37 +02:00
John Maguire f166954495 Add Google cpplint & lint one class 2013-07-19 15:38:22 +02:00
David Sansome eb20fb5945 Remove all the soruce for WMDM devices. Fixes issue 3748 2013-06-30 08:25:12 +00:00
Andreas ecd94cf472 Oops. 2013-06-09 16:41:02 +02:00
Andreas a6a8997a2e Use QDir::toNativeSeparators instead of QString::replace. Add QProcess include for windows build. 2013-06-09 16:29:40 +02:00
Andreas d16ac382ef Highlight the opened file in Windows Explorer. Fixes issue 3695. 2013-06-09 15:52:47 +02:00
Kevin Cox 9cc7169904 Used kNsecPerSec for milliseconds in a second. 2013-05-30 08:28:21 -04:00
Kevin Cox 7381f381e6 Added --restart-or-previous option.
Fixes bug #3524.
2013-05-29 15:27:07 -04:00
Arnaud Bienner c6068b16c9 Handle leading spaces when splitting schema update queries.
Otherwise the commands aren't splitted correctly, so the queries aren't run correctly, and the root cause might not be obvious.
2013-05-13 23:04:24 +02:00
Arnaud Bienner 5e6821dead Add a 'favorite' widget to playlist tab, and keep in playlistlist container only favorite playlists, instead of all playlists. 2013-05-11 23:18:03 +02:00
David Sansome fe964b9457 Never start playing a background stream on startup, even if it was enabled last time. 2013-05-04 19:26:24 +10:00
graehl 6fa77b8749 RevealFileInFinder for mac "show file in browser"
on mac, use QProcess to call "/usr/bin/open -R file", which highlights the file
when you context-menu click "show file in browser", instead of merely opening
the directory

Fixes issue #3634
2013-04-25 15:23:43 -07:00
David Sansome bb0f7412be Include any user-agent supplied by client libraries. Fixes issue 3612 2013-04-15 21:41:54 +10:00
pie.or.paj 18e8d6ca20 - Added basic playlist management (add and remove tracks) in network remote. 2013-04-13 11:57:05 +02:00
David Sansome 264d5ee0fa Add Radio GFM 2013-04-13 14:28:42 +10:00
Arnaud Bienner 88918d45c5 Update issue 1175:
Save rating and statistics in two distinct ways, and let users activate them separately in preferences.
2013-03-30 23:42:29 +01:00
Arnaud Bienner db5fbe2059 Update issue 1175:
Add an option in preferences to save all ratings/statistics into files, for all songs
2013-03-26 23:56:46 +01:00
David Sansome dc208962f6 Don't update device_ tables with %allsongstables_fts. 2013-03-15 20:25:38 +11:00
David Sansome d89954ae31 Fix style, hide the new columns by default, and move the new columns to the end of the enum 2013-03-10 18:16:14 +11:00
Uwe Klotz a6d3b48231 Extend tag support: performer, grouping
The transaction handling while upgrading the database schema had to be revised.
Furthermore some QSqlQuery statements needed to be finished properly.

Fixes issue 2556
2013-03-10 18:16:03 +11:00
Mateusz Kowalczyk 7f2c17a0b7 Add track rating/score to OSD.
Fixes issue #2586
2013-02-26 16:33:05 +01:00
Arnaud Bienner b5b371ef6f Use Qt's foreach instead of C++11 foreach, as it doesn't work with older versions of gcc 2013-02-24 19:16:52 +01:00
Arnaud Bienner 08d40f5fca Handle statistics tags apart, and write them to file when they change.
Next step: add a preference to activate this (should be deactivated by default IMO).
2013-02-24 17:45:25 +01:00
David Sansome 115964d1b4 Load local tags asynchronously in SongLoader. 2013-02-17 18:19:05 +11:00
David Sansome 4acafb4930 Remove some old code 2013-02-17 18:10:08 +11:00
Mateusz Kowalczyk 6904b06cf8 Add --increase-volume-by and --decrease-volume-by commandline options. Fixes issue 3496 2013-02-17 15:13:39 +11:00
John Maguire d21fa8cc67 Add support for Box. 2013-02-12 17:11:18 +01:00
Joel Bradshaw bb7a1e65f4 Adding spot for a unique album ID and implementing on Spotify
To resolve albums with duplicate tracks

Fixes issue 3429
2013-02-07 21:39:10 +01:00
Andreas 3cb7a76656 Add Engine::TrackChangeFlags as MetaType, so the connect workings. 2013-02-07 19:27:54 +01:00
Andreas f779e14df7 Fix connects for Repeat and Shuffle. They were never reached. 2013-02-03 21:09:48 +01:00
John Maguire 90803fa0e0 Remove use of deprecated gstreamer functions. 2013-01-29 13:19:26 +01:00
Martin Brodbeck d5139ac2b2 Add opus support to transcoder.
Fixes issue #3453
2013-01-28 14:09:31 +01:00
Martin Brodbeck d05041dfa1 Add support for Opus tags. 2013-01-26 11:18:24 +00:00
John Maguire fe2fb788d3 Merge branch 'subsonic'
Conflicts:
	data/data.qrc
2013-01-24 17:02:08 +01:00
Andreas 78ad2fb517 Fixed an issue where clementine could crash: A client connects before the playlist manager is
initialized. This caused a null pointer exception. Now the server is started after the
playlist manager was initialized.
2013-01-22 22:58:32 +01:00
Alan Briolat 349231793f Hacky basics of starting to load Subsonic library 2013-01-10 22:08:52 +00:00
John Maguire b7b7e97455 Merge branch 'master' of https://code.google.com/r/asfa194-clementineremote into remote 2013-01-08 13:05:54 +01:00
David Sansome 41f89904b6 Compare against the translated message text to determine whether a typefind failed. Fixes radio playlists in non-english languages. Fixes issue 3394 2013-01-04 21:16:26 +11:00