Funkwhale/Clementine-audio-player-Mac-Linux-Windows
1
0
Fork 0
mirror of https://github.com/clementine-player/Clementine synced 2024-12-18 20:34:39 +01:00
Code Issues Releases Wiki Activity

Don't allow tag inline editing anymore.

Browse Source 
This was a pretty good idea, but now we have a dedicated tag dialog editor, I'm not sure it is very useful. It was probably faster to edit tags this way, but I'm afraid lot of people may inadvertently modify their tags because of this. Still allow inline editing of score and comment, because they sound less critical to me.
Fixes issue 3251.
This commit is contained in:
Arnaud Bienner 2013-11-17 19:00:44 +01:00
parent 51d9080a81
commit e7a5c482fe
2 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/playlist/playlist.cpp
View File

@ -171,17 +171,6 @@ QVariant Playlist::headerData(int section, Qt::Orientation, int role) const {
bool Playlist::column_is_editable(Playlist::Column column) { bool Playlist::column_is_editable(Playlist::Column column) {
switch (column) { switch (column) {
case Column_Title:
case Column_Artist:
case Column_Album:
case Column_AlbumArtist:
case Column_Composer:
case Column_Performer:
case Column_Grouping:
case Column_Track:
case Column_Disc:
case Column_Year:
case Column_Genre:
case Column_Score: case Column_Score:
case Column_Comment: case Column_Comment:
return true; return true;

2
src/ui/mainwindow.cpp
View File

@ -1393,7 +1393,7 @@ void MainWindow::PlaylistRightClick(const QPoint& global_pos, const QModelIndex&
ui_->action_selection_set_value->setText(tr("Set %1 to \"%2\"...") ui_->action_selection_set_value->setText(tr("Set %1 to \"%2\"...")
.arg(column_name.toLower()).arg(column_value)); .arg(column_name.toLower()).arg(column_value));
ui_->action_edit_value->setText(tr("Edit tag \"%1\"...").arg(column_name)); ui_->action_edit_value->setText(tr("Edit \"%1\"...").arg(column_name));
// Is it a library item? // Is it a library item?
PlaylistItemPtr item = app_->playlist_manager()->current()->item_at(source_index.row()); PlaylistItemPtr item = app_->playlist_manager()->current()->item_at(source_index.row());