Funkwhale/Clementine-audio-player-Mac-Linux-Windows
1
0
Fork 0
mirror of https://github.com/clementine-player/Clementine synced 2024-12-15 10:48:33 +01:00
Code Issues Releases Wiki Activity

Fix the cover manager behaviour when there are unknown albums or albums by various artists.

Browse Source
This commit is contained in:
David Sansome 2010-03-12 00:54:18 +00:00
parent e809019bef
commit e1952e7ff2
2 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/albumcovermanager.cpp
View File

@ -140,6 +140,7 @@ void AlbumCoverManager::Reset() {
ui_.artists->clear();
new QListWidgetItem(all_artists_icon_, tr("All artists"), ui_.artists, All_Artists);
new QListWidgetItem(artist_icon_, tr("Various artists"), ui_.artists, Various_Artists);
foreach (const QString& artist, backend_->GetAllArtists()) {
if (artist.isEmpty())
@ -163,8 +164,21 @@ void AlbumCoverManager::ArtistChanged(QListWidgetItem* current) {
context_menu_items_.clear();
CancelRequests();
foreach (const LibraryBackend::Album& info,
backend_->GetAlbumsByArtist(artist)) {
// Get the list of albums. How we do it depends on what thing we have
// selected in the artist list.
LibraryBackend::AlbumList albums;
switch (current->type()) {
case Various_Artists: albums = backend_->GetCompilationAlbums(); break;
case Specific_Artist: albums = backend_->GetAlbumsByArtist(current->text()); break;
case All_Artists:
default: albums = backend_->GetAllAlbums(); break;
}
foreach (const LibraryBackend::Album& info, albums) {
// Don't show songs without an album, obviously
if (info.album_name.isEmpty())
continue;
QListWidgetItem* item = new QListWidgetItem(no_cover_icon_, info.album_name, ui_.albums);
item->setData(Role_ArtistName, info.artist);
item->setData(Role_AlbumName, info.album_name);

1
src/albumcovermanager.h
View File

@ -53,6 +53,7 @@ class AlbumCoverManager : public QDialog {
private:
enum ArtistItemType {
All_Artists,
Various_Artists,
Specific_Artist,
};