Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity

Force CBR when encoding MP3s using lame, for better compatibility with MP3 players

This commit is contained in:
David Sansome 2010-11-21 12:03:22 +00:00
parent 32b3e59f46
commit dd1c3b2e68
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/transcoder/transcoder.cpp
View File

@ -146,17 +146,32 @@ GstElement* Transcoder::CreateElementForMimeType(const QString& element_type,
if (best.name_ == "lamemp3enc") {
// Special case: we need to add xingmux and id3v2mux to the pipeline when
// using lamemp3enc because it doesn't write the VBR or ID3v2 headers itself.
// We also turn off VBR since it isn't compatible with some music players.
// TODO: Should make settings like these configurable.
LogLine("Adding xingmux and id3v2mux to the pipeline");
// Create the bin
GstElement* mp3bin = gst_bin_new("mp3bin");
gst_bin_add(GST_BIN(bin), mp3bin);
// Create the elements
GstElement* lame = CreateElement("lamemp3enc", mp3bin);
GstElement* xing = CreateElement("xingmux", mp3bin);
GstElement* id3v2 = CreateElement("id3v2mux", mp3bin);
if (!lame || !xing || !id3v2) {
return NULL;
}
// Configure the lame element
g_object_set(G_OBJECT(lame), "target", 1, NULL); // 1 == bitrate
g_object_set(G_OBJECT(lame), "cbr", true, NULL);
// Link the elements together
gst_element_link_many(lame, xing, id3v2, NULL);
// Link the bin's ghost pads to the elements on each end
GstPad* pad = gst_element_get_static_pad(lame, "sink");
gst_element_add_pad(mp3bin, gst_ghost_pad_new("sink", pad));
gst_object_unref(GST_OBJECT(pad));