Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity

Share the love: Minor corrections

This commit is contained in:
dmdmdm 2020-07-27 10:13:42 -04:00 committed by John Maguire
parent acb75a5099
commit d9fa56c179
3 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/ui/lovedialog.cpp
View File

@ -68,12 +68,11 @@ void LoveDialog::showEvent(QShowEvent* e) {
void LoveDialog::SongRated(float rating) { void LoveDialog::SongRated(float rating) {
qLog(Debug) << "LoveDialog::SongRated: rating=" << rating; qLog(Debug) << "LoveDialog::SongRated: rating=" << rating;
Song* song = &song_; qLog(Debug) << "LoveDialog::SongRated: isValid=" << song_.is_valid() << " id=" << song_.id();
qLog(Debug) << "LoveDialog::SongRated: isValid=" << song->is_valid() << " id=" << song->id(); if (!song_.is_valid() || song_.id() == -1) return;
if (!song->is_valid() || song->id() == -1) return;
qLog(Debug) << "LoveDialog::SongRated: song is valid and id is good"; qLog(Debug) << "LoveDialog::SongRated: song is valid and id is good";
song->set_rating(rating); song_.set_rating(rating);
app_->library_backend()->UpdateSongRatingAsync(song->id(), rating); app_->library_backend()->UpdateSongRatingAsync(song_.id(), rating);
QDialog::accept(); QDialog::accept();
} }

1
src/ui/lovedialog.h
View File

@ -21,7 +21,6 @@
#include <QDialog> #include <QDialog>
#include "core/song.h" #include "core/song.h"
//#include "widgets/lineedit.h"
class Application; class Application;
class Ui_LoveDialog; class Ui_LoveDialog;

7
src/ui/mainwindow.cpp
View File

@ -1589,8 +1589,8 @@ void MainWindow::ScrobbledRadioStream() {
#endif #endif
void MainWindow::Love() { void MainWindow::Love() {
Playlist* activePlaylist = app_->playlist_manager()->active(); Playlist* active_playlist = app_->playlist_manager()->active();
PlaylistItemPtr item = activePlaylist->current_item(); PlaylistItemPtr item = active_playlist->current_item();
if (!item) { if (!item) {
// Don't make a big deal about it // Don't make a big deal about it
qLog(Warning) << "Love: nothing playing so can't love it"; qLog(Warning) << "Love: nothing playing so can't love it";
@ -1598,7 +1598,8 @@ void MainWindow::Love() {
} }
if (item->IsLocalLibraryItem()) { if (item->IsLocalLibraryItem()) {
Song song = item->Metadata(); const Song& song = item->Metadata();
if (!song.is_valid() || song.id() == -1) return;
love_dialog_->SetSong(song); love_dialog_->SetSong(song);
love_dialog_->show(); love_dialog_->show();
} }