Funkwhale/Clementine-audio-player-Mac-Linux-Windows
1
0
Fork 0
mirror of https://github.com/clementine-player/Clementine synced 2024-12-14 02:14:21 +01:00
Code Issues Releases Wiki Activity

Don't run searches for a preview widget while it's hidden, and run one as soon as the sort page is shown

Browse Source
This commit is contained in:
David Sansome 2010-11-20 12:33:21 +00:00
parent ffdfc0ed34
commit d214d36a1d
3 changed files with 22 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/smartplaylists/querywizardplugin.cpp
View File

@ -57,11 +57,15 @@ public:
class QueryWizardPlugin::SortPage : public QWizardPage {
public:
SortPage(QWidget* parent, int next_id)
: QWizardPage(parent), next_id_(next_id) {}
SortPage(QueryWizardPlugin* plugin, QWidget* parent, int next_id)
: QWizardPage(parent), next_id_(next_id), plugin_(plugin) {}
void showEvent(QShowEvent*) { plugin_->UpdateSortPreview(); }
int nextId() const { return next_id_; }
int next_id_;
QueryWizardPlugin* plugin_;
};
@ -86,7 +90,7 @@ int QueryWizardPlugin::CreatePages(QWizard* wizard, int finish_page_id) {
// Create the UI
search_page_ = new SearchPage(wizard);
QWizardPage* sort_page = new SortPage(wizard, finish_page_id);
QWizardPage* sort_page = new SortPage(this, wizard, finish_page_id);
sort_ui_.reset(new Ui_SmartPlaylistQuerySortPage);
sort_ui_->setupUi(sort_page);

14
src/smartplaylists/searchpreview.cpp
View File

@ -63,8 +63,8 @@ void SearchPreview::Update(const Search& search) {
return;
}
if (generator_) {
// It's busy generating something already
if (generator_ || isHidden()) {
// It's busy generating something already, or the widget isn't visible
pending_search_ = search;
return;
}
@ -72,6 +72,16 @@ void SearchPreview::Update(const Search& search) {
RunSearch(search);
}
void SearchPreview::showEvent(QShowEvent* e) {
if (pending_search_.is_valid() && !generator_) {
// There was a search waiting while we were hidden, so run it now
RunSearch(pending_search_);
pending_search_ = Search();
}
QWidget::showEvent(e);
}
void SearchPreview::RunSearch(const Search& search) {
generator_.reset(new QueryGenerator);
generator_->set_library(backend_);

3
src/smartplaylists/searchpreview.h
View File

@ -42,6 +42,9 @@ public:
void Update(const Search& search);
protected:
void showEvent(QShowEvent*);
private:
void RunSearch(const Search& search);