Disable this Spotify hack for now, as it is useless anyway.
Somewhat related to issue #4545, but when plugin was installed by user wasn't logged in.
This commit is contained in:
parent
e9dc93942d
commit
96387803cd
|
@ -95,11 +95,18 @@ GstEnginePipeline::GstEnginePipeline(GstEngine* engine)
|
||||||
|
|
||||||
for (int i = 0; i < kEqBandCount; ++i) eq_band_gains_ << 0;
|
for (int i = 0; i < kEqBandCount; ++i) eq_band_gains_ << 0;
|
||||||
|
|
||||||
// Spotify hack
|
// FIXME Currently useless Spotify hack: we currently don't know what to do
|
||||||
if (InternetModel::Service<SpotifyService>()->IsBlobInstalled()) {
|
// when the seek is completed. We should flush the current buffers, but see
|
||||||
connect(InternetModel::Service<SpotifyService>()->server(), SIGNAL(SeekCompleted()),
|
// comments in SpotifySeekCompleted for why that doesn't work.
|
||||||
SLOT(SpotifySeekCompleted()));
|
// If we fix and reactivate this code, we will have another problem though:
|
||||||
}
|
// calling server() try to login the user. If the user doesn't use Spotify, it
|
||||||
|
// will receive an error message. We should have a lightweight version of
|
||||||
|
// server() that just return it (or NULL) without trying to create it IMO to
|
||||||
|
// avoid this issue.
|
||||||
|
//if (InternetModel::Service<SpotifyService>()->IsBlobInstalled()) {
|
||||||
|
// connect(InternetModel::Service<SpotifyService>()->server(), SIGNAL(SeekCompleted()),
|
||||||
|
// SLOT(SpotifySeekCompleted()));
|
||||||
|
//}
|
||||||
}
|
}
|
||||||
|
|
||||||
void GstEnginePipeline::set_output_device(const QString& sink,
|
void GstEnginePipeline::set_output_device(const QString& sink,
|
||||||
|
@ -963,6 +970,7 @@ void GstEnginePipeline::SpotifySeekCompleted() {
|
||||||
// to do this without breaking the streaming completely...
|
// to do this without breaking the streaming completely...
|
||||||
// Funny thing to notice: for me the delay varies when changing buffer size,
|
// Funny thing to notice: for me the delay varies when changing buffer size,
|
||||||
// but a larger buffer doesn't necessary increase the delay.
|
// but a larger buffer doesn't necessary increase the delay.
|
||||||
|
// FIXME: also, this method is never called currently (see constructor)
|
||||||
}
|
}
|
||||||
|
|
||||||
void GstEnginePipeline::SetEqualizerEnabled(bool enabled) {
|
void GstEnginePipeline::SetEqualizerEnabled(bool enabled) {
|
||||||
|
|
Loading…
Reference in New Issue