Add a makefile target to dump and upload breakpad symbols

3rdparty/google-breakpad/CMakeLists.txt

@@ -91,6 +91,8 @@ endif()
 
 add_library(libbreakpad_common STATIC ${COMMON_SOURCES})
 add_library(breakpad STATIC ${LIBRARY_SOURCES})
+
+# This is used by cmake/DumpSymbols.cmake
 add_executable(dump_syms ${DUMP_SYMS_SOURCES})
 
 target_link_libraries(breakpad libbreakpad_common)

CMakeLists.txt

@@ -454,6 +454,10 @@ if(HAVE_MOODBAR)
   add_subdirectory(gst/moodbar)
 endif()
 
+# Breakpad symbol target.  Included after everything else since it uses some
+# variables defined above.
+include(cmake/DumpSymbols.cmake)
+
 # Uninstall support
 configure_file(
   "${CMAKE_CURRENT_SOURCE_DIR}/cmake_uninstall.cmake.in"

cmake/DumpSymbols.cmake

@@ -0,0 +1,14 @@
+if (HAVE_BREAKPAD)
+  add_custom_target(breakpad_symbols
+    WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
+    COMMAND python
+            ../dist/dump_all_symbols.py
+            --symbols_directory breakpad_symbols
+            --dump_syms_binary "$<TARGET_FILE:dump_syms>"
+            --crashreporting_hostname "${CRASHREPORTING_HOSTNAME}"
+            "$<TARGET_FILE:clementine>"
+    COMMENT "Dumping and uploading breakpad symbols to ${CRASHREPORTING_HOSTNAME}"
+  )
+
+  add_dependencies(breakpad_symbols clementine dump_syms)
+endif()

dist/dump_all_symbols.py

@@ -28,8 +28,15 @@ class BaseDumperImpl(object):
     raise NotImplementedError
 
   def DebugSymbolsFilename(self, filename):
+    class Context(object):
+      def __enter__(self):
         return filename
 
+      def __exit__(self, exc_type, exc_value, traceback):
+        pass
+
+    return Context()
+
 
 class LinuxDumperImpl(BaseDumperImpl):
   def GetLinkedLibraries(self, filename):