Funkwhale/Clementine-audio-player-Mac-Linux-Windows
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #6424 from uqs/master

Browse Source 
Fix Clementine on FreeBSD/NFS files, where birthtime is always -1
This commit is contained in:
John Maguire 2019-10-28 10:03:49 +00:00 committed by GitHub
commit 68d4706765
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 25 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
ext/libclementine-tagreader/tagreader.cpp
View File

@ -122,13 +122,34 @@ void TagReader::ReadFile(const QString& filename,
const QByteArray url(QUrl::fromLocalFile(filename).toEncoded());
const QFileInfo info(filename);
qLog(Debug) << "Reading tags from" << filename;
song->set_basefilename(DataCommaSizeFromQString(info.fileName()));
song->set_url(url.constData(), url.size());
song->set_filesize(info.size());
song->set_mtime(info.lastModified().toTime_t());
song->set_ctime(info.created().toTime_t());
#if QT_VERSION >= 0x051000
qint64 mtime = info.lastModified().toSecsSinceEpoch();
qint64 btime = info.birthtime().toSecsSinceEpoch();
#elif QT_VERSION >= 0x050800
qint64 mtime = info.lastModified().toSecsSinceEpoch();
qint64 btime = info.created().toSecsSinceEpoch();
#else
// Legacy 32bit API.
uint mtime = info.lastModified().toTime_t();
uint btime = info.created().toTime_t();
#endif
song->set_mtime(mtime);
// NOTE: birthtime isn't supported by all filesystems or NFS implementations.
// -1 is often returned if not supported. Note further that for the
// toTime_t() call this returns an unsigned int, i.e. UINT_MAX.
if (btime == -1) {
btime = mtime;
}
song->set_ctime(btime);
qLog(Debug) << "Reading tags from" << filename << ". Got tags:"
<< "size=" << info.size() << "; mtime=" << mtime
<< "; birthtime=" << btime;
std::unique_ptr<TagLib::FileRef> fileref(factory_->GetFileRef(filename));
if (fileref->isNull()) {