Funkwhale/Clementine-audio-player-Mac-Linux-Windows
1
0
Fork 0
mirror of https://github.com/clementine-player/Clementine synced 2024-12-22 15:58:45 +01:00
Code Issues Releases Wiki Activity

libclementine-common: Use positive numbers for worker ids.

Browse Source 
QRandomGenerator::generate() returns an unbounded int32, while the legacy
qrand method always returned a positive number. When generating a tag
reader ID with QRandomGenerator, cast the random value to an unsigned so
that it is formatted as a positive number in the name.

Note that most usages of QRandomGenrator in the codebase use bounded()
instead of generate(), and should work as expected.
This commit is contained in:
Jim Broadus 2021-04-21 14:35:12 -07:00 committed by John Maguire
parent 73c0af1977
commit 5f75bde396
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ext/libclementine-common/core/workerpool.h
View File

@ -278,7 +278,7 @@ void WorkerPool<HandlerType>::StartOneWorker(Worker* worker) {
const int unique_number = qrand() ^ ((int)(quint64(this) & 0xFFFFFFFF)); const int unique_number = qrand() ^ ((int)(quint64(this) & 0xFFFFFFFF));
#else #else
// The global generator is securely seeded. // The global generator is securely seeded.
const int unique_number = QRandomGenerator::global()->generate(); const unsigned int unique_number = QRandomGenerator::global()->generate();
#endif #endif
const QString name = const QString name =
QString("%1_%2").arg(local_server_name_).arg(unique_number); QString("%1_%2").arg(local_server_name_).arg(unique_number);