Funkwhale/Clementine-audio-player-Mac-Linux-Windows
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

playlist: call InformOfCurrentSongChange only after updating the virtual index

Browse Source 
Calling InformOfCurrentSongChange before updating the virtual index results in
sending the CanGoNext and CanGoPrevious notifications with the wrong values.
This commit is contained in:
Victor Dodon 2016-03-10 21:20:53 +00:00
parent 5f14e887a7
commit 5b066991ab
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/playlist/playlist.cpp
View File

@ -633,10 +633,6 @@ void Playlist::set_current_row(int i, bool is_stopping) {
old_current_item_index.row(), ColumnCount - 1));
}
if (current_item_index_.isValid() && !is_stopping) {
InformOfCurrentSongChange();
}
// Update the virtual index
if (i == -1) {
current_virtual_index_ = -1;
@ -655,6 +651,10 @@ void Playlist::set_current_row(int i, bool is_stopping) {
current_virtual_index_ = i;
}
if (current_item_index_.isValid() && !is_stopping) {
InformOfCurrentSongChange();
}
// The structure of a dynamic playlist is as follows:
// history - active song - future
// We have to ensure that this invariant is maintained.